[DataFactory] - Add CosmosDbSqlApi dataset #7242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Testing, Please Ignore[Logs] (Generated from 8188f2e, Iteration 4)
|
shawnxzq
changed the title
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
|
Can one of the admins verify this patch? |
shawnxzq
changed the title
This was referenced Sep 20, 2019
Juliehzl
reviewed
Sep 21, 2019
| }, | ||
| "encryptedCredential": { | ||
| "type": "object", | ||
| "description": "The encrypted credential used for authentication. Credentials are encrypted using the integration runtime credential manager. Type: string (or Expression with resultType string)." | ||
| } | ||
| }, | ||
| "required": [ |
There was a problem hiding this comment.
Why do you make connection not required here?
There was a problem hiding this comment.
We added dedicated properties to include information which must be in connectionString before. So its's not required any more and it is still backward compatible.
Juliehzl
reviewed
Sep 21, 2019
...tafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Pipeline.json
Show resolved
Hide resolved
Juliehzl
added
the
WaitForARMFeedback
|
Remove [WaitForARMFeedback] label because "For Azure Data Factory team(ADF), Per their agreement with ARM team, no breaking change". |
|
LGTM. Approved. |
Juliehzl
approved these changes
Sep 24, 2019
Juliehzl
removed
the
WaitForARMFeedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.