Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SQL VM Rest API #7324

Merged
merged 6 commits into from
Oct 4, 2019
Merged

Conversation

sam0227
Copy link
Contributor

@sam0227 sam0227 commented Sep 25, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Sep 25, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5950

@AutorestCI
Copy link

AutorestCI commented Sep 25, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#7609

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@PhoenixHe-NV
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@lirenhe lirenhe added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 26, 2019
@lirenhe
Copy link
Member

lirenhe commented Sep 26, 2019

@sam0227 , could you check the model validation error and fix the issue?

Copy link
Contributor

@nschonni nschonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add "LUNs" to ./custom-words.txt to fix the other spelling issues

@sam0227
Copy link
Contributor Author

sam0227 commented Sep 26, 2019

@lirenhe Fixed the issues.

@ravbhatnagar
Copy link
Contributor

@sam0227 - Adding new writable properties to an existing API-version is a breaking change. It must be done in a new api-version. WHat is the impact of this property being set using for example portal, and then fetched by doing GET from an older SDK which does not understand this property (hence ignores it). And then PUT from the older SDK without this property on the same resource which has this property set. Will the service overwrite the goal state.
Since its preview, it may be ok, but please note that customers can still be broken or can make unintentional breaking changes to the resource.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Sep 28, 2019
@sam0227
Copy link
Contributor Author

sam0227 commented Oct 1, 2019

@ravbhatnagar These properties allow the user to configure the storage pool related to SQL. If the properties are not set it'll be no-op so it should have no impact if someone do GET and PUT are from older SDK. We don't have a plan for a new API version for now.

@vasivara-MSFT Add Vairavan who owns the list sqlvm operation

@sam0227 sam0227 closed this Oct 1, 2019
@ravbhatnagar
Copy link
Contributor

SIgning off from ARM side. RP implementation is not a true PUT and so it will not cause unintentional destructive behavior for customers.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 3, 2019
@lirenhe lirenhe merged commit f025cc9 into Azure:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants