-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SQL VM Rest API #7324
Update SQL VM Rest API #7324
Conversation
In Testing, Please Ignore[Logs] (Generated from c7976a7, Iteration 14).NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
|
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Can one of the admins verify this patch? |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
@sam0227 , could you check the model validation error and fix the issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could add "LUNs" to ./custom-words.txt to fix the other spelling issues
...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json
Outdated
Show resolved
Hide resolved
...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json
Outdated
Show resolved
Hide resolved
...almachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2017-03-01-preview/sqlvm.json
Outdated
Show resolved
Hide resolved
@lirenhe Fixed the issues. |
@sam0227 - Adding new writable properties to an existing API-version is a breaking change. It must be done in a new api-version. WHat is the impact of this property being set using for example portal, and then fetched by doing GET from an older SDK which does not understand this property (hence ignores it). And then PUT from the older SDK without this property on the same resource which has this property set. Will the service overwrite the goal state. |
@ravbhatnagar These properties allow the user to configure the storage pool related to SQL. If the properties are not set it'll be no-op so it should have no impact if someone do GET and PUT are from older SDK. We don't have a plan for a new API version for now. @vasivara-MSFT Add Vairavan who owns the list sqlvm operation |
SIgning off from ARM side. RP implementation is not a true PUT and so it will not cause unintentional destructive behavior for customers. |
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.