Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data Factory] Add data flow compute property in IR. #7325

Merged
merged 4 commits into from
Sep 27, 2019
Merged

[Data Factory] Add data flow compute property in IR. #7325

merged 4 commits into from
Sep 27, 2019

Conversation

jackmagic313
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 26, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 45a2f10, Iteration 4)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Failed datafactory/resource-manager/v2017_09_01_preview [Logs]
  • Failed datafactory/resource-manager/v2018_06_01 [Logs]
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • In-Progress datafactory/mgmt/2018-06-01 [Logs]
  • In-Progress preview/datafactory/mgmt/2017-09-01-preview [Logs]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • No packages generated.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Sep 26, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 26, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#7315

@AutorestCI AutorestCI mentioned this pull request Sep 26, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Sep 26, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#5911

This was referenced Sep 26, 2019
Merged
Closed
@mmyyrroonn mmyyrroonn added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 26, 2019
ravbhatnagar
ravbhatnagar reviewed Sep 27, 2019
View reviewed changes
Copy link
Contributor

@ravbhatnagar ravbhatnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackmagic313 - few comments

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json
@@ -3751,6 +3752,7 @@
}
},
"description": "Execute a data flow debug command.",
"x-ms-long-running-operation": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a breaking change. you are changing something from sync to async? the response codes will change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jack Ma confirmed that this API POST action was added 2 days ago and this flag was missed. The SDKs have not been published, so shouldn't be breaking.

...resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/IntegrationRuntime.json
@@ -100,6 +100,10 @@
"type": "integer",
"minimum": 1
},
"dataFlowProperties": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding new writable properties is a breaking change and must be done in a new API version. But I think for datafactory an exception was given before. SO I am fine signing off on this. But please ensure customer cant unintentionally overwrite the goal state of the resource when making an update from an older SDK.

@ravbhatnagar
Copy link
Contributor

Signing off from ARM side.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 27, 2019
@jhendrixMSFT jhendrixMSFT merged commit dce1ac7 into Azure:master Sep 27, 2019
@AutorestCI AutorestCI mentioned this pull request Sep 27, 2019
Merged
@jackmagic313 jackmagic313 mentioned this pull request Sep 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravbhatnagar ravbhatnagar ravbhatnagar left review comments

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@mmyyrroonn mmyyrroonn Awaiting requested review from mmyyrroonn

Assignees

@mmyyrroonn mmyyrroonn

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jackmagic313 @azuresdkci @AutorestCI @ravbhatnagar @jhendrixMSFT @mmyyrroonn