Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angos/msi extensionresource #7528

Merged
merged 25 commits into from
Feb 3, 2020
Merged

Angos/msi extensionresource #7528

merged 25 commits into from
Feb 3, 2020

Conversation

angosms
Copy link
Contributor

@angosms angosms commented Oct 16, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 16, 2019 •
edited
Loading

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@AutorestCI
Copy link

AutorestCI commented Oct 16, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#8872

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Oct 16, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#6298

@AutorestCI AutorestCI mentioned this pull request Nov 7, 2019
Closed
@PhoenixHe-NV
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 10, 2020 •
edited
Loading

azure-sdk-for-net - Release

❌ failed [Logs] [Expand Details]
  • ❌ Generate from c01cc28 with merge commit 8ed021e. SDK Automation 13.0.17.20191226.1 
    [AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
  • ❌Microsoft.Azure.Management.ManagedServiceIdentity [Logs]  [Release SDK Changes] 
      Failed to create the package Microsoft.Azure.Management.ManagedServiceIdentity.
Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=managedserviceidentity /v:n /p:SkipTests=true , {}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jan 10, 2020 •
    edited
    Loading

    azure-sdk-for-js - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from c01cc28 with merge commit 8ed021e. SDK Automation 13.0.17.20191226.1
    • ️✔️@azure/arm-msi [Logs]  [Release SDK Changes] 
      [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/managedServiceIdentityClient.js → ./dist/arm-msi.js...
[npmPack] created ./dist/arm-msi.js in 216ms

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jan 10, 2020 •
    edited
    Loading

    azure-sdk-for-java - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from c01cc28 with merge commit 8ed021e. SDK Automation 13.0.17.20191226.1
    • ⚠️sdk/managedserviceidentity/mgmt-v2015_08_31_preview [Logs]  [Release SDK Changes] 
        [mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/managedserviceidentity/mgmt-v2015_08_31_preview/src/main/java/com/microsoft/azure/management/managedserviceidentity/v2015_08_31_preview/implementation/UserAssignedIdentitiesImpl.java:[26,173] interface expected here
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/managedserviceidentity/mgmt-v2015_08_31_preview/src/main/java/com/microsoft/azure/management/managedserviceidentity/v2015_08_31_preview/implementation/ManagedIdentityManager.java:[104,43] incompatible types: com.microsoft.azure.management.managedserviceidentity.v2015_08_31_preview.implementation.UserAssignedIdentitiesImpl cannot be converted to com.microsoft.azure.management.managedserviceidentity.v2015_08_31_preview.UserAssignedIdentities
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/managedserviceidentity/mgmt-v2015_08_31_preview/src/main/java/com/microsoft/azure/management/managedserviceidentity/v2015_08_31_preview/implementation/UserAssignedIdentitiesImpl.java:[26,93] type argument com.microsoft.azure.management.managedserviceidentity.v2015_08_31_preview.implementation.IdentityInner is not within bounds of type-variable InnerT
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/managedserviceidentity/mgmt-v2015_08_31_preview/src/main/java/com/microsoft/azure/management/managedserviceidentity/v2015_08_31_preview/implementation/UserAssignedIdentitiesImpl.java:[43,5] method does not override or implement a method from a supertype
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/managedserviceidentity/mgmt-v2015_08_31_preview/src/main/java/com/microsoft/azure/management/managedserviceidentity/v2015_08_31_preview/implementation/UserAssignedIdentitiesImpl.java:[58,5] method does not override or implement a method from a supertype
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/managedserviceidentity/mgmt-v2015_08_31_preview/src/main/java/com/microsoft/azure/management/managedserviceidentity/v2015_08_31_preview/implementation/UserAssignedIdentitiesImpl.java:[63,5] method does not override or implement a method from a supertype
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/managedserviceidentity/mgmt-v2015_08_31_preview/src/main/java/com/microsoft/azure/management/managedserviceidentity/v2015_08_31_preview/implementation/UserAssignedIdentitiesImpl.java:[70,5] method does not override or implement a method from a supertype
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/managedserviceidentity/mgmt-v2015_08_31_preview/src/main/java/com/microsoft/azure/management/managedserviceidentity/v2015_08_31_preview/implementation/UserAssignedIdentitiesImpl.java:[75,5] method does not override or implement a method from a supertype
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/managedserviceidentity/mgmt-v2015_08_31_preview/src/main/java/com/microsoft/azure/management/managedserviceidentity/v2015_08_31_preview/implementation/UserAssignedIdentitiesImpl.java:[81,5] method does not override or implement a method from a supertype
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/managedserviceidentity/mgmt-v2015_08_31_preview/src/main/java/com/microsoft/azure/management/managedserviceidentity/v2015_08_31_preview/implementation/UserAssignedIdentitiesImpl.java:[99,5] method does not override or implement a method from a supertype
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/managedserviceidentity/mgmt-v2015_08_31_preview/src/main/java/com/microsoft/azure/management/managedserviceidentity/v2015_08_31_preview/implementation/UserAssignedIdentitiesImpl.java:[105,5] method does not override or implement a method from a supertype
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/managedserviceidentity/mgmt-v2015_08_31_preview/src/main/java/com/microsoft/azure/management/managedserviceidentity/v2015_08_31_preview/implementation/UserAssignedIdentitiesImpl.java:[123,5] method does not override or implement a method from a supertype
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/managedserviceidentity/mgmt-v2015_08_31_preview/src/main/java/com/microsoft/azure/management/managedserviceidentity/v2015_08_31_preview/implementation/IdentityImpl.java:[16,64] type argument com.microsoft.azure.management.managedserviceidentity.v2015_08_31_preview.implementation.IdentityInner is not within bounds of type-variable InnerModelT
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-managedidentity: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/managedserviceidentity/mgmt-v2015_08_31_preview/src/main/java/com/microsoft/azure/management/managedserviceidentity/v2015_08_31_preview/implementation/UserAssignedIdentitiesImpl.java:[26,173] interface expected here
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/managedserviceidentity/mgmt-v2015_08_31_preview/src/main/java/com/microsoft/azure/management/managedserviceidentity/v2015_08_31_preview/implementation/ManagedIdentityManager.java:[104,43] incompatible types: com.microsoft.azure.management.managedserviceidentity.v2015_08_31_preview.implementation.UserAssignedIdentitiesImpl cannot be converted to com.microsoft.azure.management.managedserviceidentity.v2015_08_31_preview.UserAssignedIdentities
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/managedserviceidentity/mgmt-v2015_08_31_preview/src/main/java/com/microsoft/azure/management/managedserviceidentity/v2015_08_31_preview/implementation/UserAssignedIdentitiesImpl.java:[26,93] type argument com.microsoft.azure.management.managedserviceidentity.v2015_08_31_preview.implementation.IdentityInner is not within bounds of type-variable InnerT
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/managedserviceidentity/mgmt-v2015_08_31_preview/src/main/java/com/microsoft/azure/management/managedserviceidentity/v2015_08_31_preview/implementation/UserAssignedIdentitiesImpl.java:[43,5] method does not override or implement a method from a supertype
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/managedserviceidentity/mgmt-v2015_08_31_preview/src/main/java/com/microsoft/azure/management/managedserviceidentity/v2015_08_31_preview/implementation/UserAssignedIdentitiesImpl.java:[58,5] method does not override or implement a method from a supertype
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/managedserviceidentity/mgmt-v2015_08_31_preview/src/main/java/com/microsoft/azure/management/managedserviceidentity/v2015_08_31_preview/implementation/UserAssignedIdentitiesImpl.java:[63,5] method does not override or implement a method from a supertype
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/managedserviceidentity/mgmt-v2015_08_31_preview/src/main/java/com/microsoft/azure/management/managedserviceidentity/v2015_08_31_preview/implementation/UserAssignedIdentitiesImpl.java:[70,5] method does not override or implement a method from a supertype
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/managedserviceidentity/mgmt-v2015_08_31_preview/src/main/java/com/microsoft/azure/management/managedserviceidentity/v2015_08_31_preview/implementation/UserAssignedIdentitiesImpl.java:[75,5] method does not override or implement a method from a supertype
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/managedserviceidentity/mgmt-v2015_08_31_preview/src/main/java/com/microsoft/azure/management/managedserviceidentity/v2015_08_31_preview/implementation/UserAssignedIdentitiesImpl.java:[81,5] method does not override or implement a method from a supertype
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/managedserviceidentity/mgmt-v2015_08_31_preview/src/main/java/com/microsoft/azure/management/managedserviceidentity/v2015_08_31_preview/implementation/UserAssignedIdentitiesImpl.java:[99,5] method does not override or implement a method from a supertype
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/managedserviceidentity/mgmt-v2015_08_31_preview/src/main/java/com/microsoft/azure/management/managedserviceidentity/v2015_08_31_preview/implementation/UserAssignedIdentitiesImpl.java:[105,5] method does not override or implement a method from a supertype
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/managedserviceidentity/mgmt-v2015_08_31_preview/src/main/java/com/microsoft/azure/management/managedserviceidentity/v2015_08_31_preview/implementation/UserAssignedIdentitiesImpl.java:[123,5] method does not override or implement a method from a supertype
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/managedserviceidentity/mgmt-v2015_08_31_preview/src/main/java/com/microsoft/azure/management/managedserviceidentity/v2015_08_31_preview/implementation/IdentityImpl.java:[16,64] type argument com.microsoft.azure.management.managedserviceidentity.v2015_08_31_preview.implementation.IdentityInner is not within bounds of type-variable InnerModelT
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
      • ⚠️sdk/managedserviceidentity/mgmt-v2018-11-30 [Logs]  [Release SDK Changes] 
          [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8:jar (default-cli) on project azure-mgmt-managedidentity: MavenReportException: Error while creating archive: 
[mvn] [ERROR] Exit code: 1 - javadoc: error - Illegal package name: "com.microsoft.azure.management.managedserviceidentity.v2018-11-30"
[mvn] [ERROR] 
[mvn] [ERROR] Command line was: /usr/lib/jvm/java-8-openjdk-amd64/jre/../bin/javadoc @options @packages
[mvn] [ERROR] 
[mvn] [ERROR] Refer to the generated Javadoc files in '/z/work/azure-sdk-for-java/sdk/managedserviceidentity/mgmt-v2018-11-30/target/apidocs' dir.
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Jan 10, 2020 •
        edited
        Loading

        azure-sdk-for-python - Release

        ️✔️ succeeded [Logs] [Expand Details]
        • ️✔️ Generate from c01cc28 with merge commit 8ed021e. SDK Automation 13.0.17.20191226.1
        • ️✔️azure-mgmt-msi [Logs]  [Release SDK Changes] 
          [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'

        This was referenced Jan 10, 2020
        Closed
        Closed
        Closed
        Closed
        Closed
        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @angosms
        Copy link
        Contributor Author

        angosms commented Jan 16, 2020

        @anuchandy Can you please review?

        @markcowl markcowl added Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates and removed Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates labels Jan 24, 2020
        @allenjzhang
        Copy link
        Member

        /azp run

        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 3 pipeline(s).

        @allenjzhang
        Copy link
        Member

        /azp run

        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 3 pipeline(s).

        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @allenjzhang
        Copy link
        Member

        /openapibot sdkautomation

        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        1 similar comment
        @azure-pipelines
        Copy link

        Azure Pipelines successfully started running 1 pipeline(s).

        @allenjzhang allenjzhang merged commit 8ed021e into Azure:master Feb 3, 2020
        @angosms angosms mentioned this pull request Feb 18, 2020
        Merged
        5 tasks
        ssripadham pushed a commit to ssripadham/azure-rest-api-specs that referenced this pull request Feb 21, 2020
        @angosms @ssripadham
        Angos/msi extensionresource (Azure#7528)
        f70c4c4 
        * Add extension resource operation to swagger

* Add change to preview version

* Correct API

* Remove lists references.

* Clean up errors.

* Clean up linting errors.

* Add examples

* Add content to files

* Fix examples and path

* Fix param

* Format examples

* Run prettier

* Address comments.

* Fix model.

* Make location a required field

* Address lint error

* Remove resourceName from scope

* Use a common resource definition

* Run prettier

* Fix errors

* Remove tags from systemassignedidentity response

* Fix description.

* Remove tags from response

* Add error suppression

* Change array formatting
        00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
        @angosms @00Kai0
        Angos/msi extensionresource (Azure#7528)
        239fc7b 
        * Add extension resource operation to swagger

* Add change to preview version

* Correct API

* Remove lists references.

* Clean up errors.

* Clean up linting errors.

* Add examples

* Add content to files

* Fix examples and path

* Fix param

* Format examples

* Run prettier

* Address comments.

* Fix model.

* Make location a required field

* Address lint error

* Remove resourceName from scope

* Use a common resource definition

* Run prettier

* Fix errors

* Remove tags from systemassignedidentity response

* Fix description.

* Remove tags from response

* Add error suppression

* Change array formatting
        Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
        Reviewers

        @rikotcho rikotcho rikotcho left review comments

        @KrisBash KrisBash KrisBash approved these changes

        @anuchandy anuchandy Awaiting requested review from anuchandy

        Assignees

        @anuchandy anuchandy

        Labels
        ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
        Projects
        None yet
        Milestone
        No milestone
        Development

        Successfully merging this pull request may close these issues.
        10 participants
        @angosms @AutorestCI @azuresdkci @anuchandy @pilor @PhoenixHe-NV @allenjzhang @KrisBash @rikotcho @markcowl