Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosmos DB Private Endpoint Connection Swagger #7563

Merged
merged 10 commits into from
Oct 29, 2019
Merged

Cosmos DB Private Endpoint Connection Swagger #7563

merged 10 commits into from
Oct 29, 2019

Conversation

ayanMSFT
Copy link
Contributor

@ayanMSFT ayanMSFT commented Oct 21, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@ayanMSFT ayanMSFT added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 21, 2019
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 21, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 73991d7, Iteration 10)

Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
Succeeded Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Warning JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • Warning @azure/arm-cosmosdb [Logs]

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azuresdkci azuresdkci requested a review from zikalino October 21, 2019 19:33
@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Oct 21, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Oct 21, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Oct 23, 2019
Merged
@anthony-c-martin anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 28, 2019
@zikalino zikalino merged commit 638c868 into Azure:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-c-martin anthony-c-martin anthony-c-martin approved these changes

@zikalino zikalino zikalino approved these changes

Assignees

@zikalino zikalino

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ayanMSFT @azuresdkci @AutorestCI @zikalino @anthony-c-martin