Add PGSQL to AzurePGSQL swagger changes #7583

ash1625 · 2019-10-22T18:06:05Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-10-22T18:06:08Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 6ef8f3f with merge commit f1e9e42. SDK Automation 13.0.17.20191226.1
️✔️sdk/datamigration/mgmt-v2017_11_15_preview [Logs] [Release SDK Changes]
️✔️sdk/datamigration/mgmt-v2018_03_31_preview [Logs] [Release SDK Changes]

⚠️sdk/datamigration/mgmt-v2018_07_15_preview [Logs] [Release SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/datamigration/mgmt-v2018_07_15_preview/src/main/java/com/microsoft/azure/management/datamigration/v2018_07_15_preview/implementation/CommandPropertiesInner.java:[26,82] cannot find symbol
[mvn]   symbol: class MigrateMISyncCompleteCommandProperties
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/datamigration/mgmt-v2018_07_15_preview/src/main/java/com/microsoft/azure/management/datamigration/v2018_07_15_preview/implementation/CommandPropertiesInner.java:[27,73] cannot find symbol
[mvn]   symbol: class MigrateSyncCompleteCommandProperties
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/datamigration/mgmt-v2018_07_15_preview/src/main/java/com/microsoft/azure/management/datamigration/v2018_07_15_preview/implementation/CommandPropertiesInner.java:[28,49] cannot find symbol
[mvn]   symbol: class MongoDbCancelCommand
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/datamigration/mgmt-v2018_07_15_preview/src/main/java/com/microsoft/azure/management/datamigration/v2018_07_15_preview/implementation/CommandPropertiesInner.java:[29,49] cannot find symbol
[mvn]   symbol: class MongoDbFinishCommand
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/datamigration/mgmt-v2018_07_15_preview/src/main/java/com/microsoft/azure/management/datamigration/v2018_07_15_preview/implementation/CommandPropertiesInner.java:[30,50] cannot find symbol
[mvn]   symbol: class MongoDbRestartCommand
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-datamigration: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/datamigration/mgmt-v2018_07_15_preview/src/main/java/com/microsoft/azure/management/datamigration/v2018_07_15_preview/implementation/CommandPropertiesInner.java:[26,82] cannot find symbol
[mvn] [ERROR]   symbol: class MigrateMISyncCompleteCommandProperties
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/datamigration/mgmt-v2018_07_15_preview/src/main/java/com/microsoft/azure/management/datamigration/v2018_07_15_preview/implementation/CommandPropertiesInner.java:[27,73] cannot find symbol
[mvn] [ERROR]   symbol: class MigrateSyncCompleteCommandProperties
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/datamigration/mgmt-v2018_07_15_preview/src/main/java/com/microsoft/azure/management/datamigration/v2018_07_15_preview/implementation/CommandPropertiesInner.java:[28,49] cannot find symbol
[mvn] [ERROR]   symbol: class MongoDbCancelCommand
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/datamigration/mgmt-v2018_07_15_preview/src/main/java/com/microsoft/azure/management/datamigration/v2018_07_15_preview/implementation/CommandPropertiesInner.java:[29,49] cannot find symbol
[mvn] [ERROR]   symbol: class MongoDbFinishCommand
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/datamigration/mgmt-v2018_07_15_preview/src/main/java/com/microsoft/azure/management/datamigration/v2018_07_15_preview/implementation/CommandPropertiesInner.java:[30,50] cannot find symbol
[mvn] [ERROR]   symbol: class MongoDbRestartCommand
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

azuresdkci · 2019-10-22T18:07:29Z

Can one of the admins verify this patch?

AutorestCI · 2019-10-22T18:09:43Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#6113

raych1 · 2019-10-23T08:57:31Z

...n/resource-manager/Microsoft.DataMigration/preview/2018-07-15-preview/definitions/Tasks.json

@@ -635,7 +635,7 @@
      ]
    },
    "MigratePostgreSqlAzureDbForPostgreSqlSyncTaskProperties": {
-      "x-ms-discriminator-value": "Migrate.PostgreSql.AzureDbForPostgreSql.Sync",
+      "x-ms-discriminator-value": "Migrate.PostgreSql.AzureDbForPostgreSql.SyncV2",


Will this child type change cause breaking change?

We are making the back-end backward compatible. Same inputs and outputs will continue to work with the 'v2' type task.

raych1 · 2019-10-29T05:18:44Z

@hitenjava , please review on the swagger spec change. @ash1625 , can you resolve the comment and fix the spell check failures?

hitenjava

Approved, but this should be merge once we are close to releasing the changes.

majastrz

Signed off from ARM side.

temandr · 2020-01-14T07:23:44Z

@raych1 Do you know why the sdk-automation failed to build the python sdk? There doesn't seem to be a PR made and the attached sdk doesn't correspond to the change.

raych1 · 2020-01-14T07:53:24Z

/azp run automation - sdk

azure-pipelines · 2020-01-14T07:53:34Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-01-14T08:09:17Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 6ef8f3f with merge commit f1e9e42. SDK Automation 13.0.17.20191226.1
⚠️datamigration/mgmt/2018-04-19 [Logs]
```
No file is changed.
```
⚠️preview/datamigration/mgmt/2017-11-15-preview [Logs]
```
No file is changed.
```
⚠️preview/datamigration/mgmt/2018-03-31-preview [Logs]
```
No file is changed.
```
️✔️preview/datamigration/mgmt/2018-07-15-preview [Logs] [Release SDK Changes]
- preview.datamigration.mgmt.2018-07-15-preview.zip

openapi-sdkautomation · 2020-01-14T08:10:13Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 6ef8f3f with merge commit f1e9e42. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.DataMigration [Logs] [Release SDK Changes]
- Microsoft.Azure.Management.DataMigration.0.10.0-preview.nupkg
- Microsoft.Azure.Management.DataMigration.0.10.0-preview.snupkg

openapi-sdkautomation · 2020-01-14T08:10:17Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 6ef8f3f with merge commit f1e9e42. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-datamigration [Logs] [Release SDK Changes]

azure-arm-datamigration-2.0.0.tgz

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/dataMigrationServiceClient.js → ./dist/arm-datamigration.js...
[npmPack] created ./dist/arm-datamigration.js in 779ms

openapi-sdkautomation · 2020-01-14T08:10:19Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 6ef8f3f with merge commit f1e9e42. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-datamigration [Logs] [Release SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

temandr · 2020-01-31T18:16:32Z

/azp run automation - sdk

azure-pipelines · 2020-01-31T18:16:42Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-31T18:24:16Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-31T18:54:43Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-31T19:01:10Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-31T19:18:19Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-31T19:31:35Z

Azure Pipelines successfully started running 1 pipeline(s).

temandr · 2020-01-31T19:47:46Z

@raych1 this is ready to be merged.

raych1 · 2020-02-02T03:49:40Z

@temandr , can you please follow https://aka.ms/AA6h31t to fix the PrettierCheck issue?

azure-pipelines · 2020-02-05T17:20:59Z

No commit pushedDate could be found for PR 7583 in repo Azure/azure-rest-api-specs

temandr · 2020-02-05T19:32:14Z

/azp run automation - sdk

azure-pipelines · 2020-02-05T19:32:24Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-06T01:53:29Z

Azure Pipelines successfully started running 1 pipeline(s).

temandr · 2020-02-07T01:37:42Z

It looks like I'm not authorized to merge this request. Can someone with the needed permissions merge this change?

majastrz · 2020-02-07T02:00:50Z

@raych1 should have permissions to merge the PR. ARM API reviewers unfortunately don't have those permissions.

* Add PGSQL to AzurePGSQL swagger changes * Add trust and encrypt connections flags to the PG scenario * Renamed postgree to postgres and configured and changed text * Adding custom words * Resolving discriminator issues * Fixing typo * Renamed 'ResultType' to 'resultType' * Made result task not read only * prettier run

Add PGSQL to AzurePGSQL swagger changes

5fb9c77

ash1625 requested a review from hitenjava as a code owner October 22, 2019 18:06

azuresdkci assigned raych1 Oct 22, 2019

azuresdkci requested a review from raych1 October 22, 2019 18:07

AutorestCI mentioned this pull request Oct 22, 2019

[AutoPR datamigration/resource-manager] Add PGSQL to AzurePGSQL swagger changes Azure/azure-sdk-for-go#6113

Closed

raych1 reviewed Oct 23, 2019

View reviewed changes

hitenjava changed the title ~~Add PGSQL to AzurePGSQL swagger changes~~ [Do not merge] Add PGSQL to AzurePGSQL swagger changes Nov 6, 2019

hitenjava approved these changes Nov 6, 2019

View reviewed changes

raych1 added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Nov 6, 2019

majastrz added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 6, 2019

majastrz approved these changes Nov 6, 2019

View reviewed changes

Adding custom words

1bf6d6e

Resolving discriminator issues

e81b49e

Fixing typo

1047dae

Renamed 'ResultType' to 'resultType'

961b270

Made result task not read only

b573819

Artem Pavlichenko added 2 commits February 5, 2020 09:11

Merge remote-tracking branch 'upstream/master'

8439937

prettier run

6ef8f3f

raych1 approved these changes Feb 6, 2020

View reviewed changes

raych1 changed the title ~~[Do not merge] Add PGSQL to AzurePGSQL swagger changes~~ Add PGSQL to AzurePGSQL swagger changes Feb 6, 2020

raych1 removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Feb 6, 2020

raych1 merged commit f1e9e42 into Azure:master Feb 7, 2020

temandr mentioned this pull request Feb 10, 2021

[Hub Generated] Review request for Microsoft.DataMigration to add version preview/2018-07-15-preview #12917

Closed

25 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add PGSQL to AzurePGSQL swagger changes #7583

Add PGSQL to AzurePGSQL swagger changes #7583

ash1625 commented Oct 22, 2019

openapi-sdkautomation bot commented Oct 22, 2019 •

edited

Loading

azuresdkci commented Oct 22, 2019

AutorestCI commented Oct 22, 2019 •

edited

Loading

raych1 Oct 23, 2019

hitenjava Nov 6, 2019

raych1 commented Oct 29, 2019

hitenjava left a comment

majastrz left a comment

temandr commented Jan 14, 2020

raych1 commented Jan 14, 2020

azure-pipelines bot commented Jan 14, 2020

openapi-sdkautomation bot commented Jan 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 14, 2020 •

edited

Loading

temandr commented Jan 31, 2020

azure-pipelines bot commented Jan 31, 2020

azure-pipelines bot commented Jan 31, 2020

azure-pipelines bot commented Jan 31, 2020

azure-pipelines bot commented Jan 31, 2020

azure-pipelines bot commented Jan 31, 2020

azure-pipelines bot commented Jan 31, 2020

temandr commented Jan 31, 2020

raych1 commented Feb 2, 2020

azure-pipelines bot commented Feb 5, 2020

temandr commented Feb 5, 2020

azure-pipelines bot commented Feb 5, 2020

azure-pipelines bot commented Feb 6, 2020

temandr commented Feb 7, 2020

majastrz commented Feb 7, 2020

Add PGSQL to AzurePGSQL swagger changes #7583

Add PGSQL to AzurePGSQL swagger changes #7583

Conversation

ash1625 commented Oct 22, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Oct 22, 2019 • edited Loading

azure-sdk-for-java - Release

azuresdkci commented Oct 22, 2019

AutorestCI commented Oct 22, 2019 • edited Loading

Automation for azure-sdk-for-go

raych1 Oct 23, 2019

Choose a reason for hiding this comment

hitenjava Nov 6, 2019

Choose a reason for hiding this comment

raych1 commented Oct 29, 2019

hitenjava left a comment

Choose a reason for hiding this comment

majastrz left a comment

Choose a reason for hiding this comment

temandr commented Jan 14, 2020

raych1 commented Jan 14, 2020

azure-pipelines bot commented Jan 14, 2020

openapi-sdkautomation bot commented Jan 14, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Jan 14, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Jan 14, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Jan 14, 2020 • edited Loading

azure-sdk-for-python - Release

temandr commented Jan 31, 2020

azure-pipelines bot commented Jan 31, 2020

azure-pipelines bot commented Jan 31, 2020

azure-pipelines bot commented Jan 31, 2020

azure-pipelines bot commented Jan 31, 2020

azure-pipelines bot commented Jan 31, 2020

azure-pipelines bot commented Jan 31, 2020

temandr commented Jan 31, 2020

raych1 commented Feb 2, 2020

azure-pipelines bot commented Feb 5, 2020

temandr commented Feb 5, 2020

azure-pipelines bot commented Feb 5, 2020

azure-pipelines bot commented Feb 6, 2020

temandr commented Feb 7, 2020

majastrz commented Feb 7, 2020

openapi-sdkautomation bot commented Oct 22, 2019 •

edited

Loading

AutorestCI commented Oct 22, 2019 •

edited

Loading

openapi-sdkautomation bot commented Jan 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 14, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 14, 2020 •

edited

Loading