Assessment metadata API (Azure Security Center) #7622

eliagrady · 2019-10-24T12:47:06Z

Review summary:

Picked up from this PR:

added a "put" scenario and an example.
remove "secureScoreWeight" field
add "severity" field

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-10-24T12:47:11Z

azure-sdk-for-python - Release

⌛ Pending...

azuresdkci · 2019-10-24T12:47:28Z

Can one of the admins verify this patch?

AutorestCI · 2019-10-24T12:49:54Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#6454

...-01-01-preview/examples/AssessmentsMetadata/GetAssessmentsMetadata_subscription_example.json

.../preview/2019-01-01-preview/examples/AssessmentsMetadata/GetAssessmentsMetadata_example.json

...-01-preview/examples/AssessmentsMetadata/CreateAssessmentsMetadata_subscription_example.json

...preview/2019-01-01-preview/examples/AssessmentsMetadata/ListAssessmentsMetadata_example.json

...urity/resource-manager/Microsoft.Security/preview/2019-01-01-preview/assessmentMetadata.json

AutorestCI · 2019-10-31T13:21:22Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#8709

eliagrady · 2019-10-31T13:31:57Z

@yungezz I've tidied the PR - please review

chlahav · 2019-11-12T12:07:17Z

@yungezz can you please review?
we would really like to complete this PR

...urity/resource-manager/Microsoft.Security/preview/2019-01-01-preview/assessmentMetadata.json

ryansbenson · 2019-11-21T23:29:30Z

...urity/resource-manager/Microsoft.Security/preview/2019-01-01-preview/assessmentMetadata.json

+    }
+  },
+  "paths": {
+    "/providers/Microsoft.Security/assessmentMetadata": {


How are you handling RBAC of your tenant level API?

The tenant level API will be available for all to get the built in assessment metadata (similar to roleDefinitions or policyDefinitions)

ryansbenson · 2019-11-21T23:29:59Z

...urity/resource-manager/Microsoft.Security/preview/2019-01-01-preview/assessmentMetadata.json

+      }
+    },
+    "/providers/Microsoft.Security/assessmentMetadata/{assessmentMetadataName}": {
+      "get": {


Can these be created or only retrieved?

tenant level can only be retrieved (built ins)

...urity/resource-manager/Microsoft.Security/preview/2019-01-01-preview/assessmentMetadata.json

...-01-preview/examples/AssessmentsMetadata/CreateAssessmentsMetadata_subscription_example.json

ryansbenson · 2019-11-21T23:48:11Z

...urity/resource-manager/Microsoft.Security/preview/2019-01-01-preview/assessmentMetadata.json

+    }
+  },
+  "paths": {
+    "/providers/Microsoft.Security/assessmentMetadata": {


assessmentMetadata doesn't really allude to what this is, as the term metadata doesn't really have any specific meaning. If I try to make sense of both your PRs, this is really the assessmentDefinitions?

I guess that it might be a better name, but since this API was already reviewed for most of its properties by ARM, approved with that name and publicly exposed in the manifest it will be a little problematic to change the name now :/
WDYT?

…data

KrisBash

ARM feedback appears to be addressed. Signing off

chlahav · 2019-12-03T20:18:43Z

@yungezz
can you please review this PR?

yungezz · 2019-12-04T02:05:44Z

hi @erich-wang could you pls review the PR since ARM signedofff?

openapi-sdkautomation · 2019-12-05T03:20:31Z

azure-sdk-for-go - Release

⌛ Pending...

openapi-sdkautomation · 2019-12-05T03:20:33Z

azure-sdk-for-js - Release

⌛ Pending...

openapi-sdkautomation · 2019-12-05T03:20:33Z

azure-sdk-for-net - Release

⌛ Pending...

openapi-sdkautomation · 2019-12-05T03:20:33Z

azure-sdk-for-java - Release

⌛ Pending...

* create assessmentMetadata.json * prettier fix * review fixes * add userImpact, implementationEffort, threat fields to assessmentMetadata * cleanup readme.md * Fix property name * prettier fixes * Property casing fix

eliagrady requested review from sergey-shandar, chlahav, praries880 and yungezz October 24, 2019 12:47

azuresdkci assigned erich-wang Oct 24, 2019

azuresdkci requested a review from erich-wang October 24, 2019 12:49

eliagrady added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 24, 2019

AutorestCI mentioned this pull request Oct 24, 2019

[AutoPR security/resource-manager] Assessment metadata API (Azure Security Center) Azure/azure-sdk-for-go#6147

Closed

chlahav approved these changes Oct 29, 2019

View reviewed changes

eliagrady force-pushed the master branch from 1a63a7a to 130ae11 Compare October 31, 2019 13:30

eliagrady removed request for sergey-shandar, erich-wang and praries880 October 31, 2019 13:31

eliagrady force-pushed the master branch from 130ae11 to a971800 Compare November 12, 2019 12:25

AutorestCI mentioned this pull request Nov 12, 2019

[AutoPR security/resource-manager] Assessment metadata API (Azure Security Center) Azure/azure-sdk-for-python#8592

Closed

eliagrady requested a review from chlahav November 13, 2019 14:30

chlahav approved these changes Nov 17, 2019

View reviewed changes

eliagrady added ARM-overdue ARM review has not occurred within the expected timeframe ARM-Review-Issue and removed ARM-Review-Issue labels Nov 20, 2019

ryansbenson reviewed Nov 21, 2019

View reviewed changes

ryansbenson added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Nov 21, 2019

ryansbenson reviewed Nov 21, 2019

View reviewed changes

AutorestCI mentioned this pull request Nov 24, 2019

[AutoPR security/resource-manager] Assessment metadata API (Azure Security Center) Azure/azure-sdk-for-python#8831

Closed

chlahav force-pushed the master branch 2 times, most recently from 9f724b4 to 00eab4b Compare November 24, 2019 23:30

tarosler and others added 4 commits December 1, 2019 11:25

create assessmentMetadata.json

4cbdaf8

prettier fix

04f06cc

review fixes

c097b7d

add userImpact, implementationEffort, threat fields to assessmentMeta…

8e41558

…data

eliagrady force-pushed the master branch from 00eab4b to 8e41558 Compare December 1, 2019 09:32

cleanup readme.md

01872a1

AutorestCI mentioned this pull request Dec 1, 2019

[AutoPR security/resource-manager] Assessment metadata API (Azure Security Center) Azure/azure-sdk-for-go#6456

Closed

Fix property name

45b94bf

chlahav force-pushed the master branch from df00bcc to 45b94bf Compare December 2, 2019 22:56

Chen Lahav added 2 commits December 3, 2019 00:59

prettier fixes

09a96f7

Property casing fix

0a6667f

KrisBash approved these changes Dec 3, 2019

View reviewed changes

erich-wang merged commit 32f47b5 into Azure:master Dec 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Assessment metadata API (Azure Security Center) #7622

Assessment metadata API (Azure Security Center) #7622

eliagrady commented Oct 24, 2019 •

edited

Loading

openapi-sdkautomation bot commented Oct 24, 2019 •

edited

Loading

azuresdkci commented Oct 24, 2019

AutorestCI commented Oct 24, 2019 •

edited

Loading

AutorestCI commented Oct 31, 2019 •

edited

Loading

eliagrady commented Oct 31, 2019

chlahav commented Nov 12, 2019

ryansbenson Nov 21, 2019

chlahav Nov 24, 2019

ryansbenson Nov 21, 2019

chlahav Nov 24, 2019

ryansbenson Nov 21, 2019

chlahav Nov 24, 2019

KrisBash left a comment

chlahav commented Dec 3, 2019

yungezz commented Dec 4, 2019

openapi-sdkautomation bot commented Dec 5, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 5, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 5, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 5, 2019 •

edited

Loading

Assessment metadata API (Azure Security Center) #7622

Assessment metadata API (Azure Security Center) #7622

Conversation

eliagrady commented Oct 24, 2019 • edited Loading

Review summary:

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Oct 24, 2019 • edited Loading

azure-sdk-for-python - Release

azuresdkci commented Oct 24, 2019

AutorestCI commented Oct 24, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Oct 31, 2019 • edited Loading

Automation for azure-sdk-for-python

eliagrady commented Oct 31, 2019

chlahav commented Nov 12, 2019

ryansbenson Nov 21, 2019

Choose a reason for hiding this comment

chlahav Nov 24, 2019

Choose a reason for hiding this comment

ryansbenson Nov 21, 2019

Choose a reason for hiding this comment

chlahav Nov 24, 2019

Choose a reason for hiding this comment

ryansbenson Nov 21, 2019

Choose a reason for hiding this comment

chlahav Nov 24, 2019

Choose a reason for hiding this comment

KrisBash left a comment

Choose a reason for hiding this comment

chlahav commented Dec 3, 2019

yungezz commented Dec 4, 2019

openapi-sdkautomation bot commented Dec 5, 2019 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Dec 5, 2019 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Dec 5, 2019 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Dec 5, 2019 • edited Loading

azure-sdk-for-java - Release

eliagrady commented Oct 24, 2019 •

edited

Loading

openapi-sdkautomation bot commented Oct 24, 2019 •

edited

Loading

AutorestCI commented Oct 24, 2019 •

edited

Loading

AutorestCI commented Oct 31, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 5, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 5, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 5, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 5, 2019 •

edited

Loading