Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev containerservice microsoft.container service 2019 11 01 #7817

Conversation

gtracer
Copy link
Contributor

@gtracer gtracer commented Nov 20, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@gtracer gtracer added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 20, 2019
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Nov 20, 2019

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Nov 20, 2019

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#6397

@ryansbenson ryansbenson added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 20, 2019
Copy link
Contributor

@ryansbenson ryansbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed off from ARMs side

@robbiezhang
Copy link

LGTM

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@zikalino zikalino merged commit 08c206f into Azure:dev-containerservice-Microsoft.ContainerService-2019-11-01 Dec 10, 2019
erich-wang pushed a commit that referenced this pull request Dec 12, 2019
* Adds base for updating Microsoft.ContainerService from version stable/2019-10-01 to version 2019-11-01

* Updates readme

* Updates API version in new specs and examples

* Dev containerservice microsoft.container service 2019 11 01 (#7817)

* Feat: add allocatedPorts and idleTimeoutInMinutes to model and examples

* Feat: add outboundType to spec and examples

* fix camelcase typo

* fix idletimeout and allocatedPorts nesting

* add outboundtype to get mc example

* update description indenting

* update indenting of example

* update to string

* narrow down problem example

* remove allocated ports from update example

* remove from all examples

* update naming to allocatedOutboundPorts

* add back single example

* add additional examples

* add final example back

* initial agent pool tag and label api model additions

* Add identity to addonprofile

* agent pool tag and label examples

* remove PREVIEW from zones and agentpool type description

* fix invalid json for identity

* update readme

* Add identityProfile

* fix invalid json

* apply npm prettier-fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants