-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev containerservice microsoft.container service 2019 11 01 #7817
Merged
zikalino
merged 27 commits into
Azure:dev-containerservice-Microsoft.ContainerService-2019-11-01
from
gtracer:dev-containerservice-Microsoft.ContainerService-2019-11-01
Dec 10, 2019
Merged
Dev containerservice microsoft.container service 2019 11 01 #7817
zikalino
merged 27 commits into
Azure:dev-containerservice-Microsoft.ContainerService-2019-11-01
from
gtracer:dev-containerservice-Microsoft.ContainerService-2019-11-01
Dec 10, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtracer
added
the
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
label
Nov 20, 2019
Can one of the admins verify this patch? |
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
Automation for azure-sdk-for-goA PR has been created for you: |
ryansbenson
reviewed
Nov 20, 2019
...erservice/resource-manager/Microsoft.ContainerService/stable/2019-11-01/managedClusters.json
Outdated
Show resolved
Hide resolved
ryansbenson
added
ARMChangesRequested
<valid label in PR review process>add this label when require changes after ARM review
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
and removed
ARMChangesRequested
<valid label in PR review process>add this label when require changes after ARM review
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
labels
Nov 20, 2019
ryansbenson
approved these changes
Nov 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed off from ARMs side
LGTM |
Aks 1101 agentpool tags labels
Add identity to addonprofile
Add identityProfile
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
robbiezhang
approved these changes
Dec 4, 2019
zikalino
approved these changes
Dec 10, 2019
zikalino
merged commit Dec 10, 2019
08c206f
into
Azure:dev-containerservice-Microsoft.ContainerService-2019-11-01
erich-wang
pushed a commit
that referenced
this pull request
Dec 12, 2019
* Adds base for updating Microsoft.ContainerService from version stable/2019-10-01 to version 2019-11-01 * Updates readme * Updates API version in new specs and examples * Dev containerservice microsoft.container service 2019 11 01 (#7817) * Feat: add allocatedPorts and idleTimeoutInMinutes to model and examples * Feat: add outboundType to spec and examples * fix camelcase typo * fix idletimeout and allocatedPorts nesting * add outboundtype to get mc example * update description indenting * update indenting of example * update to string * narrow down problem example * remove allocated ports from update example * remove from all examples * update naming to allocatedOutboundPorts * add back single example * add additional examples * add final example back * initial agent pool tag and label api model additions * Add identity to addonprofile * agent pool tag and label examples * remove PREVIEW from zones and agentpool type description * fix invalid json for identity * update readme * Add identityProfile * fix invalid json * apply npm prettier-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.