Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude malformed swagger file #7890

Closed

Conversation

ArcturusZhang
Copy link
Member

@ArcturusZhang ArcturusZhang commented Dec 4, 2019

I have to exclude this file from readme, because this swagger is malformed and causes problems in go SDK.

To be specific, it has a "discriminator" on line 450, and the discriminator-value on line 484 and line 500 collide with each other, causing ambiguity by saying there are two different models but both have value of LogicApp

@AutorestCI
Copy link

AutorestCI commented Dec 4, 2019

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 5ad9106c20d6074a697f955084ed1fe6949c07d8
  stderr: 'fatal: reference is not a tree: 5ad9106c20d6074a697f955084ed1fe6949c07d8'

@AutorestCI
Copy link

AutorestCI commented Dec 4, 2019

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#6454

@PhoenixHe-NV
Copy link
Contributor

/openapi sdkautomation

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 4, 2019

azure-sdk-for-java

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 4, 2019

azure-sdk-for-go

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 4, 2019

azure-sdk-for-python

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from ebaf236 with merge commit ad0675239dbfb9847705698082c016972bfe57da. SDK Automation 13.0.17
  • ️✔️azure-mgmt-security [Logs]  [Preview SDK Changes]
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] warning: no files found matching '*.py' under directory 'tests'
    [build_package] warning: no files found matching '*.yaml' under directory 'tests'

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 4, 2019

azure-sdk-for-net

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 4, 2019

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from ebaf236 with merge commit ad0675239dbfb9847705698082c016972bfe57da. SDK Automation 13.0.17
  • ️✔️@azure/arm-security [Logs]  [Preview SDK Changes]
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/securityCenter.js → ./dist/arm-security.js...
    [npmPack] created ./dist/arm-security.js in 822ms

@PhoenixHe-NV
Copy link
Contributor

/openapi sdkautomation

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

2 similar comments
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@akning-ms
Copy link
Contributor

@ArcturusZhang Does this change have affect for other SDK?

@mikreite
Copy link
Contributor

mikreite commented Dec 4, 2019

After elaborating with my colleagues, we cannot just remove the automations.json from all tags.
A new PR has been created that should fix the issue:
#7895

@ArcturusZhang
Copy link
Member Author

In honor of #7895 , closing this pr.

@mikreite just FYI, the most recent go SDK major version release will rule out this swagger file.

@ArcturusZhang ArcturusZhang deleted the exclude-automation-swagger branch December 5, 2019 02:40
@mikreite
Copy link
Contributor

mikreite commented Dec 5, 2019

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants