Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iotcentral.json #7896

Merged
merged 5 commits into from
Dec 7, 2019
Merged

Conversation

poanchen
Copy link
Member

@poanchen poanchen commented Dec 4, 2019

Adding the new sku name ST0/ST1/ST2

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

added the new sku name ST0/ST1/ST2
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AutorestCI
Copy link

AutorestCI commented Dec 4, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#9047

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 4, 2019

azure-sdk-for-java - Release

Pending...

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 4, 2019

azure-sdk-for-go - Release

Pending...

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 4, 2019

azure-sdk-for-js - Release

Pending...

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 4, 2019

azure-sdk-for-net - Release

Pending...

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 4, 2019

azure-sdk-for-python - Release

Pending...

@poanchen
Copy link
Member Author

poanchen commented Dec 4, 2019

Looks like the failure of azure-sdk-for-net and azure-sdk-for-python (saw some other PR had similar issue) is a CI issue and seems to be unrelated to my changes.

@poanchen
Copy link
Member Author

poanchen commented Dec 5, 2019

My team member @r-delgadillo did talk to ARM team about this change and they agreed that this is not a breaking change. FYI.

@poanchen
Copy link
Member Author

poanchen commented Dec 5, 2019

Thanks for approving this @zikalino. Looks like I am not authorized to merge this pull request. Do you think you can help with that?

Keep the fork in sync
make sure poanchen-new-sku-name is sync
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@poanchen
Copy link
Member Author

poanchen commented Dec 6, 2019

@zikalino when can we expect this PR to be merged?

@poanchen
Copy link
Member Author

poanchen commented Dec 6, 2019

@AutorestCI rebuild

@poanchen
Copy link
Member Author

poanchen commented Dec 6, 2019

/azp run public.rest-api-specs

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zikalino
Copy link

zikalino commented Dec 7, 2019

.net sdk automation is failing but it seems unrelated at all

@zikalino zikalino merged commit a6f41b5 into Azure:master Dec 7, 2019
@poanchen poanchen deleted the poanchen-new-sku-name branch December 7, 2019 01:34
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019
* Update iotcentral.json

added the new sku name ST0/ST1/ST2

* Update Apps_CheckSubdomainAvailability.json

* made the model vaildation pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants