Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.AAD/DomainService: Add 2020-01-01 api-version #7900

Closed
wants to merge 4 commits into from
Closed

Microsoft.AAD/DomainService: Add 2020-01-01 api-version #7900

wants to merge 4 commits into from

Conversation

jihochang
Copy link
Contributor

@jihochang jihochang commented Dec 5, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AutorestCI
Copy link

AutorestCI commented Dec 5, 2019

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 2bec7f89ac2e13905fa87a76fd72d6dd62dba8d5
  stderr: 'fatal: reference is not a tree: 2bec7f89ac2e13905fa87a76fd72d6dd62dba8d5'

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

2 similar comments
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 5, 2019

azure-sdk-for-java

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Dec 5, 2019

azure-sdk-for-net

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 15fe7ac with merge commit 2bec7f89ac2e13905fa87a76fd72d6dd62dba8d5. SDK Automation 13.0.17
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.DomainServices [Logs]  [Preview SDK Changes]
      No Artifact Generated.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Dec 5, 2019

    azure-sdk-for-go

    failed [Logs] [Expand Details]
    • Generate from 15fe7ac with merge commit 2bec7f89ac2e13905fa87a76fd72d6dd62dba8d5. SDK Automation 13.0.17
    • domainservices/mgmt/2017-01-01 [Logs
        SDK Repository Package Error: Error: git push --set-upstream generation sdkAutomation/domainservices_mgmt_2017-01-01@7900 --force To https://github.com/Azure/azure-sdk-for-go
         ! [remote rejected]     sdkAutomation/domainservices_mgmt_2017-01-01@7900 -> sdkAutomation/domainservices_mgmt_2017-01-01@7900 (cannot lock ref 'refs/heads/sdkAutomation/domainservices_mgmt_2017-01-01@7900': reference already exists)
        error: failed to push some refs to 'https://x-access-token:v1.6ed0cdf3dc7662e8c0329c071540d4e6875cc0b1@github.com/Azure/azure-sdk-for-go'
        , {}
      • ⚠️domainservices/mgmt/2017-06-01 [Logs
          No file is changed.

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Dec 5, 2019

        azure-sdk-for-python

        No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Dec 5, 2019

        azure-sdk-for-js

        ️✔️ succeeded [Logs] [Expand Details]
        • ️✔️ Generate from 15fe7ac with merge commit 2bec7f89ac2e13905fa87a76fd72d6dd62dba8d5. SDK Automation 13.0.17
        • ️✔️@azure/arm-domainservices [Logs]  [Preview SDK Changes]
          [npmPack] loaded rollup.config.js with warnings
          [npmPack] (!) Unused external imports
          [npmPack] default imported from external module 'rollup' but never used
          [npmPack] 
          [npmPack] ./esm/domainservicesManagementClient.js → ./dist/arm-domainservices.js...
          [npmPack] created ./dist/arm-domainservices.js in 199ms

        @jihochang
        Copy link
        Contributor Author

        how do I add the WaitForARMFeedback label?

        are the ignore tests okay to fail?

        @jihochang jihochang closed this Dec 5, 2019
        Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
        Labels
        None yet
        Projects
        None yet
        Development

        Successfully merging this pull request may close these issues.

        3 participants