Added Data Connectors Check Requirements to security insights #8020

orgadhadas · 2019-12-22T00:58:48Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-12-22T00:58:50Z

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask tih@microsoft.com (or NullMDR in github) for additional help.

msftclas · 2019-12-22T00:59:01Z

All CLA requirements met.

azuresdkci · 2019-12-22T01:31:14Z

Can one of the admins verify this patch?

t-haorga · 2019-12-22T23:14:56Z

Hi @fengzhou-msft , I accidentally opened this PR from my personal Github account. I am a MS employee working in Azure Sentinel group. Thanks!

fengzhou-msft · 2019-12-23T02:12:03Z

/azp run automation – sdk

azure-pipelines · 2019-12-23T02:12:08Z

No pipelines are associated with this pull request.

fengzhou-msft · 2019-12-23T02:15:33Z

@t-haorga please use your personal account which submitted this PR to sign CLA in the above comment.

fengzhou-msft · 2019-12-23T02:36:43Z

/openapi sdkautomation

azure-pipelines · 2019-12-23T02:36:55Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-23T02:36:59Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2019-12-23T02:38:52Z

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 803a75e with merge commit 2edf12a. SDK Automation 13.0.17.20191226.1
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2019-12-23T02:38:53Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 803a75e with merge commit 2edf12a. SDK Automation 13.0.17.20191226.1

Failed to find any changed packages. Please check the changed file list.
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/_configuration.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/_security_insights.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/_models_py3.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/_paged_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/models/_security_insights_enums.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_actions_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_alert_rule_templates_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_alert_rules_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_bookmark_relations_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_bookmarks_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_case_comments_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_case_relations_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_cases_aggregations_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_cases_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_comments_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_data_connectors_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_entities_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_entity_queries_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_office_consents_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_product_settings_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/operations/_security_insights_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt-securityinsight/azure/mgmt/securityinsight/version.py

openapi-sdkautomation · 2019-12-23T02:38:55Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 803a75e with merge commit 2edf12a. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.SecurityInsights [Logs] [Release SDK Changes]
No Artifact Generated.

openapi-sdkautomation · 2019-12-23T02:39:01Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2019-12-23T02:39:06Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 803a75e with merge commit 2edf12a. SDK Automation 13.0.17.20191226.1
️✔️preview/securityinsight/mgmt/2017-08-01-preview [Logs] [Release SDK Changes]
- preview.securityinsight.mgmt.2017-08-01-preview.zip

azure-pipelines · 2019-12-25T09:02:34Z

Commenter does not have sufficient privileges for PR 8020 in repo Azure/azure-rest-api-specs

t-haorga · 2019-12-25T11:28:06Z

@fengzhou-msft signed

t-haorga · 2020-01-01T09:40:17Z

@fengzhou-msft waiting for your approval

orgadhadas · 2020-01-02T09:07:23Z

I am adding some changes that we applied since I opened this PR. Please do not merge automatically yet but do review the PR. Thanks!

sanjaiganesh · 2020-01-06T23:30:24Z

...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json

+          "Check Data Connector Requirements"
+        ],
+        "description": "Get requirements state for a data connector type.",
+        "operationId": "DataConnectorRequirements_list",


DataConnectorRequirements_list [](start = 24, length = 30)

update

Can you please explain why?

it is a post operation.. _List is usually for collection.. probably rename the action name to '/listDataConnectorRequirements' ?

In reply to: 364130217 [](ancestors = 364130217)

sanjaiganesh · 2020-01-06T23:36:27Z

...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json

+      "type": "object",
+      "required": [
+        "kind"
+      ]


I suppose this is already being enforced at server level and even discriminator pattern may not work. hope that is the case.
otherwise, adding new required property is a breaking change.

I added these because a test wouldn't pass, there was an error saying a discriminator must be required.
It is enforced in the server level as well.
What do you mean by "even discriminator pattern may not work" ?

t-haorga · 2020-01-21T21:25:50Z

@fengzhou-msft Please merge

fengzhou-msft · 2020-01-22T02:44:00Z

/azp run

azure-pipelines · 2020-01-22T02:44:21Z

Azure Pipelines successfully started running 3 pipeline(s).

fengzhou-msft · 2020-01-22T04:29:13Z

...resource-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json

+      "x-ms-enum": {
+        "modelAsString": true,
+        "name": "DataConnectorAuthorizationType",
+        "values": [


SDK automation tests failed because the values in x-ms-enum do not match with enum values above.

Ok I fixed that now

fengzhou-msft · 2020-01-22T10:37:53Z

/azp run automation - sdk

azure-pipelines · 2020-01-22T10:38:13Z

Azure Pipelines successfully started running 1 pipeline(s).

t-haorga · 2020-01-22T16:08:16Z

/azp run automation - sdk

azure-pipelines · 2020-01-22T16:08:21Z

Commenter does not have sufficient privileges for PR 8020 in repo Azure/azure-rest-api-specs

t-haorga · 2020-01-22T16:08:48Z

@fengzhou-msft I think it should be fine now, but I couldn't run the tests myself

fengzhou-msft · 2020-01-22T16:12:32Z

/azp run automation - sdk

azure-pipelines · 2020-01-22T16:12:42Z

Azure Pipelines successfully started running 1 pipeline(s).

t-haorga · 2020-01-22T21:24:52Z

@fengzhou-msft I think this check might be stuck - it is still waiting for status report after a few hours.

fengzhou-msft · 2020-01-23T03:44:06Z

/azp run

azure-pipelines · 2020-01-23T03:44:25Z

Azure Pipelines successfully started running 3 pipeline(s).

t-haorga · 2020-01-23T08:24:38Z

@fengzhou-msft all tests passed, please merge. Thanks!

…8020)

added requirements check

d947714

azuresdkci assigned fengzhou-msft Dec 22, 2019

azuresdkci requested a review from fengzhou-msft December 22, 2019 01:11

t-haorga added 2 commits December 22, 2019 03:15

ran prettier check

fae5164

added required for discriminators, for semantic check to pass

eaed0c5

fengzhou-msft added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 22, 2019

openapi-sdkautomation bot mentioned this pull request Dec 23, 2019

[AutoPR Microsoft.Azure.Management.SecurityInsights] Added Data Connectors Check Requirements to security insights AzureSDKAutomation/azure-sdk-for-net#252

Closed

orgadhadas changed the title ~~Added Data Connectors Check Requirements to security insights~~ [Do Not Merge] Added Data Connectors Check Requirements to security insights Jan 2, 2020

updated api

d86d399

sanjaiganesh reviewed Jan 6, 2020

View reviewed changes

t-haorga added 2 commits January 21, 2020 22:54

changed tab to spaces

cd59e71

ran prettier

879a0e0

orgadhadas changed the title ~~[Do Not Merge] Added Data Connectors Check Requirements to security insights~~ Added Data Connectors Check Requirements to security insights Jan 21, 2020

fengzhou-msft reviewed Jan 22, 2020

View reviewed changes

t-haorga added 3 commits January 22, 2020 10:30

fixed enum

dffb6de

changed requires to missing

bc77d4d

updated examples`

dd09f0b

t-haorga added 3 commits January 22, 2020 14:46

fixed for tests

1608d84

changes

0db2d6b

ran prettier

cbcb88b

fixed enum

803a75e

fengzhou-msft approved these changes Jan 23, 2020

View reviewed changes

fengzhou-msft merged commit 2edf12a into Azure:master Jan 23, 2020

ssripadham pushed a commit to ssripadham/azure-rest-api-specs that referenced this pull request Feb 21, 2020

Added Data Connectors Check Requirements to security insights (Azure#…

07577b2

…8020)

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020

Added Data Connectors Check Requirements to security insights (Azure#…

aef585a

…8020)

Added Data Connectors Check Requirements to security insights #8020

Added Data Connectors Check Requirements to security insights #8020

Conversation

orgadhadas commented Dec 22, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Dec 22, 2019

msftclas commented Dec 22, 2019 • edited Loading

azuresdkci commented Dec 22, 2019

t-haorga commented Dec 22, 2019 • edited Loading

fengzhou-msft commented Dec 23, 2019

azure-pipelines bot commented Dec 23, 2019

fengzhou-msft commented Dec 23, 2019

fengzhou-msft commented Dec 23, 2019

azure-pipelines bot commented Dec 23, 2019

azure-pipelines bot commented Dec 23, 2019

openapi-sdkautomation bot commented Dec 23, 2019 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Dec 23, 2019 • edited Loading

azure-sdk-for-python - Release

openapi-sdkautomation bot commented Dec 23, 2019 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Dec 23, 2019 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Dec 23, 2019 • edited Loading

azure-sdk-for-go - Release

azure-pipelines bot commented Dec 25, 2019

t-haorga commented Dec 25, 2019

t-haorga commented Jan 1, 2020

orgadhadas commented Jan 2, 2020 • edited Loading

sanjaiganesh Jan 6, 2020

Choose a reason for hiding this comment

t-haorga Jan 8, 2020

Choose a reason for hiding this comment

sanjaiganesh Jan 16, 2020

Choose a reason for hiding this comment

sanjaiganesh Jan 6, 2020

Choose a reason for hiding this comment

t-haorga Jan 8, 2020

Choose a reason for hiding this comment

t-haorga commented Jan 21, 2020

fengzhou-msft commented Jan 22, 2020

azure-pipelines bot commented Jan 22, 2020

fengzhou-msft Jan 22, 2020

Choose a reason for hiding this comment

t-haorga Jan 22, 2020

Choose a reason for hiding this comment

fengzhou-msft commented Jan 22, 2020

azure-pipelines bot commented Jan 22, 2020

t-haorga commented Jan 22, 2020

azure-pipelines bot commented Jan 22, 2020

t-haorga commented Jan 22, 2020

fengzhou-msft commented Jan 22, 2020

azure-pipelines bot commented Jan 22, 2020

t-haorga commented Jan 22, 2020

fengzhou-msft commented Jan 23, 2020

azure-pipelines bot commented Jan 23, 2020

t-haorga commented Jan 23, 2020

orgadhadas commented Dec 22, 2019 •

edited

Loading

msftclas commented Dec 22, 2019 •

edited

Loading

t-haorga commented Dec 22, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 23, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 23, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 23, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 23, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 23, 2019 •

edited

Loading

orgadhadas commented Jan 2, 2020 •

edited

Loading