Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated keyvault readme #8261

Merged
merged 2 commits into from
Jan 31, 2020
Merged

updated keyvault readme #8261

merged 2 commits into from
Jan 31, 2020

Conversation

zikalino
Copy link

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 30, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 30, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 5d782b0 with merge commit 1840a38. SDK Automation 13.0.17.20191226.1
  • ⚠️sdk/keyvault/mgmt-v2015_06_01 [Logs]  [Release SDK Changes]
      [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8:jar (default-cli) on project azure-keyvault: MavenReportException: Error while creating archive: 
      [mvn] [ERROR] Exit code: 1 - /z/work/azure-sdk-for-java/sdk/keyvault/mgmt-v2015_06_01/src/main/java/com/microsoft/azure/management/keyvault/v2015_06_01/package-info.java:11: warning: a package-info.java file has already been seen for package com.microsoft.azure.management.keyvault.v2015_06_01
      [mvn] [ERROR] package com.microsoft.azure.management.keyvault.v2015_06_01;
      [mvn] [ERROR]                                                ^
      [mvn] [ERROR] javadoc: warning - Multiple sources of package comments found for package "com.microsoft.azure.management.keyvault.v2015_06_01"
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/keyvault/mgmt-v2015_06_01/src/main/java/com/microsoft/azure/management/keyvault/v20150601/Vaults.java:13: error: cannot access Vault
      [mvn] [ERROR] import com.microsoft.azure.management.keyvault.v20150601.models.Vault;
      [mvn] [ERROR]                                                                ^
      [mvn] [ERROR]   bad source file: /z/work/azure-sdk-for-java/sdk/keyvault/mgmt-v2015_06_01/src/main/java/com/microsoft/azure/management/keyvault/v20150601/models/Vault.java
      [mvn] [ERROR]     file does not contain class com.microsoft.azure.management.keyvault.v20150601.models.Vault
      [mvn] [ERROR]     Please remove or make sure it appears in the correct subdirectory of the sourcepath.
      [mvn] [ERROR] 
      [mvn] [ERROR] Command line was: /usr/lib/jvm/java-8-openjdk-amd64/jre/../bin/javadoc @options @packages
      [mvn] [ERROR] 
      [mvn] [ERROR] Refer to the generated Javadoc files in '/z/work/azure-sdk-for-java/sdk/keyvault/mgmt-v2015_06_01/target/apidocs' dir.
      [mvn] [ERROR] -> [Help 1]
      [mvn] [ERROR] 
      [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
      [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
      [mvn] [ERROR] 
      [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
      [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
    • ⚠️sdk/keyvault/mgmt-v2016_10_01 [Logs]  [Release SDK Changes]
        [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8:jar (default-cli) on project azure-keyvault: MavenReportException: Error while creating archive: 
        [mvn] [ERROR] Exit code: 1 - /z/work/azure-sdk-for-java/sdk/keyvault/mgmt-v2016_10_01/src/main/java/com/microsoft/azure/management/keyvault/v2016_10_01/package-info.java:11: warning: a package-info.java file has already been seen for package com.microsoft.azure.management.keyvault.v2016_10_01
        [mvn] [ERROR] package com.microsoft.azure.management.keyvault.v2016_10_01;
        [mvn] [ERROR]                                                ^
        [mvn] [ERROR] javadoc: warning - Multiple sources of package comments found for package "com.microsoft.azure.management.keyvault.v2016_10_01"
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/keyvault/mgmt-v2016_10_01/src/main/java/com/microsoft/azure/management/keyvault/v20161001/Operations.java:13: error: cannot access Operation
        [mvn] [ERROR] import com.microsoft.azure.management.keyvault.v20161001.models.Operation;
        [mvn] [ERROR]                                                                ^
        [mvn] [ERROR]   bad source file: /z/work/azure-sdk-for-java/sdk/keyvault/mgmt-v2016_10_01/src/main/java/com/microsoft/azure/management/keyvault/v20161001/models/Operation.java
        [mvn] [ERROR]     file does not contain class com.microsoft.azure.management.keyvault.v20161001.models.Operation
        [mvn] [ERROR]     Please remove or make sure it appears in the correct subdirectory of the sourcepath.
        [mvn] [ERROR] 
        [mvn] [ERROR] Command line was: /usr/lib/jvm/java-8-openjdk-amd64/jre/../bin/javadoc @options @packages
        [mvn] [ERROR] 
        [mvn] [ERROR] Refer to the generated Javadoc files in '/z/work/azure-sdk-for-java/sdk/keyvault/mgmt-v2016_10_01/target/apidocs' dir.
        [mvn] [ERROR] -> [Help 1]
        [mvn] [ERROR] 
        [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
        [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
        [mvn] [ERROR] 
        [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
        [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
      • ⚠️sdk/keyvault/mgmt-v2018_02_14_preview [Logs]  [Release SDK Changes]
          [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8:jar (default-cli) on project azure-keyvault: MavenReportException: Error while creating archive: 
          [mvn] [ERROR] Exit code: 1 - /z/work/azure-sdk-for-java/sdk/keyvault/mgmt-v2018_02_14_preview/src/main/java/com/microsoft/azure/management/keyvault/v20180214preview/Operations.java:13: error: cannot access Operation
          [mvn] [ERROR] import com.microsoft.azure.management.keyvault.v20180214preview.models.Operation;
          [mvn] [ERROR]                                                                       ^
          [mvn] [ERROR]   bad source file: /z/work/azure-sdk-for-java/sdk/keyvault/mgmt-v2018_02_14_preview/src/main/java/com/microsoft/azure/management/keyvault/v20180214preview/models/Operation.java
          [mvn] [ERROR]     file does not contain class com.microsoft.azure.management.keyvault.v20180214preview.models.Operation
          [mvn] [ERROR]     Please remove or make sure it appears in the correct subdirectory of the sourcepath.
          [mvn] [ERROR] 
          [mvn] [ERROR] Command line was: /usr/lib/jvm/java-8-openjdk-amd64/jre/../bin/javadoc @options @packages
          [mvn] [ERROR] 
          [mvn] [ERROR] Refer to the generated Javadoc files in '/z/work/azure-sdk-for-java/sdk/keyvault/mgmt-v2018_02_14_preview/target/apidocs' dir.
          [mvn] [ERROR] -> [Help 1]
          [mvn] [ERROR] 
          [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
          [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
          [mvn] [ERROR] 
          [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
          [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Jan 30, 2020

        azure-sdk-for-js - Release

        ️✔️ succeeded [Logs] [Expand Details]
        • ️✔️ Generate from 5d782b0 with merge commit 1840a38. SDK Automation 13.0.17.20191226.1
        • ️✔️@azure/arm-keyvault [Logs]  [Release SDK Changes]
          [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
          [npmPack] loaded rollup.config.js with warnings
          [npmPack] (!) Unused external imports
          [npmPack] default imported from external module 'rollup' but never used
          [npmPack] 
          [npmPack] ./esm/keyVaultManagementClient.js → ./dist/arm-keyvault.js...
          [npmPack] created ./dist/arm-keyvault.js in 331ms

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Jan 30, 2020

        azure-sdk-for-python - Release

        ️✔️ succeeded [Logs] [Expand Details]
        • ️✔️ Generate from 5d782b0 with merge commit 1840a38. SDK Automation 13.0.17.20191226.1
        • ️✔️azure-mgmt-keyvault [Logs]  [Release SDK Changes]
          [after_scripts|python] WARNING:__main__:Found too much API version: {'2016-10-01', '2015-11-01'} in label v2016_10_01
          [after_scripts|python] WARNING:__main__:Guessing you want 2016-10-01 based on label v2016_10_01
          [after_scripts|python] WARNING:__main__:Found too much API version: {'2015-11-01', '2018-02-14'} in label v2018_02_14
          [after_scripts|python] WARNING:__main__:Guessing you want 2018-02-14 based on label v2018_02_14
          [after_scripts|python] WARNING:__main__:Found too much API version: {'2015-11-01', '2019-09-01'} in label v2019_09_01
          [after_scripts|python] WARNING:__main__:Guessing you want 2019-09-01 based on label v2019_09_01
          [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
          [build_package]   warnings.warn(msg)
          [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
          [build_package]   warnings.warn(msg)

        @openapi-sdkautomation
        Copy link

        openapi-sdkautomation bot commented Jan 30, 2020

        azure-sdk-for-go - Release

        ⚠️ warning [Logs] [Expand Details]
        • ⚠️ Generate from 5d782b0 with merge commit 1840a38. SDK Automation 13.0.17.20191226.1
        • ⚠️keyvault/mgmt/2015-06-01 [Logs
            No file is changed.
          • ⚠️keyvault/mgmt/2016-10-01 [Logs
              No file is changed.
            • ⚠️keyvault/mgmt/2018-02-14 [Logs
                No file is changed.

              @PhoenixHe-NV
              Copy link
              Contributor

              /azp run automation - sdk

              @azure-pipelines
              Copy link

              Azure Pipelines successfully started running 1 pipeline(s).

              @azure-pipelines
              Copy link

              Azure Pipelines successfully started running 1 pipeline(s).

              @allenjzhang
              Copy link
              Member

              /azp run

              @azure-pipelines
              Copy link

              Azure Pipelines successfully started running 3 pipeline(s).

              @schaabs
              Copy link
              Member

              schaabs commented Jan 31, 2020

              cc: @heaths

              @@ -21,10 +21,21 @@ Generate all API versions currently shipped for this package

              ```yaml $(python) && $(multiapi)
              batch:
              - tag: package-2019-09
              Copy link
              Member

              Choose a reason for hiding this comment

              The reason will be displayed to describe this comment to others. Learn more.

              Changes look good, but I wonder if this is only stable, or preview as well? We're about to introduce a 2020-01-23 preview for control plane.

              Copy link
              Author

              Choose a reason for hiding this comment

              The reason will be displayed to describe this comment to others. Learn more.

              i got release request for this one specifically

              @zikalino zikalino merged commit 1840a38 into master Jan 31, 2020
              @heaths heaths deleted the update-python-readme-for-keyvault branch January 31, 2020 00:37
              ssripadham pushed a commit to ssripadham/azure-rest-api-specs that referenced this pull request Feb 21, 2020
              * updated keyvault readme
              
              * fixed mistake
              00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
              * updated keyvault readme
              
              * fixed mistake
              Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
              Labels
              None yet
              Projects
              None yet
              Development

              Successfully merging this pull request may close these issues.

              5 participants