[WaitForARMFeedback] Long Term Retention for Managed Instances #8266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You don't have permission to trigger SDK Automation. |
|
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
pixia
reviewed
Jan 30, 2020
...fication/sql/resource-manager/Microsoft.Sql/preview/2017-03-01-preview/managedDatabases.json
Outdated
Show resolved
Hide resolved
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xaliciayang
changed the title
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-python - Release
|
This was referenced Jan 31, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
allenjzhang
reviewed
Feb 10, 2020
| @@ -638,6 +639,13 @@ | |||
| "x-ms-mutability": [ | |||
| "create" | |||
| ] | |||
| }, | |||
There was a problem hiding this comment.
Is there a reason that 2019-06-01-preview version does not have this and LongTermRetentionManagedInstanceBackups.json?
There was a problem hiding this comment.
Added managedDatabases.json to 2019-06-01-preview as well. the Backups/Policies APIs are new and we are going to use 2018-06-01-preview for those.
managedDatabases LongTermRetentionManagedInstanceBackups ManagedInstanceLongTermRetentionPolicies as well as relevant examples, to 2018 and 2019
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run automation - sdk |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Code style issues has been found in PR. Please follow this link to fix the issues. Thanks! |
xaliciayang
changed the title
|
Azure Pipelines successfully started running 1 pipeline(s). |
allenjzhang
removed
the
DoNotMerge
|
Azure Pipelines successfully started running 1 pipeline(s). |
| "application/json" | ||
| ], | ||
| "paths": { | ||
| "/subscriptions/{subscriptionId}/providers/Microsoft.Sql/locations/{locationName}/longTermRetentionManagedInstances/{managedInstanceName}/longTermRetentionDatabases/{databaseName}/longTermRetentionManagedInstanceBackups/{backupName}": { |
There was a problem hiding this comment.
can these backups exist at both scopes - RG and subscription? can they be created at both these scopes? Why is the support needed for subscription scope? To use these, the caller will need /write /read permissions at the scope of a subscription which is more privileged than getting the permissions at a RG scope.
A regular database is created under an RG.
There was a problem hiding this comment.
Backups can exist with or without a RG.
In cases of LTR backups tied to dropped instances, the resource will not have an RG: subscriptions/$subscriptionId/providers/Microsoft.Sql/Locations/$location/longTermRetentionManagedInstances/$instanceName/longTermRetentionDatabases/$databaseName/longTermRetentionManagedInstanceBackups/$backupName.
However, backups belonging to live instances will contain a RG.
| "produces": [ | ||
| "application/json" | ||
| ], | ||
| "paths": { |
There was a problem hiding this comment.
WHat about the PUT api for this? how are these created?
There was a problem hiding this comment.
These are created through the currently existing backup infrastructure. Generally, full database backups are taken 1x/week and our workflow determines whether or not a full backup for a server/managed instance should be saved for long term retention.
There was a problem hiding this comment.
In other words, a user cannot "create" a new backup
ravbhatnagar
added
the
ARMChangesRequested
|
both the questions were addressed. Signing off from ARM side. |
ravbhatnagar
added
ARMSignedOff
xaliciayang
changed the title
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
…#8266) * update swagger to accomodate for new managed db create mode (ltr) * Adding example file for create managed db from ltr restore * remove unused example * undoing removal of completeRestore * adding back complete managed restore example * add examplee and swagger files for ltr backup/policies * update readme; add in 2018 manage databases diffs * remove create example from 2018 * add -preview to swagger files added to readme * removing empty body from delete backup examples * fix parameter name in exmple file * add 2018 example. fix version in 2017 example * ../../2018-06-01-preview/managedDatabases.json * removing example from 2018 * ran prettier on some example files * adding other files called out by prettier * update readme to include swagger files in v3/v2/v1 * Revert "update readme to include swagger files in v3/v2/v1" Removing files committed by prettier-fix This reverts commit db6d146. * reverted all unrelated files updated readme to include swagger files in v3/v2/v1 * update swagger after introducing new error handler * removing old versions of manageDatabase.json swagger from readme.md package composites (2018-06-01 version is referenced) * Adding updated swagger files for: managedDatabases LongTermRetentionManagedInstanceBackups ManagedInstanceLongTermRetentionPolicies as well as relevant examples, to 2018 and 2019 * add files after running prettier-fix; removing LTR backups/policies APIs from 2019 * updated readme to use 2019 version of managedDatabases.json * adding files fixed by prettier * prettierfix.diff on LTR MI example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.