Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Microsoft.Billing] Add tenantId property to product. #8269

Merged
merged 2 commits into from
Jan 31, 2020
Merged

[Microsoft.Billing] Add tenantId property to product. #8269

merged 2 commits into from
Jan 31, 2020

Conversation

wilcobmsft
Copy link
Member

@wilcobmsft wilcobmsft commented Jan 30, 2020 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wilcobmsft wilcobmsft changed the title [Microsoft.Billing] Add tenantId property to billingSubscription and product. [Microsoft.Billing] Add tenantId property to product. Jan 30, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 30, 2020 •
edited
Loading

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 881f67b with merge commit f5ebbcf. SDK Automation 13.0.17.20191226.1
  • ️✔️@azure/arm-billing [Logs]  [Release SDK Changes] 
    [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/billingManagementClient.js → ./dist/arm-billing.js...
[npmPack] created ./dist/arm-billing.js in 706ms

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 30, 2020 •
edited
Loading

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 881f67b with merge commit f5ebbcf. SDK Automation 13.0.17.20191226.1
  • ️✔️azure-mgmt-billing [Logs]  [Release SDK Changes] 
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 30, 2020 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 30, 2020 •
edited
Loading

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 881f67b with merge commit f5ebbcf. SDK Automation 13.0.17.20191226.1
  • ⚠️preview/billing/mgmt/2017-02-27-preview [Logs]  
      No file is changed.
    • ⚠️preview/billing/mgmt/2017-04-24-preview [Logs]  
        No file is changed.
      • ⚠️preview/billing/mgmt/2018-03-01-preview [Logs]  
          No file is changed.
        • ⚠️preview/billing/mgmt/2018-11-01-preview [Logs]  
            No file is changed.

          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          6 similar comments
          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @openapi-sdkautomation
          Copy link

          openapi-sdkautomation bot commented Jan 30, 2020 •
          edited
          Loading

          azure-sdk-for-java - Release

          ⚠️ warning [Logs] [Expand Details]
          • ⚠️ Generate from 881f67b with merge commit f5ebbcf. SDK Automation 13.0.17.20191226.1
          • ️✔️sdk/billing/mgmt-v2017_02_27_preview [Logs]  [Release SDK Changes]
          • ️✔️sdk/billing/mgmt-v2017_04_24_preview [Logs]  [Release SDK Changes]
          • ️✔️sdk/billing/mgmt-v2018_03_01_preview [Logs]  [Release SDK Changes]
          • ⚠️sdk/billing/mgmt-v2018_11_01_preview [Logs]  [Release SDK Changes] 
              [mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2018_11_01_preview/src/main/java/com/microsoft/azure/management/billing/v2018_11_01_preview/implementation/PriceSheetsInner.java:[130,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn]   reason: cannot infer type-variable(s) T,THeader
[mvn]     (actual and formal argument lists differ in length)
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-billing: Compilation failure
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2018_11_01_preview/src/main/java/com/microsoft/azure/management/billing/v2018_11_01_preview/implementation/PriceSheetsInner.java:[130,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
[mvn] [ERROR]     (actual and formal argument lists differ in length)
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
            • ⚠️sdk/billing/mgmt-v2019_10_01_preview [Logs]  [Release SDK Changes] 
                [mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[146,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn]   reason: cannot infer type-variable(s) T,THeader
[mvn]     (actual and formal argument lists differ in length)
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[303,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn]   reason: cannot infer type-variable(s) T,THeader
[mvn]     (actual and formal argument lists differ in length)
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-billing: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[146,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
[mvn] [ERROR]     (actual and formal argument lists differ in length)
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[303,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
[mvn] [ERROR]     (actual and formal argument lists differ in length)
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

              This was referenced Jan 30, 2020
              Closed
              Closed
              Closed
              Closed
              Closed
              This was referenced Jan 30, 2020
              Closed
              Closed
              Closed
              @allenjzhang allenjzhang merged commit f5ebbcf into Azure:master Jan 31, 2020
              ssripadham pushed a commit to ssripadham/azure-rest-api-specs that referenced this pull request Feb 21, 2020
              @wilcobmsft @ssripadham
              [Microsoft.Billing] Add tenantId property to product. (Azure#8269)
              6bdf900 
              * Add tenantId to product.

* fix
              00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
              @wilcobmsft @00Kai0
              [Microsoft.Billing] Add tenantId property to product. (Azure#8269)
              1e46ff6 
              * Add tenantId to product.

* fix
              Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
              Reviewers

              @allenjzhang allenjzhang allenjzhang approved these changes

              @asarkar84 asarkar84 asarkar84 approved these changes

              Assignees

              @allenjzhang allenjzhang

              Labels
              None yet
              Projects
              None yet
              Milestone
              No milestone
              Development

              Successfully merging this pull request may close these issues.
              3 participants
              @wilcobmsft @allenjzhang @asarkar84