Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add developer portal url #8279

Merged
merged 3 commits into from
Feb 3, 2020
Merged

add developer portal url #8279

merged 3 commits into from
Feb 3, 2020

Conversation

solankisamir
Copy link
Member

@solankisamir solankisamir commented Jan 31, 2020 •
edited
Loading

Latest improvements:

  • Add readonly property developerPortalUrl to the ApiManagement service resource.
  • Updated examples

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

4 similar comments
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 31, 2020 •
edited
Loading

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 31, 2020 •
edited
Loading

azure-sdk-for-net - Release

❌ failed [Logs] [Expand Details]
  • ❌ Generate from 3e09adb with merge commit f2fa2a8. SDK Automation 13.0.17.20191226.1 
    [AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
  • ❌Microsoft.Azure.Management.ApiManagement [Logs]  [Release SDK Changes] 
      Failed to create the package Microsoft.Azure.Management.ApiManagement.
Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=apimanagement /v:n /p:SkipTests=true , {}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jan 31, 2020 •
    edited
    Loading

    azure-sdk-for-js - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 3e09adb with merge commit f2fa2a8. SDK Automation 13.0.17.20191226.1
    • ️✔️@azure/arm-apimanagement [Logs]  [Release SDK Changes] 
      [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/apiManagementClient.js → ./dist/arm-apimanagement.js...
[npmPack] created ./dist/arm-apimanagement.js in 1.4s

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jan 31, 2020 •
    edited
    Loading

    azure-sdk-for-go - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 3e09adb with merge commit f2fa2a8. SDK Automation 13.0.17.20191226.1
    • ⚠️apimanagement/mgmt/2016-07-07 [Logs]  
        No file is changed.
      • ⚠️apimanagement/mgmt/2016-10-10 [Logs]  
          No file is changed.
        • ⚠️apimanagement/mgmt/2017-03-01 [Logs]  
            No file is changed.
          • ⚠️apimanagement/mgmt/2018-01-01 [Logs]  
              No file is changed.
            • ️✔️apimanagement/mgmt/2019-01-01 [Logs]  [Release SDK Changes]
            • ⚠️preview/apimanagement/mgmt/2018-06-01-preview [Logs]  
                No file is changed.

              @openapi-sdkautomation
              Copy link

              openapi-sdkautomation bot commented Jan 31, 2020 •
              edited
              Loading

              azure-sdk-for-python - Release

              ️✔️ succeeded [Logs] [Expand Details]
              • ️✔️ Generate from 3e09adb with merge commit f2fa2a8. SDK Automation 13.0.17.20191226.1
              • ️✔️azure-mgmt-apimanagement [Logs]  [Release SDK Changes] 
                [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'

              This was referenced Jan 31, 2020
              Closed
              Closed
              @azure-pipelines
              Copy link

              Azure Pipelines successfully started running 1 pipeline(s).

              @solankisamir solankisamir added API Management WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 31, 2020
              @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jan 31, 2020
              Closed
              @anthony-c-martin anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 1, 2020
              @azure-pipelines
              Copy link

              Azure Pipelines successfully started running 1 pipeline(s).

              @allenjzhang allenjzhang merged commit f2fa2a8 into Azure:master Feb 3, 2020
              @solankisamir solankisamir mentioned this pull request Feb 7, 2020
              Merged
              ssripadham pushed a commit to ssripadham/azure-rest-api-specs that referenced this pull request Feb 21, 2020
              @solankisamir @ssripadham
              add developer portal url (Azure#8279)
              eb6d6c9 
              * add developer portal url

* fix prettier issue

* remove personal email address
              00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
              @solankisamir @00Kai0
              add developer portal url (Azure#8279)
              7f46f44 
              * add developer portal url

* fix prettier issue

* remove personal email address
              Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
              Reviewers

              @anthony-c-martin anthony-c-martin anthony-c-martin approved these changes

              Assignees

              @allenjzhang allenjzhang

              Labels
              API Management ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
              Projects
              None yet
              Milestone
              No milestone
              Development

              Successfully merging this pull request may close these issues.
              3 participants
              @solankisamir @anthony-c-martin @allenjzhang