Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.Maps to add version preview/2020-02-01-preview #8287

Merged
merged 20 commits into from
Feb 6, 2020
Merged

[Hub Generated] Review request for Microsoft.Maps to add version preview/2020-02-01-preview #8287

merged 20 commits into from
Feb 6, 2020

Conversation

stack111
Copy link
Contributor

@stack111 stack111 commented Feb 3, 2020

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 3, 2020 •
edited
Loading

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 3, 2020 •
edited
Loading

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 3, 2020 •
edited
Loading

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 1a4bd6d with merge commit a20b17f. SDK Automation 13.0.17.20191226.1
  • ️✔️azure-mgmt-maps [Logs]  [Release SDK Changes] 
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.rst'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.rst'

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 3, 2020 •
edited
Loading

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 1a4bd6d with merge commit a20b17f. SDK Automation 13.0.17.20191226.1
  • ️✔️@azure/arm-maps [Logs]  [Release SDK Changes] 
    [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/mapsManagementClient.js → ./dist/arm-maps.js...
[npmPack] created ./dist/arm-maps.js in 269ms

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 3, 2020 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

This was referenced Feb 3, 2020
Closed
Closed
Closed
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ArcturusZhang
Copy link
Member

LGTM now.
I will approve once ARM signs off.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stack111
Copy link
Contributor Author

stack111 commented Feb 4, 2020

@pilor the only warnings left are:

R3027 - TrackedResourceListByResourceGroup
The tracked resource, 'PrivateAtlas', must have a list by resource group operation.(This rule does not apply for tenant level resources.)
  at specification/maps/resource-manager/Microsoft.Maps/preview/2020-02-01-preview/maps-management.json:752

R3028 - TrackedResourceListBySubscription
The tracked resource, 'PrivateAtlas', must have a list by subscriptions operation.
  at specification/maps/resource-manager/Microsoft.Maps/preview/2020-02-01-preview/maps-management.json:752

Does this make sense or should I suppress, because this is a nested resource?

@pilor
Copy link
Contributor

pilor commented Feb 4, 2020

@pilor the only warnings left are:

R3027 - TrackedResourceListByResourceGroup
The tracked resource, 'PrivateAtlas', must have a list by resource group operation.(This rule does not apply for tenant level resources.)
  at specification/maps/resource-manager/Microsoft.Maps/preview/2020-02-01-preview/maps-management.json:752

R3028 - TrackedResourceListBySubscription
The tracked resource, 'PrivateAtlas', must have a list by subscriptions operation.
  at specification/maps/resource-manager/Microsoft.Maps/preview/2020-02-01-preview/maps-management.json:752

Does this make sense or should I suppress, because this is a nested resource?

No, you don't need to support that for nested tracked resources. You can suppress

pilor
pilor approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@pilor pilor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor comments to fix but otherwise LGTM

@pilor pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 4, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ArcturusZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@ArcturusZhang ArcturusZhang merged commit a20b17f into Azure:master Feb 6, 2020
ssripadham pushed a commit to ssripadham/azure-rest-api-specs that referenced this pull request Feb 21, 2020
@ssripadham
[Hub Generated] Review request for Microsoft.Maps to add version prev…
4e961ba 
…iew/2020-02-01-preview (Azure#8287)

* Adds base for updating Microsoft.Maps from version stable/2018-05-01 to version 2020-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* add private atlas resource and examples

* fixing invalid format

* fixing build validation errors

* fixing style

* removing 202 from review feedback

* api version, inheritance, and feedback

* removing 404 from examples and fixing version

* fixing readme and remaining 404s

* fixing typo

* trying to fix missing input file

* fixing output directory

* adding tags to support docs preview

* fixing List Operations name and sample

* adding supressions and fix for operations

* fixing the schema

* removing isDataAction to fix

* supress nested tracked, and remove move
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
@00Kai0
[Hub Generated] Review request for Microsoft.Maps to add version prev…
7f692fe 
…iew/2020-02-01-preview (Azure#8287)

* Adds base for updating Microsoft.Maps from version stable/2018-05-01 to version 2020-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* add private atlas resource and examples

* fixing invalid format

* fixing build validation errors

* fixing style

* removing 202 from review feedback

* api version, inheritance, and feedback

* removing 404 from examples and fixing version

* fixing readme and remaining 404s

* fixing typo

* trying to fix missing input file

* fixing output directory

* adding tags to support docs preview

* fixing List Operations name and sample

* adding supressions and fix for operations

* fixing the schema

* removing isDataAction to fix

* supress nested tracked, and remove move
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@specialforest specialforest specialforest left review comments

@pilor pilor pilor approved these changes

@ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

Assignees

@ArcturusZhang ArcturusZhang

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stack111 @ArcturusZhang @pilor @specialforest