Add networkMode to AKS 20200201 API #8343

gossion · 2020-02-08T05:05:48Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2020-02-08T05:06:03Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-08T05:07:46Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-02-08T05:08:57Z

azure-sdk-for-python

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from c5154ef with merge commit 03ce49ceba5640509dbcb98debde3b3e78bfb069. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-containerservice [Logs] [Preview SDK Changes]

[after_scripts|python] WARNING:__main__:Found too much API version: {'2019-04-01', '2017-07-01'} in label v2017_07_01
[after_scripts|python] WARNING:__main__:Guessing you want 2017-07-01 based on label v2017_07_01
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

openapi-sdkautomation · 2020-02-08T05:09:00Z

azure-sdk-for-net

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from c5154ef with merge commit 03ce49ceba5640509dbcb98debde3b3e78bfb069. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.ContainerService [Logs] [Preview SDK Changes]
- Microsoft.Azure.Management.ContainerService.1.0.0.nupkg
- Microsoft.Azure.Management.ContainerService.1.0.0.snupkg

openapi-sdkautomation · 2020-02-08T05:09:00Z

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from c5154ef with merge commit 03ce49ceba5640509dbcb98debde3b3e78bfb069. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-containerservice [Logs] [Preview SDK Changes]

azure-arm-containerservice-10.0.0.tgz

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/containerServiceClient.js → ./dist/arm-containerservice.js...
[npmPack] created ./dist/arm-containerservice.js in 455ms

openapi-sdkautomation · 2020-02-08T05:09:00Z

azure-sdk-for-java

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from c5154ef with merge commit 03ce49ceba5640509dbcb98debde3b3e78bfb069. SDK Automation 13.0.17.20191226.1
️✔️sdk/containerservice/mgmt-v2019_06_01 [Logs] [Preview SDK Changes]
️✔️sdk/containerservice/mgmt-v2019_08_01 [Logs] [Preview SDK Changes]
️✔️sdk/containerservice/mgmt-v2019_10_01 [Logs] [Preview SDK Changes]
️✔️sdk/containerservice/mgmt-v2019_11_01 [Logs] [Preview SDK Changes]
️✔️sdk/containerservice/mgmt-v2020_01_01 [Logs] [Preview SDK Changes]
️✔️sdk/containerservice/mgmt-v2020_02_01 [Logs] [Preview SDK Changes]

openapi-sdkautomation · 2020-02-08T05:09:01Z

azure-sdk-for-go

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from c5154ef with merge commit 03ce49ceba5640509dbcb98debde3b3e78bfb069. SDK Automation 13.0.17.20191226.1
⚠️containerservice/mgmt/2017-07-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2017-08-31 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2017-09-30 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2018-03-31 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-02-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-04-30 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-06-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-08-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-10-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-11-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2020-01-01 [Logs]
```
No file is changed.
```
️✔️containerservice/mgmt/2020-02-01 [Logs] [Preview SDK Changes]
- containerservice.mgmt.2020-02-01.zip
⚠️preview/containerservice/mgmt/2018-08-01-preview [Logs]
```
No file is changed.
```
⚠️preview/containerservice/mgmt/2018-09-30-preview [Logs]
```
No file is changed.
```
⚠️preview/containerservice/mgmt/2019-09-30-preview [Logs]
```
No file is changed.
```

gossion · 2020-02-08T05:09:56Z

@gtxistxgao FYI

majastrz · 2020-02-11T22:29:49Z

...erservice/resource-manager/Microsoft.ContainerService/stable/2020-02-01/managedClusters.json

+        "networkMode": {
+          "type": "string",
+          "enum": [
+            "",


"" [](start = 12, length = 2)

What does empty string mean here?

@majastrz, this means that the networkMode is not set.

Can we use a non-empty value to represent that? Something like none or default or 'NotSet`?

Discussed over IM. The API is apparently already released, which violates the usual review workflow (swagger-first)

thank you, will follow that.

This is breaking C# generated code, see https://github.com/AzureSDKAutomation/azure-sdk-for-net/pull/418/files#diff-2f25f07072c1b2f687283e3233db4dc6R19

majastrz

Signed off from ARM side given that the API is already released. Going forward, you need to get the swagger reviewed first before implementing it in the backend. This way feedback can actually be incorporated into the design of the API.

palma21 · 2020-02-12T01:07:26Z

Thanks, that seems reasonable, we'll do that moving forward.

@ArcturusZhang let us know if anything else is needed before merging

ArcturusZhang · 2020-02-12T01:27:46Z

/azp run

azure-pipelines · 2020-02-12T01:28:04Z

Azure Pipelines successfully started running 3 pipeline(s).

ArcturusZhang · 2020-02-12T01:39:11Z

/azp run

azure-pipelines · 2020-02-12T01:39:29Z

Azure Pipelines successfully started running 3 pipeline(s).

ArcturusZhang · 2020-02-12T08:41:26Z

/azp run

azure-pipelines · 2020-02-12T08:41:46Z

Azure Pipelines successfully started running 3 pipeline(s).

akning-ms · 2020-02-13T03:03:53Z

/azp run automation - sdk

azure-pipelines · 2020-02-13T03:04:02Z

Azure Pipelines successfully started running 1 pipeline(s).

akning-ms · 2020-02-13T03:38:11Z

@nullMDR can you help check why Python sdk is fail?

PhoenixHe-NV · 2020-02-13T04:10:35Z

@changlong-liu @ArcturusZhang Could you please help on the autorest failure?

ArcturusZhang · 2020-02-13T04:31:53Z

@NullMDR can you help check why Python sdk is fail?

Well, the root cause is that there is an empty string as enum value, which is breaking both go SDK and C# SDK generated code.

azure-pipelines · 2020-02-13T04:41:55Z

Azure Pipelines successfully started running 1 pipeline(s).

ArcturusZhang · 2020-02-13T04:53:27Z

/azp run automation - sdk

azure-pipelines · 2020-02-13T04:53:35Z

Azure Pipelines successfully started running 1 pipeline(s).

Add properties for networkMode

0d7bc22

openapi-assignment-bot bot assigned ArcturusZhang Feb 8, 2020

openapi-sdkautomation bot mentioned this pull request Feb 8, 2020

[AutoPR @azure/arm-containerservice] Add networkMode to AKS 20200201 API AzureSDKAutomation/azure-sdk-for-js#387

Open

ArcturusZhang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 10, 2020

majastrz reviewed Feb 11, 2020

View reviewed changes

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 12, 2020

majastrz approved these changes Feb 12, 2020

View reviewed changes

openapi-sdkautomation bot mentioned this pull request Feb 12, 2020

[AutoPR sdk/containerservice/mgmt-v2020_02_01] Add networkMode to AKS 20200201 API AzureSDKAutomation/azure-sdk-for-java#1105

Open

rm the empty enum

c5154ef

ArcturusZhang merged commit 4c1552b into Azure:dev-containerservice-Microsoft.ContainerService-2020-02-01 Feb 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add networkMode to AKS 20200201 API #8343

Add networkMode to AKS 20200201 API #8343

gossion commented Feb 8, 2020 •

edited

Loading

azure-pipelines bot commented Feb 8, 2020

azure-pipelines bot commented Feb 8, 2020

openapi-sdkautomation bot commented Feb 8, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 8, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 8, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 8, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 8, 2020 •

edited

Loading

gossion commented Feb 8, 2020

majastrz Feb 11, 2020

gossion Feb 12, 2020

majastrz Feb 12, 2020

majastrz Feb 12, 2020

gossion Feb 12, 2020

isra-fel Feb 13, 2020

majastrz left a comment

palma21 commented Feb 12, 2020

ArcturusZhang commented Feb 12, 2020

azure-pipelines bot commented Feb 12, 2020

ArcturusZhang commented Feb 12, 2020

azure-pipelines bot commented Feb 12, 2020

ArcturusZhang commented Feb 12, 2020

azure-pipelines bot commented Feb 12, 2020

akning-ms commented Feb 13, 2020

azure-pipelines bot commented Feb 13, 2020

akning-ms commented Feb 13, 2020

PhoenixHe-NV commented Feb 13, 2020

ArcturusZhang commented Feb 13, 2020

azure-pipelines bot commented Feb 13, 2020

ArcturusZhang commented Feb 13, 2020

azure-pipelines bot commented Feb 13, 2020

Add networkMode to AKS 20200201 API #8343

Add networkMode to AKS 20200201 API #8343

Conversation

gossion commented Feb 8, 2020 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azure-pipelines bot commented Feb 8, 2020

azure-pipelines bot commented Feb 8, 2020

openapi-sdkautomation bot commented Feb 8, 2020 • edited Loading

azure-sdk-for-python

openapi-sdkautomation bot commented Feb 8, 2020 • edited Loading

azure-sdk-for-net

openapi-sdkautomation bot commented Feb 8, 2020 • edited Loading

azure-sdk-for-js

openapi-sdkautomation bot commented Feb 8, 2020 • edited Loading

azure-sdk-for-java

openapi-sdkautomation bot commented Feb 8, 2020 • edited Loading

azure-sdk-for-go

gossion commented Feb 8, 2020

majastrz Feb 11, 2020

Choose a reason for hiding this comment

gossion Feb 12, 2020

Choose a reason for hiding this comment

majastrz Feb 12, 2020

Choose a reason for hiding this comment

majastrz Feb 12, 2020

Choose a reason for hiding this comment

gossion Feb 12, 2020

Choose a reason for hiding this comment

isra-fel Feb 13, 2020

Choose a reason for hiding this comment

majastrz left a comment

Choose a reason for hiding this comment

palma21 commented Feb 12, 2020

ArcturusZhang commented Feb 12, 2020

azure-pipelines bot commented Feb 12, 2020

ArcturusZhang commented Feb 12, 2020

azure-pipelines bot commented Feb 12, 2020

ArcturusZhang commented Feb 12, 2020

azure-pipelines bot commented Feb 12, 2020

akning-ms commented Feb 13, 2020

azure-pipelines bot commented Feb 13, 2020

akning-ms commented Feb 13, 2020

PhoenixHe-NV commented Feb 13, 2020

ArcturusZhang commented Feb 13, 2020

azure-pipelines bot commented Feb 13, 2020

ArcturusZhang commented Feb 13, 2020

azure-pipelines bot commented Feb 13, 2020

gossion commented Feb 8, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 8, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 8, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 8, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 8, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 8, 2020 •

edited

Loading