AutoScaler Profile Change #8350

marwanad · 2020-02-10T19:28:04Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2020-02-10T19:28:21Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-10T19:43:29Z

Azure Pipelines successfully started running 1 pipeline(s).

PhoenixHe-NV · 2020-02-11T03:00:52Z

/azp run automation - sdk

azure-pipelines · 2020-02-11T03:01:00Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-02-11T03:02:15Z

azure-sdk-for-java

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from c987faf with merge commit 257c2ccab9dae366a23d02a4632f958599d9ca76. SDK Automation 13.0.17.20191226.1
️✔️sdk/containerservice/mgmt-v2019_06_01 [Logs] [Preview SDK Changes]
️✔️sdk/containerservice/mgmt-v2019_08_01 [Logs] [Preview SDK Changes]
️✔️sdk/containerservice/mgmt-v2019_10_01 [Logs] [Preview SDK Changes]
️✔️sdk/containerservice/mgmt-v2019_11_01 [Logs] [Preview SDK Changes]
️✔️sdk/containerservice/mgmt-v2020_01_01 [Logs] [Preview SDK Changes]
️✔️sdk/containerservice/mgmt-v2020_02_01 [Logs] [Preview SDK Changes]

openapi-sdkautomation · 2020-02-11T03:02:17Z

azure-sdk-for-go

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from c987faf with merge commit 257c2ccab9dae366a23d02a4632f958599d9ca76. SDK Automation 13.0.17.20191226.1
⚠️containerservice/mgmt/2017-07-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2017-08-31 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2017-09-30 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2018-03-31 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-02-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-04-30 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-06-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-08-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-10-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2019-11-01 [Logs]
```
No file is changed.
```
⚠️containerservice/mgmt/2020-01-01 [Logs]
```
No file is changed.
```
️✔️containerservice/mgmt/2020-02-01 [Logs] [Preview SDK Changes]
- containerservice.mgmt.2020-02-01.zip
⚠️preview/containerservice/mgmt/2018-08-01-preview [Logs]
```
No file is changed.
```
⚠️preview/containerservice/mgmt/2018-09-30-preview [Logs]
```
No file is changed.
```
⚠️preview/containerservice/mgmt/2019-09-30-preview [Logs]
```
No file is changed.
```

openapi-sdkautomation · 2020-02-11T03:02:17Z

azure-sdk-for-net

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from c987faf with merge commit 257c2ccab9dae366a23d02a4632f958599d9ca76. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.ContainerService [Logs] [Preview SDK Changes]
- Microsoft.Azure.Management.ContainerService.1.0.0.nupkg
- Microsoft.Azure.Management.ContainerService.1.0.0.snupkg

openapi-sdkautomation · 2020-02-11T03:02:23Z

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from c987faf with merge commit 257c2ccab9dae366a23d02a4632f958599d9ca76. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-containerservice [Logs] [Preview SDK Changes]

azure-arm-containerservice-10.0.0.tgz

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/containerServiceClient.js → ./dist/arm-containerservice.js...
[npmPack] created ./dist/arm-containerservice.js in 356ms

openapi-sdkautomation · 2020-02-11T03:02:26Z

azure-sdk-for-python

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from c987faf with merge commit 257c2ccab9dae366a23d02a4632f958599d9ca76. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-containerservice [Logs] [Preview SDK Changes]

[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-07-01', '2019-04-01'} in label v2017_07_01
[after_scripts|python] WARNING:__main__:Guessing you want 2017-07-01 based on label v2017_07_01
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

azure-pipelines · 2020-02-11T08:01:03Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-11T08:01:47Z

Azure Pipelines successfully started running 1 pipeline(s).

...erservice/resource-manager/Microsoft.ContainerService/stable/2020-02-01/managedClusters.json

majastrz

Signed off from ARM side. Be aware of the caveats I called out on the additionalProperties approach.

azure-pipelines · 2020-02-12T00:57:33Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-12T01:20:05Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-12T01:22:39Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-12T01:25:34Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-12T01:29:50Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-12T17:29:07Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-12T17:45:59Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-12T20:59:12Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-12T21:25:57Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-12T22:32:51Z

Azure Pipelines successfully started running 1 pipeline(s).

PhoenixHe-NV · 2020-02-13T03:01:48Z

/azp run automation - sdk

azure-pipelines · 2020-02-13T03:01:58Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-assignment-bot bot assigned PhoenixHe-NV Feb 10, 2020

marwanad requested review from xizha162 and gtxistxgao February 10, 2020 19:54

PhoenixHe-NV added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 11, 2020

majastrz reviewed Feb 11, 2020

View reviewed changes

...erservice/resource-manager/Microsoft.ContainerService/stable/2020-02-01/managedClusters.json Outdated Show resolved Hide resolved

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 11, 2020

majastrz approved these changes Feb 11, 2020

View reviewed changes

marwanad added 2 commits February 11, 2020 17:13

add autoScalerProfile to spec

b51b1b6

add example for put MC

c5373f5

marwanad added 2 commits February 11, 2020 17:13

add to custom words

11c1cc8

add list of accepted params

ff6b011

marwanad force-pushed the aks-autoscaler branch from 1d62cf9 to 241a712 Compare February 12, 2020 01:19

marwanad force-pushed the aks-autoscaler branch from 241a712 to 6cf93b0 Compare February 12, 2020 01:22

marwanad force-pushed the aks-autoscaler branch from 6cf93b0 to 536eab3 Compare February 12, 2020 01:25

disable linting for profile

7a15ac9

marwanad force-pushed the aks-autoscaler branch from 536eab3 to 7a15ac9 Compare February 12, 2020 01:29

update example

c987faf

openapi-sdkautomation bot mentioned this pull request Feb 12, 2020

[AutoPR sdk/containerservice/mgmt-v2020_02_01] AutoScaler Profile Change AzureSDKAutomation/azure-sdk-for-java#1109

Open

marwanad force-pushed the aks-autoscaler branch from ea396a0 to c55414e Compare February 12, 2020 21:25

marwanad force-pushed the aks-autoscaler branch from c55414e to c987faf Compare February 12, 2020 22:32

PhoenixHe-NV merged commit fe24e32 into Azure:dev-containerservice-Microsoft.ContainerService-2020-02-01 Feb 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AutoScaler Profile Change #8350

AutoScaler Profile Change #8350

marwanad commented Feb 10, 2020 •

edited

Loading

azure-pipelines bot commented Feb 10, 2020

azure-pipelines bot commented Feb 10, 2020

PhoenixHe-NV commented Feb 11, 2020

azure-pipelines bot commented Feb 11, 2020

openapi-sdkautomation bot commented Feb 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 11, 2020 •

edited

Loading

azure-pipelines bot commented Feb 11, 2020

azure-pipelines bot commented Feb 11, 2020

majastrz left a comment

azure-pipelines bot commented Feb 12, 2020

azure-pipelines bot commented Feb 12, 2020

azure-pipelines bot commented Feb 12, 2020

azure-pipelines bot commented Feb 12, 2020

azure-pipelines bot commented Feb 12, 2020

azure-pipelines bot commented Feb 12, 2020

azure-pipelines bot commented Feb 12, 2020

azure-pipelines bot commented Feb 12, 2020

azure-pipelines bot commented Feb 12, 2020

azure-pipelines bot commented Feb 12, 2020

PhoenixHe-NV commented Feb 13, 2020

azure-pipelines bot commented Feb 13, 2020

AutoScaler Profile Change #8350

AutoScaler Profile Change #8350

Conversation

marwanad commented Feb 10, 2020 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azure-pipelines bot commented Feb 10, 2020

azure-pipelines bot commented Feb 10, 2020

PhoenixHe-NV commented Feb 11, 2020

azure-pipelines bot commented Feb 11, 2020

openapi-sdkautomation bot commented Feb 11, 2020 • edited Loading

azure-sdk-for-java

openapi-sdkautomation bot commented Feb 11, 2020 • edited Loading

azure-sdk-for-go

openapi-sdkautomation bot commented Feb 11, 2020 • edited Loading

azure-sdk-for-net

openapi-sdkautomation bot commented Feb 11, 2020 • edited Loading

azure-sdk-for-js

openapi-sdkautomation bot commented Feb 11, 2020 • edited Loading

azure-sdk-for-python

azure-pipelines bot commented Feb 11, 2020

azure-pipelines bot commented Feb 11, 2020

majastrz left a comment

Choose a reason for hiding this comment

azure-pipelines bot commented Feb 12, 2020

azure-pipelines bot commented Feb 12, 2020

azure-pipelines bot commented Feb 12, 2020

azure-pipelines bot commented Feb 12, 2020

azure-pipelines bot commented Feb 12, 2020

azure-pipelines bot commented Feb 12, 2020

azure-pipelines bot commented Feb 12, 2020

azure-pipelines bot commented Feb 12, 2020

azure-pipelines bot commented Feb 12, 2020

azure-pipelines bot commented Feb 12, 2020

PhoenixHe-NV commented Feb 13, 2020

azure-pipelines bot commented Feb 13, 2020

marwanad commented Feb 10, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Feb 11, 2020 •

edited

Loading