[Compute] Add new gallery API version and new encryption fields #8364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
January 17, 2020 13:07
…ryptionSetId is needed
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 similar comments
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-java - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-net - Release
|
This was referenced Feb 12, 2020
This was referenced Feb 12, 2020
mmyyrroonn
added
the
WaitForARMFeedback
| "galleryName": "myGalleryName", | ||
| "galleryImageName": "myGalleryImageName", | ||
| "galleryImageVersionName": "1.0.0", | ||
| "galleryImageVersion": { |
There was a problem hiding this comment.
i know it may appear in previous examples. but it looks to me this "galleryImageVersion" field is not needed.
There was a problem hiding this comment.
do you want it removed in all the examples? what would you replace it with?
There was a problem hiding this comment.
yeah, remove them from all the examples
| "storageAccountType": "Standard_LRS", | ||
| "encryption": { | ||
| "osDiskImage": { | ||
| "diskEncryptionSetId": "/subscriptions/{subscriptionId}/resourceGroups/myResourceGroup/providers/Microsoft.Compute/diskEncryptionSet/myDiskEncryptionSet" |
There was a problem hiding this comment.
is this field updatable?
| "description": "The name of the gallery Image Definition publisher." | ||
| }, | ||
| "offer": { | ||
| "t |
There was a problem hiding this comment.
do you also need property "public EncryptionType? type { get; set; }"?
There was a problem hiding this comment.
crp and diskrp decided to remove it and we are following suit
| "description": "The name of the gallery Image Definition publisher." | ||
| }, | ||
| "offer": { | ||
| "t |
There was a problem hiding this comment.
do you need a default Encryption so that if OS/DataDiskImages doesn't have it, then the default Encryption applies?
There was a problem hiding this comment.
we decided to remove it
There was a problem hiding this comment.
ie. if default = customer but you want the OS to be platform, there's no way to specify that since we removed encryption type
There was a problem hiding this comment.
so since we removed encryption type to be consistent with CPR and diskRP, we also needed to remove default
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
LGTM |
majastrz
reviewed
Feb 14, 2020
| "storageAccountType": "Standard_LRS", | ||
| "encryption": { | ||
| "osDiskImage": { | ||
| "diskEncryptionSetId": "/subscriptions/{subscriptionId}/resourceGroups/myResourceGroup/providers/Microsoft.Compute/diskEncryptionSet/myDiskEncryptionSet" |
There was a problem hiding this comment.
/subscriptions/{subscriptionId}/resourceGroups/myResourceGroup/providers/Microsoft.Compute/diskEncryptionSet/myDiskEncryptionSet [](start = 44, length = 128)
How is the disk encryption set created? Who creates it? And what happens if it's removed after it's referenced?
There was a problem hiding this comment.
sorry for delayed response, got caught up with livesite
The disk encryption set is created separately by the customer via DiskRP APIs. If it is removed after, update calls (ie. increasing the snapshot replicas of the image) will fail with notFound since there is no way to encrypt the image anymore.
Deployments with this image will not be possible since the customer will specify this DES during deployment and NotFound will also be returned.
Customer can cleanup the image via Delete in this scenario.
There was a problem hiding this comment.
Sounds good. Thanks for explaining.
|
I added a question. Please take a look. |
mmyyrroonn
approved these changes
Feb 14, 2020
majastrz
added
ARMSignedOff
hyonholee
approved these changes
Feb 15, 2020
ssripadham
pushed a commit
to ssripadham/azure-rest-api-specs
that referenced
this pull request
Feb 21, 2020
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.