Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding allowProtectedAppendWrites support for Immutability Policy #8485

Merged
merged 3 commits into from
Feb 24, 2020
Merged

Adding allowProtectedAppendWrites support for Immutability Policy #8485

merged 3 commits into from
Feb 24, 2020

Conversation

HimanshuChhabra
Copy link
Member

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 22, 2020 •
edited
Loading

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from e787f15 with merge commit dcd51ec. SDK Automation 13.0.17.20191226.1
  • ️✔️azure-mgmt-storage [Logs]  [Release SDK Changes] 
    [after_scripts|python] WARNING:__main__:Found too much API version: {'2018-07-01', '2018-03-01-preview'} in label v2018_07_01
[after_scripts|python] WARNING:__main__:Guessing you want 2018-07-01 based on label v2018_07_01
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 22, 2020 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 22, 2020 •
edited
Loading

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 22, 2020 •
edited
Loading

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from e787f15 with merge commit dcd51ec. SDK Automation 13.0.17.20191226.1
  • ️✔️@azure/arm-storage [Logs]  [Release SDK Changes] 
    [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/storageManagementClient.js → ./dist/arm-storage.js...
[npmPack] created ./dist/arm-storage.js in 608ms

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 22, 2020 •
edited
Loading

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Feb 22, 2020
Closed
@HimanshuChhabra
Copy link
Member Author

This PR was approved in the private repo
https://github.com/Azure/azure-rest-api-specs-pr/pull/1105

This was referenced Feb 22, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ravbhatnagar
Copy link
Contributor

this has been signed off in the private repo - https://github.com/Azure/azure-rest-api-specs-pr/pull/1105
Signing off from ARM side.

@ravbhatnagar ravbhatnagar added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Feb 24, 2020
@zikalino zikalino merged commit dcd51ec into Azure:master Feb 24, 2020
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
@HimanshuChhabra @00Kai0
Adding allowProtectedAppendWrites support for Immutability Policy (Az…
3b566ff 
…ure#8485)

* Adding allowProtectedAppendWrites support for Immutability Policy

* Adjust indentation

* Updating description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zikalino zikalino zikalino approved these changes

Assignees

@zikalino zikalino

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HimanshuChhabra @ravbhatnagar @zikalino