Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codegen logic onboard cli #8623

Closed
wants to merge 3 commits into from
Closed

codegen logic onboard cli #8623

wants to merge 3 commits into from

Conversation

qiaozha
Copy link
Member

@qiaozha qiaozha commented Mar 7, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 7, 2020 •
edited
Loading

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 8fbe4cf with merge commit 619ac29879948aeb19546be7a36e1f00238c0723. SDK Automation 13.0.17.20191226.1
  • ️✔️@azure/arm-logic [Logs]  [Preview SDK Changes] 
    [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/logicManagementClient.js → ./dist/arm-logic.js...
[npmPack] created ./dist/arm-logic.js in 934ms

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 7, 2020 •
edited
Loading

azure-sdk-for-java

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 8fbe4cf with merge commit 619ac29879948aeb19546be7a36e1f00238c0723. SDK Automation 13.0.17.20191226.1
  • ️✔️sdk/logic/mgmt-v2016_06_01 [Logs]  [Preview SDK Changes]
  • ️✔️sdk/logic/mgmt-v2018_07_01_preview [Logs]  [Preview SDK Changes]
  • ⚠️sdk/logic/mgmt-v2019_05_01 [Logs]  [Preview SDK Changes] 
      [mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/logic/mgmt-v2019_05_01/src/main/java/com/microsoft/azure/management/logic/v2019_05_01/IntegrationServiceEnvironmentNetworkHealths.java:[27,16] cannot find symbol
[mvn]   symbol:   class Map
[mvn]   location: interface com.microsoft.azure.management.logic.v2019_05_01.IntegrationServiceEnvironmentNetworkHealths
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/logic/mgmt-v2019_05_01/src/main/java/com/microsoft/azure/management/logic/v2019_05_01/IntegrationServiceEnvironmentNetworkHealths.java:[27,28] cannot find symbol
[mvn]   symbol:   class IntegrationServiceEnvironmentSubnetNetworkHealthInner
[mvn]   location: interface com.microsoft.azure.management.logic.v2019_05_01.IntegrationServiceEnvironmentNetworkHealths
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/logic/mgmt-v2019_05_01/src/main/java/com/microsoft/azure/management/logic/v2019_05_01/implementation/IntegrationServiceEnvironmentNetworkHealthsImpl.java:[30,23] cannot find symbol
[mvn]   symbol:   class Map
[mvn]   location: class com.microsoft.azure.management.logic.v2019_05_01.implementation.IntegrationServiceEnvironmentNetworkHealthsImpl
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-logic: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/logic/mgmt-v2019_05_01/src/main/java/com/microsoft/azure/management/logic/v2019_05_01/IntegrationServiceEnvironmentNetworkHealths.java:[27,16] cannot find symbol
[mvn] [ERROR]   symbol:   class Map
[mvn] [ERROR]   location: interface com.microsoft.azure.management.logic.v2019_05_01.IntegrationServiceEnvironmentNetworkHealths
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/logic/mgmt-v2019_05_01/src/main/java/com/microsoft/azure/management/logic/v2019_05_01/IntegrationServiceEnvironmentNetworkHealths.java:[27,28] cannot find symbol
[mvn] [ERROR]   symbol:   class IntegrationServiceEnvironmentSubnetNetworkHealthInner
[mvn] [ERROR]   location: interface com.microsoft.azure.management.logic.v2019_05_01.IntegrationServiceEnvironmentNetworkHealths
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/logic/mgmt-v2019_05_01/src/main/java/com/microsoft/azure/management/logic/v2019_05_01/implementation/IntegrationServiceEnvironmentNetworkHealthsImpl.java:[30,23] cannot find symbol
[mvn] [ERROR]   symbol:   class Map
[mvn] [ERROR]   location: class com.microsoft.azure.management.logic.v2019_05_01.implementation.IntegrationServiceEnvironmentNetworkHealthsImpl
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Mar 7, 2020 •
    edited
    Loading

    azure-sdk-for-go

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 8fbe4cf with merge commit 619ac29879948aeb19546be7a36e1f00238c0723. SDK Automation 13.0.17.20191226.1
    • ⚠️logic/mgmt/2016-06-01 [Logs]  
        No file is changed.
      • ⚠️logic/mgmt/2019-05-01 [Logs]  
          No file is changed.
        • ⚠️preview/logic/mgmt/2015-02-01-preview [Logs]  
            No file is changed.
          • ⚠️preview/logic/mgmt/2015-08-01-preview [Logs]  
              No file is changed.
            • ⚠️preview/logic/mgmt/2018-07-01-preview [Logs]  
                No file is changed.

              @openapi-sdkautomation
              Copy link

              openapi-sdkautomation bot commented Mar 7, 2020 •
              edited
              Loading

              azure-sdk-for-net

              ❌ failed [Logs] [Expand Details]
              • ❌ Generate from 8fbe4cf with merge commit 619ac29879948aeb19546be7a36e1f00238c0723. SDK Automation 13.0.17.20191226.1 
                [AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
              • ❌Microsoft.Azure.Management.Logic [Logs]  [Preview SDK Changes] 
                  Failed to create the package Microsoft.Azure.Management.Logic.
Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=logic /v:n /p:SkipTests=true , {}

                @openapi-sdkautomation
                Copy link

                openapi-sdkautomation bot commented Mar 7, 2020 •
                edited
                Loading

                azure-sdk-for-python

                ️✔️ succeeded [Logs] [Expand Details]
                • ️✔️ Generate from 8fbe4cf with merge commit 619ac29879948aeb19546be7a36e1f00238c0723. SDK Automation 13.0.17.20191226.1
                • ️✔️azure-mgmt-logic [Logs]  [Preview SDK Changes] 
                  [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

                This was referenced Mar 7, 2020
                Open
                Open
                Open
                Open
                Open
                @qiaozha qiaozha added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Mar 7, 2020
                @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Mar 7, 2020
                Open
                @lirenhe
                Copy link
                Member

                lirenhe commented Mar 12, 2020

                @qiaozha, is this PR ready for review?

                @qiaozha
                Copy link
                Member Author

                qiaozha commented Mar 12, 2020

                @qiaozha, is this PR ready for review?

                Not yet. this is for cli extension onboard swagger pipeline. I think you can ignore this right now.

                @qiaozha
                Copy link
                Member Author

                qiaozha commented Mar 12, 2020

                I will close it since Rodge has already had another PR to submit the file.

                @qiaozha qiaozha closed this Mar 12, 2020
                @JackTn
                Copy link
                Member

                JackTn commented Aug 23, 2021

                Hi, @qiaozha. The PR has be closed for a long time and it's related branch still exist. If no further used for over 14 days, I will delete this related branch. Please tell me if you still need this branch.

                @JackTn
                Copy link
                Member

                JackTn commented Jun 16, 2022

                Hi, @qiaozha. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

                2 similar comments
                @JackTn
                Copy link
                Member

                JackTn commented Jun 16, 2022

                Hi, @qiaozha. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

                @JackTn
                Copy link
                Member

                JackTn commented Jun 16, 2022

                Hi, @qiaozha. The PR has be closed for a long time and it's related branch still exist. Please tell me if you still need this branch or i will delete it in 14 days.

                @JackTn JackTn deleted the codegen-logic-onboard-cli branch July 5, 2022 01:19
                Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
                Reviewers
                No reviews
                Assignees

                @lirenhe lirenhe

                Labels
                DoNotMerge <valid label in PR review process> use to hold merge after approval
                Projects
                None yet
                Milestone
                No milestone
                Development

                Successfully merging this pull request may close these issues.
                4 participants
                @qiaozha @azuresdkci @lirenhe @JackTn