Add properties of Identity. #8647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No commit pushedDate could be found for PR 8647 in repo Azure/azure-rest-api-specs |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-go - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
This was referenced Mar 9, 2020
Closed
Closed
Closed
Closed
[AutoPR azure-mgmt-resource] Add properties of Identity.
AzureSDKAutomation/azure-sdk-for-python#570
Closed
|
Can one of the admins verify this patch? |
This was referenced Mar 9, 2020
lirenhe
added
the
WaitForARMFeedback
lirenhe
reviewed
Mar 10, 2020
| @@ -1606,16 +1606,39 @@ | |||
| "type": "string", | |||
| "description": "The identity type.", | |||
| "enum": [ | |||
| "SystemAssigned" | |||
| "SystemAssigned", | |||
There was a problem hiding this comment.
will this cause breaking changes
There was a problem hiding this comment.
This shouldn't be breaking. It's adding new value to enum and added a not required property. Old schema should still be accepted.
There was a problem hiding this comment.
Do you have SDK released for this? As the enum is not modeled as string, new SDK released will be broken because the values in enum could be different
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
pilor
added
ARMReviewInProgress
ARMSignedOff
pilor
approved these changes
Mar 26, 2020
pilor
added
ARMChangesRequested
pilor
suggested changes
Mar 26, 2020
| "type": "string", | ||
| "description": "The principal id of user assigned identity." | ||
| }, | ||
| "tenantId": { |
There was a problem hiding this comment.
The public docs and the MSI spec seem to imply that the contract has changed to "principalId" and "clientId"... However, the contracts in ARM still have these properties. Which is correct? https://microsoft.sharepoint.com/:w:/r/teams/azureresourcemanagerteam/_layouts/15/Doc.aspx?sourcedoc=%7B66505FCE-8057-4524-B84F-4CEFE2D8A77C%7D&file=ARMResourcesWithStrongIdentity.docx&action=default&mobileredirect=true
I've seen more RPs using clientId recently
There was a problem hiding this comment.
This is inline with current service behavior, we are trying to make them sync for now.
I talked to the code owner of the the backend service, will submit a new api version and swagger when he makes the change.
There was a problem hiding this comment.
ok, please mark them as readOnly since the user is not providing these values
pilor
added
ARMSignedOff
pilor
approved these changes
Mar 27, 2020
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
azure-cli-extensions - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
@dandanwang0320 , the tool check detected the breaking change in this PR, could you provide the business justification about this breaking change and what the impact of that? |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lirenhe
approved these changes
Apr 3, 2020
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* Add missed properties of Identity. * Fix prettier check. * Add read only according to comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.