Add support for ip filter rules in DPS #8700

nivimsft · 2020-03-13T02:38:19Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ x ] I have reviewed the documentation for the workflow.
[ x ] Validation tools were run on swagger spec(s) and have all been fixed in this PR. (Pre-existing issues have not been addressed)
[ x ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ x ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ x ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azuresdkci · 2020-03-13T03:10:09Z

Can one of the admins verify this patch?

azure-pipelines · 2020-03-18T17:41:47Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-03-18T17:43:07Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 6667cf4 with merge commit 00b418e. SDK Automation 13.0.17.20200320.2
⚠️preview/provisioningservices/mgmt/2017-08-21-preview [Logs]
```
No file is changed.
```
⚠️provisioningservices/mgmt/2017-11-15 [Logs]
```
No file is changed.
```
⚠️provisioningservices/mgmt/2018-01-22 [Logs]
```
No file is changed.
```

openapi-sdkautomation · 2020-03-18T17:43:07Z

azure-sdk-for-java - Release

❌ failed [Logs] [Expand Details]

❌ Generate from 6667cf4 with merge commit 00b418e. SDK Automation 13.0.17.20200320.2

[AutoRest] FATAL: System.ArgumentException: An item with the same key has already been added. Key: dpsCertificates
[AutoRest]    at System.ThrowHelper.ThrowAddingDuplicateWithKeyArgumentException(Object key)
[AutoRest]    at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
[AutoRest]    at System.Collections.Generic.Dictionary`2.Add(TKey key, TValue value)
[AutoRest]    at AutoRest.Java.Azure.Fluent.Model.SegmentFluentMethodGroups.Add(SegmentFluentMethodGroupList list) in /home/vsts/work/1/s/src/azurefluent/Model/FluentCommon/FluentMethodGroup/SegmentFluentMethodGroup/SegmentFluentMethodGroups.cs:line 66
[AutoRest]    at AutoRest.Java.Azure.Fluent.Model.SegmentFluentMethodGroups.InnerMethodGroupToSegmentFluentMethodGroups(CodeModelJvaf codeModel) in /home/vsts/work/1/s/src/azurefluent/Model/FluentCommon/FluentMethodGroup/SegmentFluentMethodGroup/SegmentFluentMethodGroups.cs:line 79
[AutoRest]    at AutoRest.Java.Azure.Fluent.CodeGeneratorJvaf.d__6.MoveNext() in /home/vsts/work/1/s/src/azurefluent/CodeGeneratorJvaf.cs:line 55
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at AutoRest.Java.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 114
[AutoRest] --- End of stack trace from previous location where exception was thrown ---
[AutoRest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
[AutoRest]    at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
[AutoRest]    at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
[AutoRest] FATAL: java/generate - FAILED
[AutoRest] FATAL: Error: Plugin java reported failure.
[AutoRest] Failure during batch task - {"tag":"package-2017-08"} -- Error: Plugin java reported failure..
[AutoRest]   Error: Plugin java reported failure.
Failed to run autorest.
Error: /z/node_modules/.bin/autorest --version=2.0.4413 --java --verbose --multiapi --use=@microsoft.azure/autorest.java@2.1.95 --azure-libraries-for-java-folder=/z/work/azure-sdk-for-java /z/work/azure-rest-api-specs/specification/deviceprovisioningservices/resource-manager/readme.md FATAL: System.ArgumentException: An item with the same key has already been added. Key: dpsCertificates
   at System.ThrowHelper.ThrowAddingDuplicateWithKeyArgumentException(Object key)
   at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
   at System.Collections.Generic.Dictionary`2.Add(TKey key, TValue value)
   at AutoRest.Java.Azure.Fluent.Model.SegmentFluentMethodGroups.Add(SegmentFluentMethodGroupList list) in /home/vsts/work/1/s/src/azurefluent/Model/FluentCommon/FluentMethodGroup/SegmentFluentMethodGroup/SegmentFluentMethodGroups.cs:line 66
   at AutoRest.Java.Azure.Fluent.Model.SegmentFluentMethodGroups.InnerMethodGroupToSegmentFluentMethodGroups(CodeModelJvaf codeModel) in /home/vsts/work/1/s/src/azurefluent/Model/FluentCommon/FluentMethodGroup/SegmentFluentMethodGroup/SegmentFluentMethodGroups.cs:line 79
   at AutoRest.Java.Azure.Fluent.CodeGeneratorJvaf.d__6.MoveNext() in /home/vsts/work/1/s/src/azurefluent/CodeGeneratorJvaf.cs:line 55
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Java.Program.d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 114
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at NewPlugin.d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
FATAL: java/generate - FAILED
FATAL: Error: Plugin java reported failure.
Failure during batch task - {"tag":"package-2017-08"} -- Error: Plugin java reported failure..
  Error: Plugin java reported failure.
, {}

openapi-sdkautomation · 2020-03-18T17:43:10Z

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-03-18T17:43:16Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 6667cf4 with merge commit 00b418e. SDK Automation 13.0.17.20200320.2

️✔️@azure/arm-deviceprovisioningservices [Logs] [Release SDK Changes]

azure-arm-deviceprovisioningservices-2.1.0.tgz

[npmPack] npm WARN lifecycle @azure/arm-deviceprovisioningservices@2.1.0~prepack: cannot run in wd @azure/arm-deviceprovisioningservices@2.1.0 npm install && npm run build (wd=/z/work/azure-sdk-for-js/sdk/deviceprovisioningservices/arm-deviceprovisioningservices)

openapi-sdkautomation · 2020-03-18T17:43:18Z

azure-sdk-for-net - Release

❌ failed [Logs] [Expand Details]

❌ Generate from 6667cf4 with merge commit 00b418e. SDK Automation 13.0.17.20200320.2

❌Microsoft.Azure.Management.DeviceProvisioningServices [Logs] [Release SDK Changes]

Failed to create the package Microsoft.Azure.Management.DeviceProvisioningServices.
Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=deviceprovisioningservices /v:n /p:SkipTests=true , {}

openapi-sdkautomation · 2020-03-18T17:43:19Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 6667cf4 with merge commit 00b418e. SDK Automation 13.0.17.20200320.2

️✔️azure-mgmt-iothubprovisioningservices [Logs] [Release SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[breaking_change_setup] Cannot uninstall requirement azure-nspkg, not installed
[breaking_change_setup] Command '['/usr/local/bin/python', '-m', 'pip', 'uninstall', '-y', 'azure-nspkg']' returned non-zero exit status 1.
[ChangeLog] Size of delta 0.011% size of original (original: 18234 chars, delta: 2 chars)
[ChangeLog]

azure-pipelines · 2020-03-18T17:46:03Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-18T17:50:36Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-18T17:57:50Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-03-18T18:36:29Z

Azure Pipelines successfully started running 1 pipeline(s).

pilor

Approving due to previous review in https://github.com/Azure/azure-rest-api-specs-pr/pull/1142

nivimsft · 2020-03-25T23:23:52Z

Approving due to previous review in Azure/azure-rest-api-specs-pr#1142

@pilor thanks a lot for your help with this :)

* Adding support for IP filter rules and introduce a new API version * Addressing precheck failures * Addressing precheck failures * Adding swagger refrence to readme file

nivimsft added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 13, 2020

openapi-assignment-bot bot assigned qianwens Mar 13, 2020

Adding support for IP filter rules and introduce a new API version

ea32b2d

nivimsft force-pushed the ipfilterrules3 branch from 34dc868 to ea32b2d Compare March 18, 2020 17:45

openapi-sdkautomation bot mentioned this pull request Mar 18, 2020

[AutoPR Microsoft.Azure.Management.DeviceProvisioningServices] Add support for ip filter rules in DPS AzureSDKAutomation/azure-sdk-for-net#719

Closed

Addressing precheck failures

0dd54f1

Addressing precheck failures

aa731cb

Adding swagger refrence to readme file

6667cf4

pilor approved these changes Mar 25, 2020

View reviewed changes

pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 25, 2020

qianwens merged commit 00b418e into Azure:master Mar 26, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for ip filter rules in DPS #8700

Add support for ip filter rules in DPS #8700

nivimsft commented Mar 13, 2020 •

edited

Loading

azuresdkci commented Mar 13, 2020

azure-pipelines bot commented Mar 18, 2020

openapi-sdkautomation bot commented Mar 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 18, 2020 •

edited

Loading

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

pilor left a comment

nivimsft commented Mar 25, 2020

Add support for ip filter rules in DPS #8700

Add support for ip filter rules in DPS #8700

Conversation

nivimsft commented Mar 13, 2020 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azuresdkci commented Mar 13, 2020

azure-pipelines bot commented Mar 18, 2020

openapi-sdkautomation bot commented Mar 18, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Mar 18, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Mar 18, 2020 • edited Loading

azure-cli-extensions - Release

openapi-sdkautomation bot commented Mar 18, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Mar 18, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Mar 18, 2020 • edited Loading

azure-sdk-for-python - Release

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

azure-pipelines bot commented Mar 18, 2020

pilor left a comment

Choose a reason for hiding this comment

nivimsft commented Mar 25, 2020

nivimsft commented Mar 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 18, 2020 •

edited

Loading

openapi-sdkautomation bot commented Mar 18, 2020 •

edited

Loading