Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding privateEndpoint child resource privateDNSZoneGroup and adding customDNSconfig JSON to privateEndpoint. #8704

Merged
merged 19 commits into from
Apr 2, 2020
Merged

Adding privateEndpoint child resource privateDNSZoneGroup and adding customDNSconfig JSON to privateEndpoint. #8704

Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
e815231
Adding privateEndpoint child resource privateDNSZoneGroup, as well as…
Mar 13, 2020
09bf614
Adding endzone keyword for build
Mar 13, 2020
60db2f2
Adding reference to 2020 private endpoint in readme for validation pu…
Mar 15, 2020
4abe83b
Misspelled reference to Get file fixed
Mar 15, 2020
fb44b13
Ran prettier fix on files
Mar 15, 2020
176991c
Removing reference in readme
Mar 15, 2020
b0eb57f
Added some needed capitilization and punctuation, will be a pt2 to th…
Mar 15, 2020
7de4bfc
Added descriptions
Mar 15, 2020
cdfd575
Rerunning tests.
Mar 15, 2020
9040db5
Updated definitions for customdnsconfig and record set
Mar 16, 2020
30a5f34
Rebuilding for pr
Mar 17, 2020
0629578
Changing word back to original sentence for PR.
Mar 17, 2020
60fd6be
Changed name in example file for create, as well as added List operat…
Mar 27, 2020
d951084
resolved comments based on pr
Mar 29, 2020
7103bc2
Added changes based on PRcomments
Mar 30, 2020
401c780
Added integer tag to ttl
Mar 30, 2020
5c0da33
getting rid of type in private endpoint json
Mar 31, 2020
b626822
Changed type attribute in privateendpointdnszonegroupget
Mar 31, 2020
746014c
Added read only attribute to record set array
Mar 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions custom-words.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,7 @@ endswith
endtime
Enein
engagementfabric
endzone
enquoted
entitydocument
entitysearch
Expand Down
28 changes: 28 additions & 0 deletions .../resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointCreate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,20 @@
{
"id": "/subscriptions/subId/resourceGroups/rg1/provders/Microsoft.Network/networkInterfaces/testPe.nic.abcd1234"
}
],
"customDnsConfigs": [
{
"fqdn": "abc.cosmos.com",
"ipAddresses": [
"192.168.0.4"
]
},
{
"fqdn": "abc2.cosmos.com",
"ipAddresses": [
"192.168.0.5"
]
}
]
}
}
Expand Down Expand Up @@ -90,6 +104,20 @@
{
"id": "/subscriptions/subId/resourceGroups/rg1/provders/Microsoft.Network/networkInterfaces/testPe.nic.abcd1234"
}
],
"customDnsConfigs": [
{
"fqdn": "abc.cosmos.com",
"ipAddresses": [
"192.168.0.4"
]
},
{
"fqdn": "abc2.cosmos.com",
"ipAddresses": [
"192.168.0.5"
]
}
]
}
}
Expand Down
28 changes: 28 additions & 0 deletions .../Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointCreateForManualApproval.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,20 @@
{
"id": "/subscriptions/subId/resourceGroups/rg1/provders/Microsoft.Network/networkInterfaces/testPe.nic.abcd1234"
}
],
"customDnsConfigs": [
{
"fqdn": "abc.cosmos.com",
"ipAddresses": [
"192.168.0.4"
]
},
{
"fqdn": "abc2.cosmos.com",
"ipAddresses": [
"192.168.0.5"
]
}
]
}
}
Expand Down Expand Up @@ -90,6 +104,20 @@
{
"id": "/subscriptions/subId/resourceGroups/rg1/provders/Microsoft.Network/networkInterfaces/testPe.nic.abcd1234"
}
],
"customDnsConfigs": [
{
"fqdn": "abc.cosmos.com",
"ipAddresses": [
"192.168.0.4"
]
},
{
"fqdn": "abc2.cosmos.com",
"ipAddresses": [
"192.168.0.5"
]
}
]
}
}
Expand Down
90 changes: 90 additions & 0 deletions ...nager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointDnsZoneGroupCreate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,90 @@
{
"parameters": {
"api-version": "2020-03-01",
"subscriptionId": "subId",
"resourceGroupName": "rg1",
"privateEndpointName": "testPe",
"privateDnsZoneGroupName": "testPdnsgroup",
"parameters": {
"properties": {
"privateDnsZoneConfigs": [
{
"properties": {
"privateDnsZoneId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateDnsZones/zone1.com"
}
}
]
}
}
},
"responses": {
"200": {
"body": {
"name": "testPdnsgroup",
"id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateLinkServices/testPe/privateDnsZoneGroups/testPdnsgroup",
"properties": {
"provisioningState": "Succeeded",
"privateDnsZoneConfigs": [
{
"properties": {
"privateDnsZoneId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateDnsZones/zone1.com",
"recordSets": [
{
"recordType": "A",
"recordSetName": "abc",
"fqdn": "abc.zone1.com",
"ipAddresses": [
"10.0.0.4"
]
},
{
"recordType": "A",
"recordSetName": "abc2",
"fqdn": "abc2.zone1.com",
"ipAddresses": [
"10.0.0.5"
]
}
]
}
}
]
}
}
},
"201": {
"body": {
"name": "testPdnsgroup",
"id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateLinkServices/testPe/privateDnsZoneGroups/testPdnsgroup",
"properties": {
"provisioningState": "Succeeded",
"privateDnsZoneConfigs": [
{
"properties": {
"privateDnsZoneId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateDnsZones/zone1.com",
"recordSets": [
{
"recordType": "A",
"recordSetName": "abc",
"fqdn": "abc.zone1.com",
"ipAddresses": [
"10.0.0.4"
]
},
{
"recordType": "A",
"recordSetName": "abc2",
"fqdn": "abc2.zone1.com",
"ipAddresses": [
"10.0.0.5"
]
}
]
}
}
]
}
}
}
}
}
14 changes: 14 additions & 0 deletions ...nager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointDnsZoneGroupDelete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"parameters": {
"api-version": "2020-03-01",
"subscriptionId": "subId",
"resourceGroupName": "rg1",
"privateEndpointName": "testPe",
"privateDnsZoneGroupName": "testPdnsgroup"
},
"responses": {
"200": {},
"202": {},
"204": {}
}
}
69 changes: 69 additions & 0 deletions ...-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointDnsZoneGroupGet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
{
"parameters": {
"api-version": "2020-03-01",
"subscriptionId": "subId",
"resourceGroupName": "rg1",
"privateEndpointName": "testPe",
"privateDnsZoneGroupName": "testPdnsgroup"
},
"responses": {
"200": {
"body": {
"name": "testPdnsgroup",
"id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateLinkServices/testPe/privateDnsZoneGroups/testPdnsgroup",
"type": "Microsoft.Network/privateEndpoints/privateDnsZoneGroups",
"properties": {
"provisioningState": "Succeeded",
"privateDnsZoneConfigs": [
{
"properties": {
"privateDnsZoneId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateDnsZones/zone1.com",
"recordSets": [
{
"recordType": "A",
"recordSetName": "abc",
"fqdn": "abc.zone1.com",
"ipAddresses": [
"10.0.0.4"
]
},
{
"recordType": "A",
"recordSetName": "abc2",
"fqdn": "abc2.zone1.com",
"ipAddresses": [
"10.0.0.5"
]
}
]
}
},
{
"properties": {
"privateDnsZoneId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateDnsZones/zone2.com",
"recordSets": [
{
"recordType": "A",
"recordSetName": "abc",
"fqdn": "abc.zone2.com",
"ipAddresses": [
"10.0.0.6"
]
},
{
"recordType": "A",
"recordSetName": "abc2",
"fqdn": "abc2.zone2.com",
"ipAddresses": [
"10.0.0.7"
]
}
]
}
}
]
}
}
}
}
}
80 changes: 80 additions & 0 deletions ...manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointDnsZoneGroupList.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@
{
"parameters": {
"api-version": "2020-03-01",
"subscriptionId": "subId",
"resourceGroupName": "rg1",
"privateEndpointName": "testPe"
},
"responses": {
"200": {
"body": {
"value": [
{
"name": "testPdnsgroup1",
"id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateLinkServices/testPe/privateDnsZoneGroups/testPdnsgroup1",
"properties": {
"provisioningState": "Succeeded",
"privateDnsZoneConfigs": [
{
"properties": {
"privateDnsZoneId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateDnsZones/zone1.com",
"recordSets": [
{
"recordType": "A",
"recordSetName": "abc",
"fqdn": "abc.zone1.com",
"ipAddresses": [
"10.0.0.4"
]
},
{
"recordType": "A",
"recordSetName": "abc2",
"fqdn": "abc2.zone1.com",
"ipAddresses": [
"10.0.0.5"
]
}
]
}
}
]
}
},
{
"name": "testPdnsgroup2",
"id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateLinkServices/testPe/privateDnsZoneGroups/testPdnsgroup2",
"properties": {
"provisioningState": "Succeeded",
"privateDnsZoneConfigs": [
{
"properties": {
"privateDnsZoneId": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateDnsZones/zone2.com",
"recordSets": [
{
"recordType": "A",
"recordSetName": "abc3",
"fqdn": "abc3.zone2.com",
"ipAddresses": [
"10.0.0.6"
]
},
{
"recordType": "A",
"recordSetName": "abc4",
"fqdn": "abc4.zone2.com",
"ipAddresses": [
"10.0.0.7"
]
}
]
}
}
]
}
}
]
}
}
}
}
14 changes: 14 additions & 0 deletions ...ork/resource-manager/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointGet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,20 @@
{
"id": "/subscriptions/subId/resourceGroups/rg1/provders/Microsoft.Network/networkInterfaces/testPe.nic.abcd1234"
}
],
"customDnsConfigs": [
{
"fqdn": "abc.cosmos.com",
"ipAddresses": [
"192.168.0.4"
]
},
{
"fqdn": "abc2.cosmos.com",
"ipAddresses": [
"192.168.0.5"
]
}
]
}
}
Expand Down
14 changes: 14 additions & 0 deletions ...ger/Microsoft.Network/stable/2020-03-01/examples/PrivateEndpointGetForManualApproval.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,20 @@
{
"id": "/subscriptions/subId/resourceGroups/rg1/provders/Microsoft.Network/networkInterfaces/testPe.nic.abcd1234"
}
],
"customDnsConfigs": [
{
"fqdn": "abc.cosmos.com",
"ipAddresses": [
"192.168.0.4"
]
},
{
"fqdn": "abc2.cosmos.com",
"ipAddresses": [
"192.168.0.5"
]
}
]
}
}
Expand Down
Loading