Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure Stack] Updates to Azs.Update.Admin spec #8899

Merged
merged 2 commits into from
Apr 7, 2020
Merged

[Azure Stack] Updates to Azs.Update.Admin spec #8899

merged 2 commits into from
Apr 7, 2020

Conversation

viananth
Copy link
Member

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@viananth
commit fbe7670
84b0ccf 
Author: bganapa <bganapa@microsoft.com>
Date:   Tue Mar 10 14:06:55 2020 -0700

    Update resourceGroups casing

commit 848e5f7
Author: bganapa <bganapa@microsoft.com>
Date:   Tue Mar 10 14:05:10 2020 -0700

    Update resourcegroups casing to resourceGroups

commit 591ff3c
Author: bganapa <bganapa@microsoft.com>
Date:   Tue Mar 10 13:58:14 2020 -0700

    Update Updates.json

    commit 9e551f0
Author: bganapa <bganapa@microsoft.com>                                                Date:   Tue Nov 12 11:44:22 2019 -0800                                                                                                                                            Reset to Stackadmin2 (Azure#7766)
@viananth viananth requested a review from bganapa March 31, 2020 21:41
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 31, 2020 •
edited
Loading

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 31, 2020 •
edited
Loading

azure-cli-extensions - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 31, 2020 •
edited
Loading

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 31, 2020 •
edited
Loading

azure-sdk-for-go - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 31, 2020 •
edited
Loading

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Mar 31, 2020 •
edited
Loading

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@raych1 raych1 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 1, 2020
@raych1
Copy link
Member

raych1 commented Apr 1, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 2, 2020
majastrz
majastrz approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed off from ARM side.

bganapa
bganapa requested changes Apr 3, 2020
View reviewed changes
Copy link
Member

@bganapa bganapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@raych1
Copy link
Member

raych1 commented Apr 7, 2020

@akning-ms, please force merge this PR since the case change on path is not a real breaking change. Add @jianyexi , we need to compare path case-insensitively in OAD tool.

@akning-ms akning-ms merged commit 7403364 into Azure:master Apr 7, 2020
@viananth viananth deleted the azs/update branch April 7, 2020 18:01
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
@viananth @00Kai0
[Azure Stack] Updates to Azs.Update.Admin spec (Azure#8899)
c72c85d 
* commit fbe7670
Author: bganapa <bganapa@microsoft.com>
Date:   Tue Mar 10 14:06:55 2020 -0700

    Update resourceGroups casing

commit 848e5f7
Author: bganapa <bganapa@microsoft.com>
Date:   Tue Mar 10 14:05:10 2020 -0700

    Update resourcegroups casing to resourceGroups

commit 591ff3c
Author: bganapa <bganapa@microsoft.com>
Date:   Tue Mar 10 13:58:14 2020 -0700

    Update Updates.json

    commit 9e551f0
Author: bganapa <bganapa@microsoft.com>                                                Date:   Tue Nov 12 11:44:22 2019 -0800                                                                                                                                            Reset to Stackadmin2 (Azure#7766)

* Address PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bganapa bganapa bganapa approved these changes

@raych1 raych1 raych1 approved these changes

@majastrz majastrz majastrz approved these changes

Assignees

@raych1 raych1

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@viananth @azuresdkci @raych1 @bganapa @majastrz @akning-ms