[Azure Stack] Updates to User-Subscriptions Spec #8914

viananth · 2020-04-01T18:38:58Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Author: Rakesh Kumar <rakku@microsoft.com> Date: Wed Jan 29 17:46:01 2020 -0800 [AzureStack] User Subscription: rename NewSubscription to SubscriptionDefinition (Azure#8257) commit 9e551f0 Author: bganapa <bganapa@microsoft.com> Date: Tue Nov 12 11:44:22 2019 -0800 Reset to Stackadmin2 (Azure#7766)

azure-pipelines · 2020-04-01T18:39:15Z

Azure Pipelines successfully started running 1 pipeline(s).

azuresdkci · 2020-04-01T18:40:45Z

Can one of the admins verify this patch?

openapi-sdkautomation · 2020-04-01T19:10:23Z

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-04-01T19:10:24Z

azure-sdk-for-go - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-04-01T19:10:25Z

azure-cli-extensions

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-04-01T19:10:29Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-04-01T19:11:01Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-04-01T19:11:36Z

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

njuCZ · 2020-04-02T01:51:47Z

@viananth please fix the CI error

specification/azsadmin/resource-manager/user-subscriptions/readme.md

specification/azsadmin/resource-manager/user-subscriptions/readme.azsautogen.md

viananth · 2020-04-06T19:32:12Z

@viananth please fix the CI error

@njuCZ CI is reporting this as an error, but there are no errors in example validation:
https://dev.azure.com/azure-sdk/public/_build/results?buildId=340779&view=logs&j=8d2f9c49-cd83-5a9d-f3fe-2fd651afa742&t=43324f1f-6724-5d61-785f-f0ac9fd256a1&l=28

azure-pipelines · 2020-04-06T19:33:36Z

Azure Pipelines successfully started running 1 pipeline(s).

viananth · 2020-04-14T16:59:35Z

@njuCZ I reviewed the breaking changes and they are expected. Could you please take a look and let me know if you have any feedback?

viananth · 2020-05-12T18:09:52Z

@njuCZ could you pls approve this PR if it looks good to you? @bganapa as FYI

njuCZ · 2020-07-07T10:23:17Z

@viananth Sorry for missing this thread. According to our latest policy: Per Retirement of Preview guidance, products in Preview for over one year need to move to GA or retire; require CVP exemption after 1 year in preview

viananth · 2020-07-07T15:13:25Z

@bganapa FYI

bganapa · 2020-08-06T17:25:43Z

@njuCZ This is another Azure Stack Admin API swagger spec where we are planning to move all our specs to stable in Fe timeframe. Could you please approve this PR and proceed to merge. Thank you!

njuCZ · 2020-08-07T02:13:09Z

/azp run

azure-pipelines · 2020-08-07T02:13:28Z

Azure Pipelines successfully started running 3 pipeline(s).

openapi-sdkautomation · 2020-08-07T02:14:49Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-07T02:14:49Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-08-07T02:14:51Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

viananth · 2020-08-11T19:27:06Z

/azp run

azure-pipelines · 2020-08-11T19:27:25Z

Azure Pipelines successfully started running 3 pipeline(s).

openapi-pipeline-app · 2020-08-11T19:46:59Z

[Staging] Swagger Validation Report

️❌BreakingChange: 3 Errors, 0 Warnings [Detail] [Expand]

Rule	Message
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'NewSubscriptionParameter' removed or renamed? New: Microsoft.Subscriptions/preview/2015-11-01/Subscriptions.json#L249:3 Old: Microsoft.Subscriptions/preview/2015-11-01/Subscriptions.json#L249:3
`❌` 1009 - RemovedRequiredParameter	The required parameter 'newSubscription' was removed in the new version. Old: Microsoft.Subscriptions/preview/2015-11-01/Subscriptions.json#L89:9
`❌` 1010 - AddingRequiredParameter	The required parameter 'subscriptionDefinition' was added in the new version. New: Microsoft.Subscriptions/preview/2015-11-01/Subscriptions.json#L89:9

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2020-08-11T19:47:12Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-11T19:58:40Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-08-13T06:00:32Z

azure-resource-manager-schemas - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

* commit 4691c2a Author: Rakesh Kumar <rakku@microsoft.com> Date: Wed Jan 29 17:46:01 2020 -0800 [AzureStack] User Subscription: rename NewSubscription to SubscriptionDefinition (Azure#8257) commit 9e551f0 Author: bganapa <bganapa@microsoft.com> Date: Tue Nov 12 11:44:22 2019 -0800 Reset to Stackadmin2 (Azure#7766) * Fix sub def in example * Address PR comments * Fix model validation error * Fix prettier issue

viananth added 2 commits March 31, 2020 12:03

Fix sub def in example

626b9a2

viananth requested a review from bganapa April 1, 2020 18:38

openapi-assignment-bot bot assigned njuCZ Apr 1, 2020

bganapa reviewed Apr 3, 2020

View reviewed changes

specification/azsadmin/resource-manager/user-subscriptions/readme.md Show resolved Hide resolved

bganapa reviewed Apr 3, 2020

View reviewed changes

specification/azsadmin/resource-manager/user-subscriptions/readme.azsautogen.md Outdated Show resolved Hide resolved

Address PR comments

54db583

bganapa approved these changes Apr 6, 2020

View reviewed changes

njuCZ added the BreakingChangeReviewRequired label Jul 7, 2020

njuCZ added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 and removed BreakingChangeReviewRequired labels Aug 7, 2020

njuCZ approved these changes Aug 7, 2020

View reviewed changes

Fix model validation error

c4fb7e0

Fix prettier issue

64c1f5d

njuCZ merged commit 1b430eb into Azure:master Aug 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Azure Stack] Updates to User-Subscriptions Spec #8914

[Azure Stack] Updates to User-Subscriptions Spec #8914

viananth commented Apr 1, 2020

azure-pipelines bot commented Apr 1, 2020

azuresdkci commented Apr 1, 2020

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading

njuCZ commented Apr 2, 2020

viananth commented Apr 6, 2020

azure-pipelines bot commented Apr 6, 2020

viananth commented Apr 14, 2020

viananth commented May 12, 2020

njuCZ commented Jul 7, 2020

viananth commented Jul 7, 2020

bganapa commented Aug 6, 2020

njuCZ commented Aug 7, 2020

azure-pipelines bot commented Aug 7, 2020

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading

viananth commented Aug 11, 2020

azure-pipelines bot commented Aug 11, 2020

openapi-pipeline-app bot commented Aug 11, 2020 •

edited

Loading

azure-pipelines bot commented Aug 11, 2020

azure-pipelines bot commented Aug 11, 2020

openapi-sdkautomation bot commented Aug 13, 2020 •

edited

Loading

[Azure Stack] Updates to User-Subscriptions Spec #8914

[Azure Stack] Updates to User-Subscriptions Spec #8914

Conversation

viananth commented Apr 1, 2020

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azure-pipelines bot commented Apr 1, 2020

azuresdkci commented Apr 1, 2020

openapi-sdkautomation bot commented Apr 1, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Apr 1, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Apr 1, 2020 • edited Loading

azure-cli-extensions

openapi-sdkautomation bot commented Apr 1, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Apr 1, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Apr 1, 2020 • edited Loading

azure-sdk-for-python - Release

njuCZ commented Apr 2, 2020

viananth commented Apr 6, 2020

azure-pipelines bot commented Apr 6, 2020

viananth commented Apr 14, 2020

viananth commented May 12, 2020

njuCZ commented Jul 7, 2020

viananth commented Jul 7, 2020

bganapa commented Aug 6, 2020

njuCZ commented Aug 7, 2020

azure-pipelines bot commented Aug 7, 2020

openapi-sdkautomation bot commented Aug 7, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented Aug 7, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

openapi-sdkautomation bot commented Aug 7, 2020 • edited Loading

Trenton Generation - Release

viananth commented Aug 11, 2020

azure-pipelines bot commented Aug 11, 2020

openapi-pipeline-app bot commented Aug 11, 2020 • edited Loading

[Staging] Swagger Validation Report

azure-pipelines bot commented Aug 11, 2020

azure-pipelines bot commented Aug 11, 2020

openapi-sdkautomation bot commented Aug 13, 2020 • edited Loading

azure-resource-manager-schemas - Release

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 1, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 7, 2020 •

edited

Loading

openapi-pipeline-app bot commented Aug 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 13, 2020 •

edited

Loading