[Azure Stack] Updates to Azs.Fabric.Admin spec for autorest config #9030

viananth · 2020-04-13T17:58:19Z

commit 6ecda64
Author: Yuxing Zhou zyx.pulsars@gmail.com
Date: Sat Jan 4 02:25:35 2020 +0800

[Azure Stack] Update fabric storage admin specs for new generation with autorest-beta (#8038)
commit 9e551f0eab4057d4c2f54c333c7aa2a1a564c125                                                                         Author: bganapa <bganapa@microsoft.com>                                                     Date:   Tue Nov 12 11:44:22 2019 -0800                                         Reset to Stackadmin2 (#7766)

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

commit 6ecda64 Author: Yuxing Zhou <zyx.pulsars@gmail.com> Date: Sat Jan 4 02:25:35 2020 +0800 [Azure Stack] Update fabric storage admin specs for new generation with autorest-beta (Azure#8038) commit 9e551f0 Author: bganapa <bganapa@microsoft.com> Date: Tue Nov 12 11:44:22 2019 -0800 Reset to Stackadmin2 (Azure#7766)

azure-pipelines · 2020-04-13T17:58:36Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-04-13T18:00:00Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-04-13T18:00:00Z

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-04-13T18:00:02Z

azure-cli-extensions

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-04-13T18:00:02Z

azure-sdk-for-go - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-04-13T18:00:10Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-04-13T18:00:15Z

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azuresdkci · 2020-04-13T18:08:32Z

Can one of the admins verify this patch?

...dmin/resource-manager/fabric/Microsoft.Fabric.Admin/preview/2018-10-01/StorageSubSystem.json

viananth · 2020-04-16T18:50:27Z

Can one of the admins verify this patch?

@zikalino Could you please approve this PR if it looks good to you? Thanks!

viananth · 2020-05-12T18:17:19Z

@zikalino Could you please merge this PR? @bganapa as FYI

zikalino · 2020-05-20T20:20:48Z

...dmin/resource-manager/fabric/Microsoft.Fabric.Admin/preview/2018-10-01/StorageSubSystem.json

+            "$ref": "../2016-05-01/Fabric.json#/parameters/TopParameter"
+          },
+          {
+            "$ref": "../2016-05-01/Fabric.json#/parameters/SkipParameter"


referring files from different api version may be a bit dangerous and have some unexpected consequences.
i think it would be better to move these common definitions to a separate common.json file.
I see that it was done before, but maybe it's a good time to fix it?

agree, @viananth lets make a copy

zikalino

everything else looks fine for me, pls move params to common

azure-pipelines · 2020-05-26T05:41:37Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-05-26T05:42:52Z

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-05-26T05:42:53Z

azure-sdk-for-trenton

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-05-26T05:58:02Z

Azure Pipelines successfully started running 1 pipeline(s).

viananth · 2020-05-26T06:15:02Z

everything else looks fine for me, pls move params to common

@zikalino I have made the changes requested. Please take a look and let me know if it looks good. Thanks!

specification/azsadmin/resource-manager/fabric/readme.azsautogen.md

mmyyrroonn · 2020-07-29T01:42:29Z

/azp run

openapi-sdkautomation · 2020-07-29T01:43:59Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-07-29T01:44:04Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

mmyyrroonn · 2020-07-29T08:26:02Z

/azp run

azure-pipelines · 2020-07-29T08:26:21Z

Azure Pipelines successfully started running 3 pipeline(s).

zhenglaizhang · 2020-07-29T08:32:21Z

/openapi pipeline

openapi-sdkautomation · 2020-07-29T08:32:23Z

/openapi pipeline

Unrecognized OpenAPI bot command (pipeline).
Try sdkautomation instead.

openapi-pipeline-app · 2020-07-29T08:32:24Z

[Staging] Swagger Validation Report

️️✔️BreakingChange [Detail]

 There are no breaking changes.

️️✔️LintDiff [Detail]

 Validation passes for LintDiff.

️️✔️Avocado [Detail]

 Validation passes for Avocado.

️️✔️ModelValidation [Detail]

 Validation passes for ModelValidation.

️️✔️SemanticValidation [Detail]

 Validation passes for SemanticValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

mmyyrroonn · 2020-07-29T09:28:26Z

@viananth Hi. @zikalino has joined a new team and cannot review this PR. I will help you merge this PR. According to our guideline, since you removed some paths, we need breaking change review. Could you share more context about why you removing these paths? You can check our review process and send a review request through this link

viananth · 2020-07-29T19:15:45Z

@viananth Hi. @zikalino has joined a new team and cannot review this PR. I will help you merge this PR. According to our guideline, since you removed some paths, we need breaking change review. Could you share more context about why you removing these paths? You can check our review process and send a review request through this link

@bganapa @rakku-ms Could you pls respond to the above question as you have more context?

bganapa · 2020-07-29T19:34:38Z

@viananth I think you are inadvertently removing the nascluster related files. Could you please add it back?

viananth · 2020-07-29T22:15:46Z

Yes, looks like this commit was not backported in the PR: 3869a21#diff-68f3346e8107cf1e1ec3a5b93d33ffc3
I will rebase this branch.

mmyyrroonn · 2020-08-03T05:09:42Z

@viananth These APIs are still deleted. If that's not on purpose, we can bring them back and we can go on the review process.

azure-pipelines · 2020-08-03T18:57:31Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-08-03T19:07:51Z

Azure Pipelines successfully started running 1 pipeline(s).

viananth · 2020-08-03T19:09:20Z

@myronfanqiu I have ported the deleted files back. Apologies for the issue. Please merge the PR if it looks good to you. Thanks!

mmyyrroonn · 2020-08-04T01:48:20Z

specification/azsadmin/resource-manager/fabric/readme.md

@@ -147,54 +146,3 @@ csharp:
  output-folder: $(csharp-sdks-folder)/Generated
  clear-output-folder: true
 ```
-


Hi, why do we remove this part? Should we bring it back too?

This part is added in readme.azsautogen.md for autorest generation config.

I think this one is used for autorest v3?

mmyyrroonn · 2020-08-04T01:49:02Z

@zikalino Could you take a look at this PR and approve it?

mmyyrroonn

I think we should revert the deletion in readme.md file.

mmyyrroonn · 2020-08-28T02:28:06Z

@viananth Hi. Could you take a look at my comment and revert the change?

azure-pipelines · 2020-08-31T05:34:39Z

Azure Pipelines successfully started running 1 pipeline(s).

viananth · 2020-08-31T05:35:17Z

@viananth Hi. Could you take a look at my comment and revert the change?

@myronfanqiu I have reverted readme.md changes. Please merge the PR. Thanks!

openapi-sdkautomation · 2020-08-31T05:36:05Z

azure-resource-manager-schemas - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

bganapa · 2020-08-31T22:25:05Z

@myronfanqiu please merge it

mmyyrroonn · 2020-09-01T05:30:12Z

@akning-ms Hi. Could you help us merge this PR since @zikalino has moved to other team.

viananth requested a review from bganapa April 13, 2020 17:58

openapi-assignment-bot bot assigned zikalino Apr 13, 2020

bganapa approved these changes Apr 13, 2020

View reviewed changes

bganapa reviewed Apr 13, 2020

View reviewed changes

...dmin/resource-manager/fabric/Microsoft.Fabric.Admin/preview/2018-10-01/StorageSubSystem.json Show resolved Hide resolved

zikalino reviewed May 20, 2020

View reviewed changes

zikalino suggested changes May 20, 2020

View reviewed changes

Address PR comments

da932d4

Fix semantic issue

efb3311

viananth requested a review from zikalino May 27, 2020 05:30

akning-ms assigned mmyyrroonn Jul 24, 2020

akning-ms reviewed Jul 24, 2020

View reviewed changes

specification/azsadmin/resource-manager/fabric/readme.azsautogen.md Show resolved Hide resolved

akning-ms unassigned zikalino Jul 24, 2020

mmyyrroonn added the BreakingChangeReviewRequired label Jul 29, 2020

Reset NasCluster files to master

c5d6dc0

Add nascluster changes

afb9047

mmyyrroonn reviewed Aug 4, 2020

View reviewed changes

mmyyrroonn approved these changes Aug 20, 2020

View reviewed changes

Revert readme.md changes

9ecb90c

mmyyrroonn approved these changes Aug 31, 2020

View reviewed changes

bganapa approved these changes Aug 31, 2020

View reviewed changes

akning-ms merged commit 25acd0f into Azure:master Sep 4, 2020

[Azure Stack] Updates to Azs.Fabric.Admin spec for autorest config #9030

[Azure Stack] Updates to Azs.Fabric.Admin spec for autorest config #9030

Conversation

viananth commented Apr 13, 2020

Latest improvements:

Contribution checklist:

ARM API Review Checklist

azure-pipelines bot commented Apr 13, 2020

openapi-sdkautomation bot commented Apr 13, 2020 • edited Loading

azure-sdk-for-java - Release

openapi-sdkautomation bot commented Apr 13, 2020 • edited Loading

azure-sdk-for-js - Release

openapi-sdkautomation bot commented Apr 13, 2020 • edited Loading

azure-cli-extensions

openapi-sdkautomation bot commented Apr 13, 2020 • edited Loading

azure-sdk-for-go - Release

openapi-sdkautomation bot commented Apr 13, 2020 • edited Loading

azure-sdk-for-net - Release

openapi-sdkautomation bot commented Apr 13, 2020 • edited Loading

azure-sdk-for-python - Release

azuresdkci commented Apr 13, 2020

viananth commented Apr 16, 2020

viananth commented May 12, 2020

zikalino May 20, 2020

Choose a reason for hiding this comment

bganapa May 20, 2020

Choose a reason for hiding this comment

zikalino left a comment

Choose a reason for hiding this comment

azure-pipelines bot commented May 26, 2020

openapi-sdkautomation bot commented May 26, 2020 • edited Loading

Azure CLI Extension Generation - Release

openapi-sdkautomation bot commented May 26, 2020 • edited Loading

azure-sdk-for-trenton

azure-pipelines bot commented May 26, 2020

viananth commented May 26, 2020

mmyyrroonn commented Jul 29, 2020

openapi-sdkautomation bot commented Jul 29, 2020 • edited Loading

Trenton Generation - Release

openapi-sdkautomation bot commented Jul 29, 2020 • edited Loading

azure-sdk-for-python-track2 - Release

mmyyrroonn commented Jul 29, 2020

azure-pipelines bot commented Jul 29, 2020

zhenglaizhang commented Jul 29, 2020

openapi-sdkautomation bot commented Jul 29, 2020

openapi-pipeline-app bot commented Jul 29, 2020 • edited Loading

[Staging] Swagger Validation Report

mmyyrroonn commented Jul 29, 2020

viananth commented Jul 29, 2020

bganapa commented Jul 29, 2020

viananth commented Jul 29, 2020

mmyyrroonn commented Aug 3, 2020

azure-pipelines bot commented Aug 3, 2020

azure-pipelines bot commented Aug 3, 2020

viananth commented Aug 3, 2020

mmyyrroonn Aug 4, 2020

Choose a reason for hiding this comment

viananth Aug 11, 2020

Choose a reason for hiding this comment

mmyyrroonn Aug 20, 2020

Choose a reason for hiding this comment

mmyyrroonn commented Aug 4, 2020

mmyyrroonn left a comment

Choose a reason for hiding this comment

mmyyrroonn commented Aug 28, 2020

azure-pipelines bot commented Aug 31, 2020

viananth commented Aug 31, 2020

openapi-sdkautomation bot commented Aug 31, 2020 • edited Loading

azure-resource-manager-schemas - Release

bganapa commented Aug 31, 2020

mmyyrroonn commented Sep 1, 2020

openapi-sdkautomation bot commented Apr 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented Apr 13, 2020 •

edited

Loading

openapi-sdkautomation bot commented May 26, 2020 •

edited

Loading

openapi-sdkautomation bot commented May 26, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 29, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jul 29, 2020 •

edited

Loading

openapi-pipeline-app bot commented Jul 29, 2020 •

edited

Loading

openapi-sdkautomation bot commented Aug 31, 2020 •

edited

Loading