-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi-cloud connector in azure security center #9429
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aymanjarrousms - few comments
...tion/security/resource-manager/Microsoft.Security/preview/2020-01-01-preview/connectors.json
Show resolved
Hide resolved
...tion/security/resource-manager/Microsoft.Security/preview/2020-01-01-preview/connectors.json
Show resolved
Hide resolved
...tion/security/resource-manager/Microsoft.Security/preview/2020-01-01-preview/connectors.json
Show resolved
Hide resolved
ravbhatnagar
added
the
ARMChangesRequested
<valid label in PR review process>add this label when require changes after ARM review
label
Jun 22, 2020
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
signing off from ARM side. generic connector will be explored later. Details in email. |
ravbhatnagar
added
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
and removed
ARMChangesRequested
<valid label in PR review process>add this label when require changes after ARM review
WaitForARMFeedback
<valid label in PR review process> add this label when ARM review is required
DoNotMerge
<valid label in PR review process> use to hold merge after approval
labels
Jun 25, 2020
zikalino
approved these changes
Jun 26, 2020
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* aws connector in asc including API and examples - draft 1 * adding 'state' to the connector * when deleting aws connector that is not exist, return 404 * Updating connector is in put * aws connector status updated to enum * deleting post option in aws connector * aws connector adding state to the example files * adding description to aws connector * Renaming awsConnectors to connectors * renaming example files to connector without aws * aws dropped from the connector and adding connector type * update examples of connector based in the new schema * adding proxy to arc onboarding * updating example files * fixing typo * fixing arc to hybridComputeAutoProvision * update connectors.json (#1) * fixing file structure * updating examples * fixing connectorType to authenticationType * adding another block of properites * making two parts in the connector settings * updating required fields * Adding permission list * fixing error * changing name object * fixing permission name * adding all service principal fields * update documentation of app serivce secret * creating examples * location changed to region * create example changed to createupdate * moving account id insode the connection object * remove name fields in hybrid compute * Adding base for aws onboarding * two put and update examples * fixing examples based new body * fixing connector name * fixing aws connctor example * fixing readme and link to example file * adding correct example file * fixin example extension * fixing discriminator * provisioningState is required prop * fixing link in readme file * fixing typo in connectorName * fixing provisioningState * fixin authenticationType to authenticationType * removing readonly fields from examples * fixing credential fields * remove id from create * run Prettier on the files * running prettier * create two different x-ms-enum * update examples of connectors * update readme file * removing custom from secure score * fifixng enum permission prop * fixing extra space in readme * Adding gcp connector * adding gcp example * update example of get list * fixing name * running prettier * fixing errors of build * removing null values from examples * taking secureScore.json new file * all secret fields marked as format password * remove required fields * Adding relavent required fields * remove password format * writeonly fields are returned with <empty> value * fixing gcp connector fields * fixing delete response * fiximng examples to return empty string on writeonly fields * fixing delete response in the example * change structure of authentication * fixing inheretence in aws * fixing structure of cred in aws and gcp * write only fields are empty strings in the response of the examples * after Prettier check * clarifing the documentation of two fields * fixing documentation of region field in hybrid compute. Co-authored-by: Ayman Jarrous <ayjarrou@microsoft.com> Co-authored-by: adzamri <49613774+adzamri@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.