Users/kegangum/fix errors #9511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' endpoints and corrected Product Package Secrets endpoint
|
You don't have permission to trigger SDK Automation. |
|
Can one of the admins verify this patch? |
|
The result from LintDiff is wrong as RP name is already in PascalCase . Breaking Change can be ignoreed. |
openapi-assignment-bot
bot
added
the
WaitForARMFeedback
|
@njuCZ Could you please review this PR? |
bganapa
reviewed
May 20, 2020
...resource-manager/deployment/Microsoft.Deployment.Admin/preview/2018-07-01/FileContainer.json
Outdated
Show resolved
Hide resolved
bganapa
reviewed
May 20, 2020
.../deployment/Microsoft.Deployment.Admin/preview/2018-07-01/examples/FileContainer/Delete.json
Outdated
Show resolved
Hide resolved
bganapa
reviewed
May 20, 2020
...resource-manager/deployment/Microsoft.Deployment.Admin/preview/2019-01-01/ProductSecret.json
Show resolved
Hide resolved
bganapa
approved these changes
May 20, 2020
KrisBash
approved these changes
May 26, 2020
KrisBash
added
ARMSignedOff
[Staging] Swagger Validation Report
Only 10 items are listed, please refer to log for more details.
❌ |
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Deployment.Admin/locations/global/productDeployments/{productId}/unlock' removed or restructured? Old: Microsoft.Deployment.Admin/preview/2019-01-01/ProductDeployment.json#L230:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Deployment.Admin/locations/global/productSecrets/{productId}/secrets/{secretName}/import' removed or restructured? Old: Microsoft.Deployment.Admin/preview/2019-01-01/ProductSecret.json#L100:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Deployment.Admin/locations/global/productSecrets/{productId}/secrets/{secretName}/validate' removed or restructured? Old: Microsoft.Deployment.Admin/preview/2019-01-01/ProductSecret.json#L146:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Deployment.Admin/locations/global/productDeployments/{productId}/lock' removed or restructured? Old: Microsoft.Deployment.Admin/preview/2019-01-01/ProductDeployment.json#L263:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Deployment.Admin/locations/global/productSecrets/{productId}/secrets/{secretName}' removed or restructured? Old: Microsoft.Deployment.Admin/preview/2019-01-01/ProductSecret.json#L55:5 |
|
The new version is missing a definition that was found in the old version. Was 'SecretValue' removed or renamed? New: Microsoft.Deployment.Admin/preview/2019-01-01/ProductSecret.json#L208:3 Old: Microsoft.Deployment.Admin/preview/2019-01-01/ProductSecret.json#L193:3 |
|
The new version is missing a definition that was found in the old version. Was 'UnlockActionParameters' removed or renamed? New: Microsoft.Deployment.Admin/preview/2019-01-01/ProductDeployment.json#L310:3 Old: Microsoft.Deployment.Admin/preview/2019-01-01/ProductDeployment.json#L294:3 |
|
The new version is missing a definition that was found in the old version. Was 'PfxPassword' removed or renamed? New: Microsoft.Deployment.Admin/preview/2019-01-01/ProductSecret.json#L208:3 Old: Microsoft.Deployment.Admin/preview/2019-01-01/ProductSecret.json#L193:3 |
|
The new version is missing a definition that was found in the old version. Was 'PfxFileName' removed or renamed? New: Microsoft.Deployment.Admin/preview/2019-01-01/ProductSecret.json#L208:3 Old: Microsoft.Deployment.Admin/preview/2019-01-01/ProductSecret.json#L193:3 |
|
The new version is missing a definition that was found in the old version. Was 'Password' removed or renamed? New: Microsoft.Deployment.Admin/preview/2019-01-01/ProductSecret.json#L208:3 Old: Microsoft.Deployment.Admin/preview/2019-01-01/ProductSecret.json#L193:3 |
️❌LintDiff: 7 Errors, 10 Warnings [Detail] [Expand]
Only 10 items are listed, please refer to log for more details.
❌| Rule | Message |
|---|---|
|
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Deployment.Admin/locations/global/productPackages/{packageId}' New: Microsoft.Deployment.Admin/preview/2018-07-01/ProductPackage.json#L18 |
|
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Deployment.Admin/locations/global/productPackages/{packageId}/secrets/{secretName}/validate' New: Microsoft.Deployment.Admin/preview/2019-01-01/ProductSecret.json#L12 |
|
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Deployment.Admin/locations/global/productDeployments/{productId}/executeRunner' New: Microsoft.Deployment.Admin/preview/2019-01-01/ProductDeployment.json#L18 |
|
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Deployment.Admin/locations/global/productPackages/{packageId}' New: Microsoft.Deployment.Admin/preview/2019-01-01/ProductPackage.json#L18 |
|
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Deployment.Admin/locations/global/productPackages/{packageId}/secrets' New: Microsoft.Deployment.Admin/preview/2019-01-01/ProductSecret.json#L12 |
|
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Deployment.Admin/locations/global/productPackages/{packageId}/secrets/{secretName}' New: Microsoft.Deployment.Admin/preview/2019-01-01/ProductSecret.json#L12 |
|
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Deployment.Admin/locations/global/productPackages/{packageId}/secrets/{secretName}/import' New: Microsoft.Deployment.Admin/preview/2019-01-01/ProductSecret.json#L12 |
| Consider using x-ms-client-flatten to provide a better end user experience New: Microsoft.Deployment.Admin/preview/2018-07-01/FileContainer.json#L282 |
|
| Consider using x-ms-client-flatten to provide a better end user experience New: Microsoft.Deployment.Admin/preview/2018-07-01/ProductPackage.json#L308 |
|
| Consider using x-ms-client-flatten to provide a better end user experience New: Microsoft.Deployment.Admin/preview/2019-01-01/FileContainer.json#L282 |
️️✔️Avocado [Detail]
️✔️Validation passes for Avocado.
bganapa
reviewed
Jun 4, 2020
...loyment/Microsoft.Deployment.Admin/preview/2019-01-01/examples/ProductDeployment/Remove.json
Outdated
Show resolved
Hide resolved
bganapa
reviewed
Jun 4, 2020
bganapa
reviewed
Jun 6, 2020
...r/deployment/Microsoft.Deployment.Admin/preview/2018-07-01/examples/ProductPackage/List.json
Outdated
Show resolved
Hide resolved
bganapa
reviewed
Jun 6, 2020
...ce-manager/deployment/Microsoft.Deployment.Admin/preview/2019-01-01/ActionPlanOperation.json
Outdated
Show resolved
Hide resolved
|
Azure Pipelines successfully started running 3 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
akning-ms
approved these changes
Jul 21, 2020
Users/kegangum/autorest
added locations endpoint and fixed other changes added actionplans to custom-words.txt and uodated ProductSecret.json updated locations endpoint response
added 404 and default responses added locations endpoint - list operation removed 404 response for the 'ProductDeployment-remove operation' Adding 'productDeployments/executeRunner/action'' removed 404 responses added default error responses and deleted 404 responses for file containers removed older version in the read.md 'input-file' section changed details info in the "ExtendedErrorInfo" changed ExtendedErrorInfo object updating error definition changing error definition in 2018-07-01 version updated location responses changed the entity name Revert "changed the entity name" This reverts commit 2c7e079. Revert "updated location responses" This reverts commit 78bca1d. updated locations Get response change for New-AzFileContainer command added Parameter for the New-AzsProductPackage changed productId to packageId updated operationId for Bootstrap changed operationId for deploy action changed paramters to object changed the operation Ids changed operationIds for the right command names execute runner changes fixed path parameter for secrets and remove command name changed the secret name changed secret parameters added changes to resolve conflicts changed version number changed the version number changed the tag name to fix conflicts
…m/azure-rest-api-specs into users/kegangum/fixErrors
|
Hi @kegangum, The Linter failure for PathResourceProviderNamePascalCase can be ignored as it is due to Microsoft.Deployment.Admin has 2 dot which is not like others we are not support it in tool. |
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
* added swagger for 'actionplan/operation/attempts' , 'operationresults' endpoints and corrected Product Package Secrets endpoint * updated the pfx file name type * fix LintDiff erros * added locations endpoint and fixed other changes * added actionplans to custom-words.txt and uodated ProductSecret.json * updated locations endpoint response * updated the location parameter to global * added 404 and default responses * added locations endpoint - list operation * removed 404 response for the 'ProductDeployment-remove operation' * Adding 'productDeployments/executeRunner/action'' * removed 404 responses * added default error responses and deleted 404 responses for file containers * removed older version in the read.md 'input-file' section * changed details info in the "ExtendedErrorInfo" * changed ExtendedErrorInfo object * updating error definition * changing error definition in 2018-07-01 version * updated location responses * changed the entity name * Revert "changed the entity name" This reverts commit 2c7e079. * Revert "updated location responses" This reverts commit 78bca1d. * updated locations Get response * change for New-AzFileContainer command * added Parameter for the New-AzsProductPackage * changed productId to packageId * updated operationId for Bootstrap * changed operationId for deploy action * changed paramters to object * changed the operation Ids * changed operationIds for the right command names * execute runner changes * fixed path parameter for secrets and remove command name * changed the secret name * changed secret parameters * added changes to resolve conflicts * changed version number * changed the version number * changed the tag name * to fix conflicts * added swagger for missing endpoints of the Deployment Resource Provider fixed CI failures * fix LintDiff erros added locations endpoint and fixed other changes added actionplans to custom-words.txt and uodated ProductSecret.json updated locations endpoint response * updated the location parameter to global added 404 and default responses added locations endpoint - list operation removed 404 response for the 'ProductDeployment-remove operation' Adding 'productDeployments/executeRunner/action'' removed 404 responses added default error responses and deleted 404 responses for file containers removed older version in the read.md 'input-file' section changed details info in the "ExtendedErrorInfo" changed ExtendedErrorInfo object updating error definition changing error definition in 2018-07-01 version updated location responses changed the entity name Revert "changed the entity name" This reverts commit 2c7e079. Revert "updated location responses" This reverts commit 78bca1d. updated locations Get response change for New-AzFileContainer command added Parameter for the New-AzsProductPackage changed productId to packageId updated operationId for Bootstrap changed operationId for deploy action changed paramters to object changed the operation Ids changed operationIds for the right command names execute runner changes fixed path parameter for secrets and remove command name changed the secret name changed secret parameters added changes to resolve conflicts changed version number changed the version number changed the tag name to fix conflicts * added 204 responses for delete operation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.