-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.Insights to add version stable/2018-03-01 #9790
[Hub Generated] Review request for Microsoft.Insights to add version stable/2018-03-01 #9790
Conversation
Swagger Validation Report
|
Rule | Message |
---|---|
1023 - TypeFormatChanged |
The new version has a different format than the previous one. New: Microsoft.Insights/stable/2018-03-01/metricAlert_API.json#L552:9 Old: Microsoft.Insights/stable/2018-03-01/metricAlert_API.json#L489:9 |
️⚠️
LintDiff: 2 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
- Linted configuring files (Based on target branch, openapi-validator v1.6.0 , classic-openapi-validator v1.1.5 )
Rule | Message |
---|---|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled New: Microsoft.Insights/stable/2018-03-01/metricAlert_API.json#L557 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: autoMitigate New: Microsoft.Insights/stable/2018-03-01/metricAlert_API.json#L590 |
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/monitor/resource-manager/readme.md tag: specification/monitor/resource-manager/readme.md#tag-package-2019-06 |
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go
|
azure-sdk-for-js
|
azure-sdk-for-java
|
azure-sdk-for-net
|
azure-sdk-for-python
|
azure-sdk-for-python-track2
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove submodule
@yashmuel Do we still need this PR? |
@yashmuel I closed this PR and if you still need this one, feel free to reopen it. |
what do you mean remove submodule? |
Azure Pipelines successfully started running 1 pipeline(s). |
|
azure-resource-manager-schemas
|
@myronfanqiu Hey, i've got a breaking changes approval, what's next step? |
Swagger Generation Artifacts
|
@myronfanqiu kindly ping |
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on PR review process.