-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.Billing EA Auth to version preview/2019-10-01-preview #9827
Conversation
Azure Pipelines successfully started running 1 pipeline(s). |
Can one of the admins verify this patch? |
azure-sdk-for-net - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-python - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
There are breaking changes, Please follow Azure Breaking changes approval request form as defined @ Breaking Change Process |
Please go through the checklist added as part of the review and mark them completed. |
Reviewed the changes it looks ok to me. Signing off based on Adrian Hall's review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xccc-msft can you please merge this PR. |
@msft-adrianma For now, I cannot merge for two reasons:
|
@xccc-msft , I already have ARM review signoff from @chiragg4u as these are evolutionary changes and not breaking. |
@chiragg4u Can you please update the label if you already sign off from ARM end? Thanks. |
@xccc-msft the check for breaking change is failing. We discussed the changes with Arm review team, and here is the response below. What needs to be done to bypass the checks? Because the PUT operation (starting at line 4769) is a NET NEW operation, and the input model is also NET NEW content, this is an EVOLUTIONARY change. Evolutionary changes are allowed in preview versions without a version bump and no user concerns. Recommendation is that the NEXT preview version conform to the preview versioning guidelines (add a .N to the end) if required. Based on this description, change is APPROVED. |
@msft-adrianma The failures come from |
@akning-ms can you advise on how we can proceed with the merge. We got approval for the changes from the arm team for the preview apis. I dont understand the lint errors. I see the pre-existing usage for next link already in the json. |
@msft-adrianma , Yes, you may need to fix 9 Lintdiff failure as below : |
For EVOLUTIONARY api added, suggest to add some tag e.g. [EXPENIMENTAL] in description. this will also show on API document for customer to better understand. thoughts? |
Azure Pipelines successfully started running 1 pipeline(s). |
@akning-ms I have fixed the sdk lintdiff issue. For the breaking change, it is already in the preview version so adding experimental is not needed. This is already signed off by the ARM team. |
…on preview/2019-10-01-preview (Azure#9827) * swagger for ea auth * fix example * adding link to example files. * update arm type for billingroleassignments. * pageable. * update comment * adding nextlink to responses for Lint failures.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on PR review process.