Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Billing EA Auth to version preview/2019-10-01-preview #9827

Merged
merged 7 commits into from
Jun 18, 2020

Conversation

msft-adrianma
Copy link
Contributor

@msft-adrianma msft-adrianma commented Jun 12, 2020

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 12, 2020

[Staging] Swagger Validation Report

~[Staging] BreakingChange: 8 Errors, 0 Warnings [Detail][Expand Details]
Rule Message
1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
New: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L8019:9
Old: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L7433:9
1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
New: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L8019:9
Old: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L7433:9
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'roleDefinitionName' renamed or removed?
New: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L7993:7
Old: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L7412:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'roleDefinitionName' renamed or removed?
New: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L7993:7
Old: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L7412:7
1041 - AddedPropertyInResponse The new version has a new property 'userAuthenticationType' in response that was not found in the old version.
New: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L7993:7
Old: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L7412:7
1041 - AddedPropertyInResponse The new version has a new property 'userEmailAddress' in response that was not found in the old version.
New: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L7993:7
Old: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L7412:7
1041 - AddedPropertyInResponse The new version has a new property 'roleDefinitionId' in response that was not found in the old version.
New: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L7993:7
Old: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L7412:7
1041 - AddedPropertyInResponse The new version has a new property 'principalTenantId' in response that was not found in the old version.
New: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L7993:7
Old: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L7412:7
Posted by Swagger Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 12, 2020

azure-sdk-for-net - Release

failed [Logs] [Expand Details]
  • Generate from 8b2dfe5 with merge commit 6b4d50c. SDK Automation 13.0.17.20200605.3
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
  • Microsoft.Azure.Management.Billing [View full logs]  [Release SDK Changes]
      Failed to create the package Microsoft.Azure.Management.Billing.
      Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=billing /v:n /p:SkipTests=true , {} 

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 12, 2020

    Azure CLI Extension Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 12, 2020

    azure-sdk-for-java - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 8b2dfe5 with merge commit 6b4d50c. SDK Automation 13.0.17.20200605.3
    • ️✔️sdk/billing/mgmt-v2017_02_27_preview [View full logs]  [Release SDK Changes]
    • ️✔️sdk/billing/mgmt-v2017_04_24_preview [View full logs]  [Release SDK Changes]
    • ️✔️sdk/billing/mgmt-v2018_03_01_preview [View full logs]  [Release SDK Changes]
    • ⚠️sdk/billing/mgmt-v2018_11_01_preview [View full logs]  [Release SDK Changes]
        [mvn] [ERROR] COMPILATION ERROR : 
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2018_11_01_preview/src/main/java/com/microsoft/azure/management/billing/v2018_11_01_preview/implementation/PriceSheetsInner.java:[130,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
        [mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
        [mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
        [mvn]   reason: cannot infer type-variable(s) T,THeader
        [mvn]     (actual and formal argument lists differ in length)
        [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-billing: Compilation failure
        [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2018_11_01_preview/src/main/java/com/microsoft/azure/management/billing/v2018_11_01_preview/implementation/PriceSheetsInner.java:[130,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
        [mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
        [mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
        [mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
        [mvn] [ERROR]     (actual and formal argument lists differ in length)
        [mvn] [ERROR] -> [Help 1]
        [mvn] [ERROR] 
        [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
        [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
        [mvn] [ERROR] 
        [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
        [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
      • ⚠️sdk/billing/mgmt-v2019_10_01_preview [View full logs]  [Release SDK Changes]
          [mvn] [ERROR] COMPILATION ERROR : 
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[146,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
          [mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
          [mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
          [mvn]   reason: cannot infer type-variable(s) T,THeader
          [mvn]     (actual and formal argument lists differ in length)
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[303,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
          [mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
          [mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
          [mvn]   reason: cannot infer type-variable(s) T,THeader
          [mvn]     (actual and formal argument lists differ in length)
          [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-billing: Compilation failure: Compilation failure: 
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[146,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
          [mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
          [mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
          [mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
          [mvn] [ERROR]     (actual and formal argument lists differ in length)
          [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[303,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
          [mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
          [mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
          [mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
          [mvn] [ERROR]     (actual and formal argument lists differ in length)
          [mvn] [ERROR] -> [Help 1]
          [mvn] [ERROR] 
          [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
          [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
          [mvn] [ERROR] 
          [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
          [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
        • ⚠️sdk/billing/mgmt-v2020_05_01 [View full logs]  [Release SDK Changes]
            [mvn] [ERROR] COMPILATION ERROR : 
            [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2020_05_01/src/main/java/com/microsoft/azure/management/billing/v2020_05_01/implementation/InvoicesInner.java:[613,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
            [mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
            [mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
            [mvn]   reason: cannot infer type-variable(s) T,THeader
            [mvn]     (actual and formal argument lists differ in length)
            [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2020_05_01/src/main/java/com/microsoft/azure/management/billing/v2020_05_01/implementation/InvoicesInner.java:[975,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
            [mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
            [mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
            [mvn]   reason: cannot infer type-variable(s) T,THeader
            [mvn]     (actual and formal argument lists differ in length)
            [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-billing: Compilation failure: Compilation failure: 
            [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2020_05_01/src/main/java/com/microsoft/azure/management/billing/v2020_05_01/implementation/InvoicesInner.java:[613,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
            [mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
            [mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
            [mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
            [mvn] [ERROR]     (actual and formal argument lists differ in length)
            [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2020_05_01/src/main/java/com/microsoft/azure/management/billing/v2020_05_01/implementation/InvoicesInner.java:[975,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
            [mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
            [mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
            [mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
            [mvn] [ERROR]     (actual and formal argument lists differ in length)
            [mvn] [ERROR] -> [Help 1]
            [mvn] [ERROR] 
            [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
            [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
            [mvn] [ERROR] 
            [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
            [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

          @openapi-sdkautomation
          Copy link

          openapi-sdkautomation bot commented Jun 12, 2020

          azure-sdk-for-go - Release

          ️✔️ succeeded [Logs] [Expand Details]

          @openapi-sdkautomation
          Copy link

          openapi-sdkautomation bot commented Jun 12, 2020

          azure-sdk-for-js - Release

          ️✔️ succeeded [Logs] [Expand Details]
          • ️✔️ Generate from 8b2dfe5 with merge commit 6b4d50c. SDK Automation 13.0.17.20200605.3
          • ️✔️@azure/arm-billing [View full logs]  [Release SDK Changes]
            Only show 100 items here, please refer to log for details.
            [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
            [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
            [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
            [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
            [npmPack] loaded rollup.config.js with warnings
            [npmPack] (!) Unused external imports
            [npmPack] default imported from external module 'rollup' but never used
            [npmPack] 
            [npmPack] ./esm/billingManagementClient.js → ./dist/arm-billing.js...
            [npmPack] created ./dist/arm-billing.js in 606ms
            [npmPack] npm notice 
            [npmPack] npm notice package: @azure/arm-billing@2.2.0
            [npmPack] npm notice === Tarball Contents === 
            [npmPack] npm notice 1.8kB   esm/operations/address.js                           
            [npmPack] npm notice 460B    esm/models/addressMappers.js                        
            [npmPack] npm notice 3.5kB   esm/operations/agreements.js                        
            [npmPack] npm notice 937B    esm/models/agreementsMappers.js                     
            [npmPack] npm notice 275.1kB dist/arm-billing.js                                 
            [npmPack] npm notice 98.9kB  dist/arm-billing.min.js                             
            [npmPack] npm notice 1.9kB   esm/operations/availableBalances.js                 
            [npmPack] npm notice 923B    esm/models/availableBalancesMappers.js              
            [npmPack] npm notice 7.4kB   esm/operations/billingAccounts.js                   
            [npmPack] npm notice 1.1kB   esm/models/billingAccountsMappers.js                
            [npmPack] npm notice 2.7kB   esm/billingManagementClient.js                      
            [npmPack] npm notice 2.6kB   esm/billingManagementClientContext.js               
            [npmPack] npm notice 8.1kB   esm/operations/billingPermissions.js                
            [npmPack] npm notice 490B    esm/models/billingPermissionsMappers.js             
            [npmPack] npm notice 6.4kB   esm/operations/billingProfiles.js                   
            [npmPack] npm notice 985B    esm/models/billingProfilesMappers.js                
            [npmPack] npm notice 2.8kB   esm/operations/billingPropertyOperations.js         
            [npmPack] npm notice 931B    esm/models/billingPropertyOperationsMappers.js      
            [npmPack] npm notice 13.6kB  esm/operations/billingRoleAssignments.js            
            [npmPack] npm notice 961B    esm/models/billingRoleAssignmentsMappers.js         
            [npmPack] npm notice 10.0kB  esm/operations/billingRoleDefinitions.js            
            [npmPack] npm notice 961B    esm/models/billingRoleDefinitionsMappers.js         
            [npmPack] npm notice 14.3kB  esm/operations/billingSubscriptions.js              
            [npmPack] npm notice 1.1kB   esm/models/billingSubscriptionsMappers.js           
            [npmPack] npm notice 5.3kB   esm/operations/customers.js                         
            [npmPack] npm notice 935B    esm/models/customersMappers.js                      
            [npmPack] npm notice 345B    esm/models/index.js                                 
            [npmPack] npm notice 964B    esm/operations/index.js                             
            [npmPack] npm notice 5.0kB   esm/operations/instructions.js                      
            [npmPack] npm notice 941B    esm/models/instructionsMappers.js                   
            [npmPack] npm notice 13.8kB  esm/operations/invoices.js                          
            [npmPack] npm notice 6.9kB   esm/operations/invoiceSections.js                   
            [npmPack] npm notice 985B    esm/models/invoiceSectionsMappers.js                
            [npmPack] npm notice 1.0kB   esm/models/invoicesMappers.js                       
            [npmPack] npm notice 88.1kB  esm/models/mappers.js                               
            [npmPack] npm notice 2.3kB   esm/operations/operations.js                        
            [npmPack] npm notice 472B    esm/models/operationsMappers.js                     
            [npmPack] npm notice 4.6kB   esm/models/parameters.js                            
            [npmPack] npm notice 5.2kB   esm/operations/policies.js                          
            [npmPack] npm notice 914B    esm/models/policiesMappers.js                       
            [npmPack] npm notice 12.5kB  esm/operations/products.js                          
            [npmPack] npm notice 1.1kB   esm/models/productsMappers.js                       
            [npmPack] npm notice 983B    rollup.config.js                                    
            [npmPack] npm notice 2.6kB   esm/operations/transactions.js                      
            [npmPack] npm notice 941B    esm/models/transactionsMappers.js                   
            [npmPack] npm notice 1.6kB   package.json                                        
            [npmPack] npm notice 457B    tsconfig.json                                       
            [npmPack] npm notice 751B    esm/operations/address.d.ts.map                     
            [npmPack] npm notice 1.0kB   esm/operations/address.js.map                       
            [npmPack] npm notice 206B    esm/models/addressMappers.d.ts.map                  
            [npmPack] npm notice 219B    esm/models/addressMappers.js.map                    
            [npmPack] npm notice 1.6kB   esm/operations/agreements.d.ts.map                  
            [npmPack] npm notice 2.1kB   esm/operations/agreements.js.map                    
            [npmPack] npm notice 552B    esm/models/agreementsMappers.d.ts.map               
            [npmPack] npm notice 565B    esm/models/agreementsMappers.js.map                 
            [npmPack] npm notice 637.1kB dist/arm-billing.js.map                             
            [npmPack] npm notice 78.5kB  dist/arm-billing.min.js.map                         
            [npmPack] npm notice 819B    esm/operations/availableBalances.d.ts.map           
            [npmPack] npm notice 1.1kB   esm/operations/availableBalances.js.map             
            [npmPack] npm notice 553B    esm/models/availableBalancesMappers.d.ts.map        
            [npmPack] npm notice 566B    esm/models/availableBalancesMappers.js.map          
            [npmPack] npm notice 2.5kB   esm/operations/billingAccounts.d.ts.map             
            [npmPack] npm notice 3.9kB   esm/operations/billingAccounts.js.map               
            [npmPack] npm notice 601B    esm/models/billingAccountsMappers.d.ts.map          
            [npmPack] npm notice 614B    esm/models/billingAccountsMappers.js.map            
            [npmPack] npm notice 1.3kB   esm/billingManagementClient.d.ts.map                
            [npmPack] npm notice 1.8kB   esm/billingManagementClient.js.map                  
            [npmPack] npm notice 512B    esm/billingManagementClientContext.d.ts.map         
            [npmPack] npm notice 1.4kB   esm/billingManagementClientContext.js.map           
            [npmPack] npm notice 3.7kB   esm/operations/billingPermissions.d.ts.map          
            [npmPack] npm notice 4.8kB   esm/operations/billingPermissions.js.map            
            [npmPack] npm notice 231B    esm/models/billingPermissionsMappers.d.ts.map       
            [npmPack] npm notice 244B    esm/models/billingPermissionsMappers.js.map         
            [npmPack] npm notice 2.0kB   esm/operations/billingProfiles.d.ts.map             
            [npmPack] npm notice 3.2kB   esm/operations/billingProfiles.js.map               
            [npmPack] npm notice 575B    esm/models/billingProfilesMappers.d.ts.map          
            [npmPack] npm notice 588B    esm/models/billingProfilesMappers.js.map            
            [npmPack] npm notice 999B    esm/operations/billingPropertyOperations.d.ts.map   
            [npmPack] npm notice 1.6kB   esm/operations/billingPropertyOperations.js.map     
            [npmPack] npm notice 569B    esm/models/billingPropertyOperationsMappers.d.ts.map
            [npmPack] npm notice 582B    esm/models/billingPropertyOperationsMappers.js.map  
            [npmPack] npm notice 6.0kB   esm/operations/billingRoleAssignments.d.ts.map      
            [npmPack] npm notice 7.5kB   esm/operations/billingRoleAssignments.js.map        
            [npmPack] npm notice 576B    esm/models/billingRoleAssignmentsMappers.d.ts.map   
            [npmPack] npm notice 589B    esm/models/billingRoleAssignmentsMappers.js.map     
            [npmPack] npm notice 4.4kB   esm/operations/billingRoleDefinitions.d.ts.map      
            [npmPack] npm notice 5.6kB   esm/operations/billingRoleDefinitions.js.map        

          @openapi-sdkautomation
          Copy link

          openapi-sdkautomation bot commented Jun 12, 2020

          azure-sdk-for-python - Release

          ⚠️ warning [Logs] [Expand Details]
          • ⚠️ Generate from 8b2dfe5 with merge commit 6b4d50c. SDK Automation 13.0.17.20200605.3
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CustomerListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CustomerProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'TransferProductRequestProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BillingAccountListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BillingAccountProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BillingProfilesOnExpand' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BillingAccountUpdateRequest' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BillingPropertyProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Enrollment' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'EnrollmentPolicies' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DepartmentProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'EnrollmentAccountProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'InstructionListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BillingProfileListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'InstructionProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BillingProfileCreationRequest' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BillingProfileProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'InvoiceSectionsOnExpand' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AddressDetails' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'InvoiceSectionCreationRequest' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'InvoiceSectionListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'InvoiceSectionProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'InvoiceSectionWithCreateSubPermission' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AzurePlan' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DownloadUrl' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ErrorDetails' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Reseller' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'InvoiceListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'InvoiceProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PaymentProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Document' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ProductsListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ProductProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BillingSubscriptionsListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BillingSubscriptionProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'EnrollmentAccountContext' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'TransactionListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'TransactionProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PolicyProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'CustomerPolicyProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AvailableBalanceProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Amount' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BillingRoleAssignmentListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BillingRoleAssignmentProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BillingRoleDefinitionListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BillingRoleDefinitionProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'BillingPermissionsListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AgreementListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AgreementProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Participants' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
            Failed to find any diff after autorest so no changed packages was found.

          @openapi-sdkautomation
          Copy link

          openapi-sdkautomation bot commented Jun 12, 2020

          Trenton Generation - Release

          No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

          @openapi-sdkautomation
          Copy link

          openapi-sdkautomation bot commented Jun 12, 2020

          azure-sdk-for-python-track2 - Release

          No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

          @msft-adrianma msft-adrianma added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 12, 2020
          @msft-adrianma msft-adrianma changed the title [Hub Generated] Review request for Microsoft.Billing to add version preview/2019-10-01-preview [Hub Generated] Review request for Microsoft.Billing EA Auth to add version preview/2019-10-01-preview Jun 12, 2020
          @msft-adrianma msft-adrianma changed the title [Hub Generated] Review request for Microsoft.Billing EA Auth to add version preview/2019-10-01-preview [Hub Generated] Review request for Microsoft.Billing EA Auth to version preview/2019-10-01-preview Jun 12, 2020
          @msft-adrianma msft-adrianma requested review from asarkar84 and jbuls June 12, 2020 08:14
          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @chiragg4u
          Copy link
          Contributor

          There are breaking changes, Please follow Azure Breaking changes approval request form as defined @ Breaking Change Process

          @chiragg4u
          Copy link
          Contributor

          Please go through the checklist added as part of the review and mark them completed.

          @chiragg4u
          Copy link
          Contributor

          Reviewed the changes it looks ok to me.

          Signing off based on Adrian Hall's review.

          Copy link
          Contributor

          @chiragg4u chiragg4u left a comment

          Choose a reason for hiding this comment

          The reason will be displayed to describe this comment to others. Learn more.

          :shipit:

          @msft-adrianma
          Copy link
          Contributor Author

          @xccc-msft can you please merge this PR.

          @xseeseesee
          Copy link
          Contributor

          @msft-adrianma For now, I cannot merge for two reasons:

          • This PR is to add new version, we need ARM review and sign off
          • The merge button is disabled as CI fails

          @msft-adrianma
          Copy link
          Contributor Author

          @xccc-msft , I already have ARM review signoff from @chiragg4u as these are evolutionary changes and not breaking.
          What do we need to do to get CI to pass given that arm has signed off on the changes.

          @xseeseesee
          Copy link
          Contributor

          @chiragg4u Can you please update the label if you already sign off from ARM end? Thanks.
          @msft-adrianma You may check the Details bottom for why they are failing.

          @msft-adrianma
          Copy link
          Contributor Author

          @xccc-msft the check for breaking change is failing. We discussed the changes with Arm review team, and here is the response below. What needs to be done to bypass the checks?
          Output from conversation:

          Because the PUT operation (starting at line 4769) is a NET NEW operation, and the input model is also NET NEW content, this is an EVOLUTIONARY change.

          Evolutionary changes are allowed in preview versions without a version bump and no user concerns.

          Recommendation is that the NEXT preview version conform to the preview versioning guidelines (add a .N to the end) if required.

          Based on this description, change is APPROVED.

          @xseeseesee
          Copy link
          Contributor

          @msft-adrianma The failures come from BreakingChange and LintDiff. We might need help from @akning-ms.

          @msft-adrianma
          Copy link
          Contributor Author

          @akning-ms can you advise on how we can proceed with the merge. We got approval for the changes from the arm team for the preview apis. I dont understand the lint errors. I see the pre-existing usage for next link already in the json.

          @akning-ms
          Copy link
          Contributor

          akning-ms commented Jun 17, 2020

          @msft-adrianma , Yes, you may need to fix 9 Lintdiff failure as below :
          R2025 - NextLinkPropertyMustExist
          The property 'nextLink' specified by nextLinkName does not exist in the 200 response schema.
          Please, specify the name of the property that provides the nextLink. If the model does not have the nextLink property then specify null.
          at specification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json:3764
          refer to http://aka.ms/ci-fix

          @akning-ms
          Copy link
          Contributor

          For EVOLUTIONARY api added, suggest to add some tag e.g. [EXPENIMENTAL] in description. this will also show on API document for customer to better understand. thoughts?

          @chiragg4u chiragg4u added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 17, 2020
          @azure-pipelines
          Copy link

          Azure Pipelines successfully started running 1 pipeline(s).

          @msft-adrianma
          Copy link
          Contributor Author

          @akning-ms I have fixed the sdk lintdiff issue. For the breaking change, it is already in the preview version so adding experimental is not needed. This is already signed off by the ARM team.
          We need to enable this in arm manifest to unblock internal testing.

          @akning-ms akning-ms merged commit 6b4d50c into Azure:master Jun 18, 2020
          00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
          …on preview/2019-10-01-preview (Azure#9827)
          
          * swagger for ea auth
          
          * fix example
          
          * adding link to example files.
          
          * update arm type for billingroleassignments.
          
          * pageable.
          
          * update comment
          
          * adding nextlink to responses for Lint failures.
          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
          Labels
          ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
          Projects
          None yet
          Development

          Successfully merging this pull request may close these issues.

          6 participants