-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Microsoft.AVS 2020-03-20 API spec #9859
Conversation
[Staging] Swagger Validation Report
️✔️ |
Azure Pipelines successfully started running 1 pipeline(s). |
Can one of the admins verify this patch? |
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure Pipelines successfully started running 1 pipeline(s). |
@qianwens, can you please review and merge if approved? |
Hi @ctaggart Please check the comment. Thank you |
specification/vmware/resource-manager/Microsoft.AVS/stable/2020-03-20/vmware.json
Show resolved
Hide resolved
specification/vmware/resource-manager/Microsoft.AVS/stable/2020-03-20/vmware.json
Show resolved
Hide resolved
.../resource-manager/Microsoft.AVS/stable/2020-03-20/examples/PrivateClouds_CreateOrUpdate.json
Show resolved
Hide resolved
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
specification/vmware/resource-manager/Microsoft.AVS/stable/2020-03-20/vmware.json
Show resolved
Hide resolved
specification/vmware/resource-manager/Microsoft.AVS/stable/2020-03-20/vmware.json
Show resolved
Hide resolved
Azure Pipelines successfully started running 1 pipeline(s). |
specification/vmware/resource-manager/Microsoft.AVS/stable/2020-03-20/vmware.json
Show resolved
Hide resolved
specification/vmware/resource-manager/Microsoft.AVS/stable/2020-03-20/vmware.json
Show resolved
Hide resolved
specification/vmware/resource-manager/Microsoft.AVS/stable/2020-03-20/vmware.json
Show resolved
Hide resolved
specification/vmware/resource-manager/Microsoft.AVS/stable/2020-03-20/vmware.json
Show resolved
Hide resolved
specification/vmware/resource-manager/Microsoft.AVS/stable/2020-03-20/vmware.json
Show resolved
Hide resolved
Azure Pipelines successfully started running 1 pipeline(s). |
@pilor, thanks for the feedback. It has all been resolved. Can we get this approved and merged now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"clusterName": "cluster1", | ||
"cluster": { | ||
"sku": { | ||
"name": "AV20" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to change to "av20'? Because in response it is "av20" after testing.
"privateCloud": { | ||
"location": "eastus2", | ||
"sku": { | ||
"name": "AV36" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to change to "av36'? Because in response it is "av36" after testing.
* add Microsot.AVS 2020-03-20 API spec * fix spelling * prettier * empty object {} passed in to create * multi-api for Java & Go * prettier * review preview for go * mark properties required * add tags to PrivateCloudUpdate
The current API version is 2019-08-09-preview from #8296 . This is a new stable API version that includes these changes:
Major changes:
Minor changes:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.