Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change vmware client name to AVSClient #9863

Merged
merged 4 commits into from
Jun 19, 2020
Merged

change vmware client name to AVSClient #9863

merged 4 commits into from
Jun 19, 2020

Conversation

Abyssknight
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
    • adding/removing APIs.
    • adding/removing properties.
    • adding/removing API-version.
    • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 17, 2020

Swagger pipeline restarted successfully, please wait for status update in this comment.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 17, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from ac64a83 with merge commit baa0763. SDK Automation 13.0.17.20200605.3
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.Avs [View full logs]  [Release SDK Changes]
      No Artifact Generated.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 17, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 17, 2020

    azure-sdk-for-python - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from ac64a83 with merge commit baa0763. SDK Automation 13.0.17.20200605.3
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Trial' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Quota' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'TrackedResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ApiError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ApiErrorBase' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'OperationList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Operation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ExpressRouteAuthorization' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Circuit' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Endpoints' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'IdentitySource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PrivateCloud' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PrivateCloudProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Cluster' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'DefaultClusterProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ClusterProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'PrivateCloudList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ClusterList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'AdminCredentials' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      [AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Sku' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
      Failed to find any diff after autorest so no changed packages was found.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 17, 2020

    azure-sdk-for-go - Release

    ️✔️ succeeded [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 17, 2020

    Azure CLI Extension Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 17, 2020

    azure-sdk-for-js - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from ac64a83 with merge commit baa0763. SDK Automation 13.0.17.20200605.3
    • ️✔️@azure/arm-avs [View full logs]  [Release SDK Changes]
      Only show 100 items here, please refer to log for details.
      [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
      [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
      [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
      [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
      [npmPack] loaded rollup.config.js with warnings
      [npmPack] (!) Unused external imports
      [npmPack] default imported from external module 'rollup' but never used
      [npmPack] 
      [npmPack] ./esm/avsClient.js → ./dist/arm-avs.js...
      [npmPack] created ./dist/arm-avs.js in 286ms
      [npmPack] npm notice 
      [npmPack] npm notice package: @azure/arm-avs@0.1.0
      [npmPack] npm notice === Tarball Contents === 
      [npmPack] npm notice 65.2kB  dist/arm-avs.js                         
      [npmPack] npm notice 20.9kB  dist/arm-avs.min.js                     
      [npmPack] npm notice 1.5kB   esm/avsClient.js                        
      [npmPack] npm notice 2.5kB   esm/avsClientContext.js                 
      [npmPack] npm notice 10.7kB  esm/operations/clusters.js              
      [npmPack] npm notice 629B    esm/models/clustersMappers.js           
      [npmPack] npm notice 345B    esm/models/index.js                     
      [npmPack] npm notice 471B    esm/operations/index.js                 
      [npmPack] npm notice 2.6kB   esm/operations/locations.js             
      [npmPack] npm notice 430B    esm/models/locationsMappers.js          
      [npmPack] npm notice 19.8kB  esm/models/mappers.js                   
      [npmPack] npm notice 2.2kB   esm/operations/operations.js            
      [npmPack] npm notice 461B    esm/models/operationsMappers.js         
      [npmPack] npm notice 2.0kB   esm/models/parameters.js                
      [npmPack] npm notice 12.4kB  esm/operations/privateClouds.js         
      [npmPack] npm notice 657B    esm/models/privateCloudsMappers.js      
      [npmPack] npm notice 961B    rollup.config.js                        
      [npmPack] npm notice 1.6kB   package.json                            
      [npmPack] npm notice 457B    tsconfig.json                           
      [npmPack] npm notice 133.2kB dist/arm-avs.js.map                     
      [npmPack] npm notice 19.7kB  dist/arm-avs.min.js.map                 
      [npmPack] npm notice 691B    esm/avsClient.d.ts.map                  
      [npmPack] npm notice 847B    esm/avsClient.js.map                    
      [npmPack] npm notice 484B    esm/avsClientContext.d.ts.map           
      [npmPack] npm notice 1.4kB   esm/avsClientContext.js.map             
      [npmPack] npm notice 2.7kB   esm/operations/clusters.d.ts.map        
      [npmPack] npm notice 5.3kB   esm/operations/clusters.js.map          
      [npmPack] npm notice 338B    esm/models/clustersMappers.d.ts.map     
      [npmPack] npm notice 351B    esm/models/clustersMappers.js.map       
      [npmPack] npm notice 9.5kB   esm/models/index.d.ts.map               
      [npmPack] npm notice 202B    esm/operations/index.d.ts.map           
      [npmPack] npm notice 126B    esm/models/index.js.map                 
      [npmPack] npm notice 217B    esm/operations/index.js.map             
      [npmPack] npm notice 1.1kB   esm/operations/locations.d.ts.map       
      [npmPack] npm notice 1.5kB   esm/operations/locations.js.map         
      [npmPack] npm notice 207B    esm/models/locationsMappers.d.ts.map    
      [npmPack] npm notice 220B    esm/models/locationsMappers.js.map      
      [npmPack] npm notice 1.3kB   esm/models/mappers.d.ts.map             
      [npmPack] npm notice 11.5kB  esm/models/mappers.js.map               
      [npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map      
      [npmPack] npm notice 1.4kB   esm/operations/operations.js.map        
      [npmPack] npm notice 222B    esm/models/operationsMappers.d.ts.map   
      [npmPack] npm notice 235B    esm/models/operationsMappers.js.map     
      [npmPack] npm notice 541B    esm/models/parameters.d.ts.map          
      [npmPack] npm notice 1.5kB   esm/models/parameters.js.map            
      [npmPack] npm notice 3.7kB   esm/operations/privateClouds.d.ts.map   
      [npmPack] npm notice 6.6kB   esm/operations/privateClouds.js.map     
      [npmPack] npm notice 364B    esm/models/privateCloudsMappers.d.ts.map
      [npmPack] npm notice 377B    esm/models/privateCloudsMappers.js.map  
      [npmPack] npm notice 3.0kB   README.md                               
      [npmPack] npm notice 984B    esm/avsClient.d.ts                      
      [npmPack] npm notice 1.6kB   src/avsClient.ts                        
      [npmPack] npm notice 764B    esm/avsClientContext.d.ts               
      [npmPack] npm notice 2.3kB   src/avsClientContext.ts                 
      [npmPack] npm notice 7.4kB   esm/operations/clusters.d.ts            
      [npmPack] npm notice 14.2kB  src/operations/clusters.ts              
      [npmPack] npm notice 319B    esm/models/clustersMappers.d.ts         
      [npmPack] npm notice 619B    src/models/clustersMappers.ts           
      [npmPack] npm notice 24.6kB  esm/models/index.d.ts                   
      [npmPack] npm notice 155B    esm/operations/index.d.ts               
      [npmPack] npm notice 23.6kB  src/models/index.ts                     
      [npmPack] npm notice 439B    src/operations/index.ts                 
      [npmPack] npm notice 2.1kB   esm/operations/locations.d.ts           
      [npmPack] npm notice 4.5kB   src/operations/locations.ts             
      [npmPack] npm notice 120B    esm/models/locationsMappers.d.ts        
      [npmPack] npm notice 395B    src/models/locationsMappers.ts          
      [npmPack] npm notice 1.5kB   esm/models/mappers.d.ts                 
      [npmPack] npm notice 15.7kB  src/models/mappers.ts                   
      [npmPack] npm notice 2.0kB   esm/operations/operations.d.ts          
      [npmPack] npm notice 4.0kB   src/operations/operations.ts            
      [npmPack] npm notice 151B    esm/models/operationsMappers.d.ts       
      [npmPack] npm notice 427B    src/models/operationsMappers.ts         
      [npmPack] npm notice 610B    esm/models/parameters.d.ts              
      [npmPack] npm notice 2.1kB   src/models/parameters.ts                
      [npmPack] npm notice 9.6kB   esm/operations/privateClouds.d.ts       
      [npmPack] npm notice 18.9kB  src/operations/privateClouds.ts         
      [npmPack] npm notice 347B    esm/models/privateCloudsMappers.d.ts    
      [npmPack] npm notice 644B    src/models/privateCloudsMappers.ts      
      [npmPack] npm notice 1.1kB   LICENSE.txt                             
      [npmPack] npm notice === Tarball Details === 
      [npmPack] npm notice name:          @azure/arm-avs                          
      [npmPack] npm notice version:       0.1.0                                   
      [npmPack] npm notice filename:      azure-arm-avs-0.1.0.tgz                 
      [npmPack] npm notice package size:  55.5 kB                                 
      [npmPack] npm notice unpacked size: 496.4 kB                                
      [npmPack] npm notice shasum:        a142134fe688ce513b6f9caf023b9f72226fb0ab
      [npmPack] npm notice integrity:     sha512-nSu3mvoYDVWJh[...]UsXnM+/60cKMw==

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 17, 2020

    azure-sdk-for-java - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 17, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @Abyssknight Abyssknight changed the title Vmware client name change vmware client name to AVSClient Jun 17, 2020
    @azuresdkci
    Copy link
    Contributor

    Can one of the admins verify this patch?

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    Copy link
    Contributor

    @ctaggart ctaggart left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This works for the Python client, but fails for other clients like TypeScript. You can see from the TypeScript logs that it creates a file named aVSClient.
    /z/work/azure-sdk-for-js/sdk/vmware/arm-vmware/src/aVSClient.ts

    What happens if you set title to AVS Client with a space? Would it be better to just override each individual client, For python, that would be override-client-name: AVSClient.

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    Copy link
    Contributor

    @ctaggart ctaggart left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looks great 👍

    @qiaozha qiaozha merged commit baa0763 into master Jun 19, 2020
    iscai-msft added a commit to iscai-msft/azure-rest-api-specs that referenced this pull request Oct 5, 2020
    …into fix_kv_python_readme
    
    * 'master' of https://github.com/Azure/azure-rest-api-specs: (22 commits)
      Update DeletionRecovery Level (Azure#9895)
      Updating operations API to enable metrics via public metrics REST API. (Azure#9918)
      Xynoclafe/2020 06 version (Azure#9888)
      update java md (Azure#9923)
      Compute 2020-06-01 API version (Azure#9167)
      Merge Dev containerservice microsoft.container service 2020 06 01 (Azure#9914)
      new Batch Document Translation API Preview 1.0 (Azure#9218)
      1. Add a property as required (Azure#9899)
      Operational insights delete wrong lines data export (Azure#9849)
      [SRP]Adding allowBlobPublicAccess and minimumTlsVersion property for June19 and April19 (Azure#9831)
      [Hub Generated] Review request for Microsoft.ContainerInstance to add version stable/2019-12-01 (Azure#9838)
      add Java to AVS (Azure#9855)
      LaMigrationDate (Azure#9882)
      change vmware client name to AVSClient (Azure#9863)
      Fix typo in common private links definition for actionsRequired (Azure#9727)
      Microsoft.Support RP documentation updates (Azure#9880)
      BUG FIX: Fixed HopLink properties: context should be a dictionary, uint32 from… (Azure#9868)
      Update ci-fix.md (Azure#9881)
      Update Attestation control plane swagger to include 2 new defaultprovider API (Azure#9819)
      update java readme digitaltwins (Azure#9878)
      ...
    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    Co-authored-by: Shixun Guan <v-shigua@microsoft.com>
    @JackTn JackTn deleted the vmware-client-name branch August 9, 2021 10:17
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants