Skip to content

Commit

Permalink
Update CODEOWNERS paths: fix invalid paths (#2498)
Browse files Browse the repository at this point in the history
As part of ongoing work of enabling wildcard support for `CODEOWNERS`:
- Azure/azure-sdk-tools#2770
- Azure/azure-sdk-tools#5088

and enabling stricter validation:
- Azure/azure-sdk-tools#4859

this PR:
- fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners);
- removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment)

Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs:
- Azure/azure-sdk-tools#5241
- Azure/azure-sdk-tools#5240
  • Loading branch information
konrad-jamrozik authored Feb 13, 2023
1 parent 5687697 commit ad29f02
Showing 1 changed file with 19 additions and 20 deletions.
39 changes: 19 additions & 20 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,19 +1,12 @@
# Instructions for CODEOWNERS file format and automatic build failure notifications:
# https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners

################
# Automation
################

# Git Hub integration and bot rules
/.github/ @jsquire @ronniegeraghty

###########
# SDK
###########

# Catch all for non-code project files
* @rickwinter
/** @rickwinter

# SDK team
/sdk/ @rickwinter
Expand All @@ -23,24 +16,30 @@

# Service teams
# Core
sdk/docs/core/ @ahsonkhan @antkmsft @rickwinter @vhvb1989 @gearama
sdk/inc/azure/core/ @ahsonkhan @antkmsft @rickwinter @vhvb1989 @gearama
sdk/samples/core/ @ahsonkhan @antkmsft @rickwinter @vhvb1989 @gearama
sdk/src/azure/core/ @ahsonkhan @antkmsft @rickwinter @vhvb1989 @gearama
sdk/tests/core/ @ahsonkhan @antkmsft @rickwinter @vhvb1989 @gearama
/sdk/docs/core/ @ahsonkhan @antkmsft @rickwinter @vhvb1989 @gearama
/sdk/inc/azure/core/ @ahsonkhan @antkmsft @rickwinter @vhvb1989 @gearama
/sdk/samples/core/ @ahsonkhan @antkmsft @rickwinter @vhvb1989 @gearama
/sdk/src/azure/core/ @ahsonkhan @antkmsft @rickwinter @vhvb1989 @gearama
/sdk/tests/core/ @ahsonkhan @antkmsft @rickwinter @vhvb1989 @gearama

# IoT
sdk/docs/iot/ @CIPop @danewalton @ericwol-msft @ewertons @josesanchez7 @jspaith @preethi826 @RLeclair @vaavva
sdk/inc/azure/iot/ @CIPop @danewalton @ericwol-msft @ewertons @josesanchez7 @jspaith @preethi826 @RLeclair @vaavva
sdk/samples/iot/ @CIPop @danewalton @ericwol-msft @ewertons @josesanchez7 @jspaith @preethi826 @RLeclair @vaavva
sdk/src/azure/iot/ @CIPop @danewalton @ericwol-msft @ewertons @josesanchez7 @jspaith @preethi826 @RLeclair @vaavva
sdk/tests/iot/ @CIPop @danewalton @ericwol-msft @ewertons @josesanchez7 @jspaith @preethi826 @RLeclair @vaavva
/sdk/docs/iot/ @CIPop @danewalton @ericwol-msft @ewertons @josesanchez7 @jspaith @preethi826 @RLeclair @vaavva
/sdk/inc/azure/iot/ @CIPop @danewalton @ericwol-msft @ewertons @josesanchez7 @jspaith @preethi826 @RLeclair @vaavva
/sdk/samples/iot/ @CIPop @danewalton @ericwol-msft @ewertons @josesanchez7 @jspaith @preethi826 @RLeclair @vaavva
/sdk/src/azure/iot/ @CIPop @danewalton @ericwol-msft @ewertons @josesanchez7 @jspaith @preethi826 @RLeclair @vaavva
/sdk/tests/iot/ @CIPop @danewalton @ericwol-msft @ewertons @josesanchez7 @jspaith @preethi826 @RLeclair @vaavva

# Platform
sdk/src/azure/platform/ @ahsonkhan @antkmsft @rickwinter @vhvb1989 @gearama
/sdk/src/azure/platform/ @ahsonkhan @antkmsft @rickwinter @vhvb1989 @gearama

################
# Automation
################

# Git Hub integration and bot rules
/.github/ @jsquire @ronniegeraghty

###########
# Eng Sys
###########
/eng/ @danieljurek @weshaggard @benbp
/**/ci.yml @danieljurek

0 comments on commit ad29f02

Please sign in to comment.