Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Policies do not overwrite HTTP headers if they are already set #4303

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Policies do not overwrite HTTP headers if they are already set #4303

merged 3 commits into from
Feb 1, 2023

Conversation

antkmsft
Copy link
Member

Closes #4297
Closes #4301

@antkmsft antkmsft self-assigned this Jan 30, 2023
@antkmsft antkmsft mentioned this pull request Jan 31, 2023
Open
ahsonkhan
ahsonkhan approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@ahsonkhan ahsonkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this overwrite behavior apply to all request headers or just the two specific ones you are changing?

Before merging, please make sure (with consistency across languages), this is precisely the behavior we want. The change looks good otherwise.

@antkmsft
Copy link
Member Author

antkmsft commented Feb 1, 2023

@ahsonkhan, there is rather a consistency, see details in the linked issues.

I am not aware of any other headers that we're setting.

@antkmsft antkmsft merged commit 0504040 into Azure:main Feb 1, 2023
@antkmsft antkmsft deleted the preserve-http-headers branch February 1, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahsonkhan ahsonkhan ahsonkhan approved these changes

@LarryOsterman LarryOsterman LarryOsterman approved these changes

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

@vhvb1989 vhvb1989 Awaiting requested review from vhvb1989

@gearama gearama Awaiting requested review from gearama gearama is a code owner

Assignees

@antkmsft antkmsft

Labels
Azure.Core
Projects
None yet
Milestone
No milestone
3 participants
@antkmsft @ahsonkhan @LarryOsterman