add clarifying comment and negative tests

Azure · Dec 8, 2023 · 0095beb · 0095beb
1 parent 0873a5d
commit 0095beb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/sdk/azcore/internal/shared/shared.go b/sdk/azcore/internal/shared/shared.go
@@ -54,6 +54,9 @@ func RetryAfter(resp *http.Response) time.Duration {
 	type retryData struct {
 		header string
 		units  time.Duration
+
+		// custom is used when the regular algorithm failed and is optional.
+		// the returned duration is used verbatim (units is not applied).
 		custom func(string) (time.Duration, error)
 	}
 

diff --git a/sdk/azcore/internal/shared/shared_test.go b/sdk/azcore/internal/shared/shared_test.go
@@ -75,6 +75,12 @@ func TestRetryAfter(t *testing.T) {
 	resp.Header.Set(HeaderXMSRetryAfterMS, "400")
 	resp.Header.Set(HeaderRetryAfter, "300")
 	require.Equal(t, time.Duration(400)*time.Millisecond, RetryAfter(resp))
+	resp.Header = http.Header{}
+	resp.Header.Set(HeaderRetryAfterMS, "invalid")
+	require.Zero(t, RetryAfter(resp))
+	resp.Header = http.Header{}
+	resp.Header.Set(HeaderXMSRetryAfterMS, "invalid")
+	require.Zero(t, RetryAfter(resp))
 }
 
 func TestTypeOfT(t *testing.T) {