Add another non-standard error code for RP registration (#20860)

Azure · May 16, 2023 · 6879d7e · 6879d7e
1 parent 2d655f3
commit 6879d7e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/sdk/azcore/CHANGELOG.md b/sdk/azcore/CHANGELOG.md
@@ -19,7 +19,7 @@
 
 ### Bugs Fixed
 * Retry policy always clones the underlying `*http.Request` before invoking the next policy.
-* Added `MissingRegistrationForResourceProvider` to the list of error codes for unregistered resource providers.
+* Added some non-standard error codes to the list of error codes for unregistered resource providers.
 
 ### Other Changes
 

diff --git a/sdk/azcore/arm/runtime/policy_register_rp.go b/sdk/azcore/arm/runtime/policy_register_rp.go
@@ -175,6 +175,7 @@ func (r *rpRegistrationPolicy) Do(req *azpolicy.Request) (*http.Response, error)
 var unregisteredRPCodes = []string{
 	"MissingSubscriptionRegistration",
 	"MissingRegistrationForResourceProvider",
+	"Subscription Not Registered",
 }
 
 func isUnregisteredRPCode(errorCode string) bool {

diff --git a/sdk/azcore/arm/runtime/policy_register_rp_test.go b/sdk/azcore/arm/runtime/policy_register_rp_test.go
@@ -412,6 +412,11 @@ func TestRPRegistrationPolicyEnvironmentsInSubExceeded(t *testing.T) {
 	require.EqualValues(t, 0, logEntries)
 }
 
+func TestIsUnregisteredRPCode(t *testing.T) {
+	require.True(t, isUnregisteredRPCode("Subscription Not Registered"))
+	require.False(t, isUnregisteredRPCode("Your subscription isn't registered"))
+}
+
 type fakeClient struct {
 	ep string
 	pl runtime.Pipeline