fix: empty breaking or additive items in changelog (#16870)

Azure · Jan 21, 2022 · 9727f72 · 9727f72
1 parent ec0cf6f
commit 9727f72
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/eng/tools/generator/autorest/model/changelog.go b/eng/tools/generator/autorest/model/changelog.go
@@ -83,15 +83,21 @@ func writeChangelogForPackage(r *report.Package) string {
 	md := &markdown.Writer{}
 
 	// write breaking changes
-	md.WriteHeader("Breaking Changes")
-	for _, item := range getBreakingChanges(r.BreakingChanges) {
-		md.WriteListItem(item)
+	breakings := getBreakingChanges(r.BreakingChanges)
+	if len(breakings) > 0 {
+		md.WriteHeader("Breaking Changes")
+		for _, item := range breakings {
+			md.WriteListItem(item)
+		}
 	}
 
 	// write additional changes
-	md.WriteHeader("Features Added")
-	for _, item := range getNewContents(r.AdditiveChanges) {
-		md.WriteListItem(item)
+	additives := getNewContents(r.AdditiveChanges)
+	if len(additives) > 0 {
+		md.WriteHeader("Features Added")
+		for _, item := range additives {
+			md.WriteListItem(item)
+		}
 	}
 
 	return md.String()

diff --git a/sdk/resourcemanager/resources/armpolicy/CHANGELOG.md b/sdk/resourcemanager/resources/armpolicy/CHANGELOG.md
@@ -18,10 +18,6 @@
 - Struct `ErrorAdditionalInfo` has been removed
 - Struct `ErrorResponse` has been removed
 
-### Features Added
-
-
-
 ## 0.2.0 (2022-01-13)
 ### Breaking Changes