Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced relative link with absolute links and remove locale #12541

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Replaced relative link with absolute links and remove locale #12541

merged 2 commits into from
Sep 18, 2020

Conversation

sima-zhu
Copy link
Contributor

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.

The PR is to turn on the link check flag.

  1. Disable the relative links.
  2. Remove locale "en-us" from link.

@sima-zhu sima-zhu added the EngSys This issue is impacting the engineering system. label Sep 17, 2020
@sima-zhu sima-zhu self-assigned this Sep 17, 2020
@sima-zhu sima-zhu mentioned this pull request Sep 17, 2020
Merged
@ArcturusZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weshaggard weshaggard merged commit e906ecd into Azure:master Sep 18, 2020
@sima-zhu sima-zhu deleted the disable_relative_link branch September 18, 2020 04:50
ghost pushed a commit to Azure/azure-sdk-tools that referenced this pull request Oct 19, 2020
@sima-zhu
Enable the link check for link verification step. (#1019)
370df1b 
This is the final step of link verification epic. 

Enable the link guidance check for all Ci pipelines.

The PR is pending for all lang PRs:
java: Azure/azure-sdk-for-java#15285
net: Azure/azure-sdk-for-net#15223
python: Azure/azure-sdk-for-python#13846
js: Azure/azure-sdk-for-js#11317
ios: Azure/azure-sdk-for-ios#433
android: Azure/azure-sdk-for-android#348
go: Azure/azure-sdk-for-go#12541
cpp: Azure/azure-sdk-for-cpp#632
c: Azure/azure-sdk-for-c#1296
benbp pushed a commit to Azure/azure-sdk-tools that referenced this pull request Dec 1, 2020
@sima-zhu @benbp
Enable the link check for link verification step. (#1019)
4017a2a 
This is the final step of link verification epic. 

Enable the link guidance check for all Ci pipelines.

The PR is pending for all lang PRs:
java: Azure/azure-sdk-for-java#15285
net: Azure/azure-sdk-for-net#15223
python: Azure/azure-sdk-for-python#13846
js: Azure/azure-sdk-for-js#11317
ios: Azure/azure-sdk-for-ios#433
android: Azure/azure-sdk-for-android#348
go: Azure/azure-sdk-for-go#12541
cpp: Azure/azure-sdk-for-cpp#632
c: Azure/azure-sdk-for-c#1296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

@jhendrixMSFT jhendrixMSFT Awaiting requested review from jhendrixMSFT

Assignees

@sima-zhu sima-zhu

Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sima-zhu @ArcturusZhang @weshaggard