Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DoNotMerge] UUID package switch test #13413

Closed

Conversation

ArcturusZhang
Copy link
Member

@ArcturusZhang ArcturusZhang commented Nov 10, 2020

Fixes #3158

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • Apache v2 license headers are included in each file.

@ArcturusZhang ArcturusZhang changed the title UUID package switch test [DoNotMerge] UUID package switch test Nov 10, 2020
@check-enforcer
Copy link

This repository is protected by Check Enforcer. The check-enforcer check-run will not pass until there is at least one more check-run successfully passing. Check Enforcer supports the following comment commands:

  • /check-enforcer evaluate; tells Check Enforcer to evaluate this pull request.
  • /check-enforcer override; by-pass Check Enforcer (approvals still required).

@ArcturusZhang ArcturusZhang force-pushed the uuid-package-switch-test branch from 928b544 to b507b1a Compare November 11, 2020 03:40
@dlorenc
Copy link

dlorenc commented Dec 19, 2020

Hi! Just wondering if this is still planned. I'm trying to track down some dependencies marked vulnerable in some of my projects, and this one is coming up. Is there anything I can do to help swap the packages here?

@ArcturusZhang
Copy link
Member Author

Hi @dlorenc this is still planned, but it will not happen in this month's major release. Please stay tuned.

@dlorenc
Copy link

dlorenc commented Dec 23, 2020

Hi @dlorenc this is still planned, but it will not happen in this month's major release. Please stay tuned.

Thanks for the reply! Is there anything I can do to help get this in in time? I don't mind trying to do the swap/testing things out if it's a bandwidth issue.

@ArcturusZhang
Copy link
Member Author

Hi @dlorenc this is still planned, but it will not happen in this month's major release. Please stay tuned.

Thanks for the reply! Is there anything I can do to help get this in in time? I don't mind trying to do the swap/testing things out if it's a bandwidth issue.

Well, it is not really a bandwidth issue more of an issue we should not introduce too many breaking changes in one major version and also consideration of the up-coming new year holiday.
We are planning to do some other improvements, such as this which also might be a breaking change across all of the packages (or maybe not).
But testings would be a great help, thanks a lot. We are happy to have any possible feedbacks on the impact of this change.

@ArcturusZhang ArcturusZhang deleted the uuid-package-switch-test branch February 24, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from satori/go.uuid to gofrs/uuid
2 participants