Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cosmos DB] Add master key authentication #15247

Closed
wants to merge 31 commits into from
Closed

[Cosmos DB] Add master key authentication #15247

wants to merge 31 commits into from

Conversation

ausfeldt
Copy link

@ausfeldt ausfeldt commented Aug 10, 2021 •
edited by ealsur
Loading

add master key authentication

still need determine best way to get resourceType and resouceId from request and write and end-to-end test against the cosmos emulator wired up in CI

Closes #15233

@ghost ghost added the Cosmos label Aug 10, 2021
@ausfeldt ausfeldt self-assigned this Aug 10, 2021
@ausfeldt ausfeldt requested a review from ealsur August 10, 2021 00:11
@ealsur
Copy link
Member

ealsur commented Aug 10, 2021

Can you rebase / merge track2_cosmos into the branch, seems like there are several conflicts

@ausfeldt
Copy link
Author

/azp run prepare-pipelines

@azure-pipelines
Copy link

Pull request contains merge conflicts.

Merge branch 'track2_cosmos' of https://github.com/Azure/azure-sdk-fo…
9ecaeea 
…r-go into users/gaausfel/add_master_key_authentication

# Conflicts:
#	sdk/cosmos/azcosmos/cosmos_client.go
#	sdk/cosmos/azcosmos/cosmos_client_connection.go
#	sdk/cosmos/azcosmos/go.mod
@check-enforcer
Copy link

This repository is protected by Check Enforcer. The check-enforcer check-run will not pass until there is at least one more check-run successfully passing. Check Enforcer supports the following comment commands:

  • /check-enforcer evaluate; tells Check Enforcer to evaluate this pull request.
  • /check-enforcer override; by-pass Check Enforcer (approvals still required).

@ausfeldt
Copy link
Author

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ausfeldt
Copy link
Author

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@ausfeldt
Copy link
Author

/azp

@azure-pipelines
Copy link

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@ausfeldt
Copy link
Author

/azp list

@azure-pipelines
Copy link

CI/CD Pipelines for this repository:

@ausfeldt
Copy link
Author

/azp run "go - cosmos - ci"

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@ausfeldt ausfeldt marked this pull request as ready for review August 13, 2021 18:26
@ausfeldt ausfeldt requested review from benbp and a team as code owners August 13, 2021 18:26
@ealsur ealsur changed the title Users/gaausfel/add master key authentication [Cosmos DB] Add master key authentication Aug 13, 2021
@ealsur ealsur mentioned this pull request Aug 13, 2021
Merged
@ealsur
Copy link
Member

ealsur commented Aug 13, 2021

Closing PR in favor of #15292

@ealsur ealsur closed this Aug 13, 2021
@ealsur ealsur deleted the users/gaausfel/add_master_key_authentication branch August 13, 2021 22:08
@ealsur ealsur restored the users/gaausfel/add_master_key_authentication branch August 13, 2021 22:08
@RickWinter RickWinter deleted the users/gaausfel/add_master_key_authentication branch May 23, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ealsur ealsur ealsur left review comments

@benbp benbp Awaiting requested review from benbp benbp is a code owner

Assignees

@ausfeldt ausfeldt

Labels
Cosmos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ausfeldt @ealsur