Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Internal] Add methods for configuring tests to work with test proxy #15259
[Internal] Add methods for configuring tests to work with test proxy #15259
Changes from all commits
43e875b
ce8dfa6
8b716cd
2d34f68
858f929
0e78180
abfd495
ae991cc
ab34658
464bb90
5170886
1bb884d
6355a03
ccf37a8
29bed05
f33a232
0ea12a0
def4c27
42e667a
0455394
0f87900
2921e52
66158cb
3de4936
5feef38
e752a6f
8ec2e2a
32c6570
297b899
ecc9563
7867ab1
1453a3d
2cee416
b3f7949
bd98736
9ca55c8
9421675
e2b0ded
6c3d638
b62e797
f40b00d
a009528
2c8e939
cdca98a
2d96846
1fd955b
d3719af
0a56f19
6aba571
a20591d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should x-recording-file be in a constant too? (noticed you did that with
IdHeader
below)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will change after every test so no it should not be a constant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: would it be helpful to say that the specific header was not found? Could aid in diagnostics if someone is trying to figure out what's wrong strictly by the error message.