[Eng] remove need for get_test_dirs.ps1 #15874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
seankane-msft
commented
Oct 20, 2021
seankane-msft
commented
- The purpose of this PR is explained in this or a referenced issue.
- The PR does not update generated files.
- These files are managed by the codegen framework at Azure/autorest.go.
- Tests are included and/or updated for code changes.
- Updates to CHANGELOG.md are included.
- MIT license headers are included in each file.
seankane-msft
commented
Oct 20, 2021
| @@ -113,8 +110,7 @@ stages: | |||
| GoWorkspace: $(GO_WORKSPACE_PATH) | |||
| Image: $(vm.image) | |||
| GoVersion: $(go.version) | |||
| RunTests: ${{ parameters.RunTests }} | |||
| TestProxy: true | |||
| TestProxy: true # Do we need this conditional if it's always true? @benbp | |||
There was a problem hiding this comment.
Do we need this conditional @benbp?
There was a problem hiding this comment.
@seankane-msft It is needed. The value defaults to false and therefore is not specified for the live tests, samples tests, and cosmos tests. I like how it's set up as an opt-in type value right now, but if you wanted to require it to be passed in for all templates so the usage is clearer, I'd be open to that.
benbp
reviewed
Oct 20, 2021
| - pwsh: | | ||
| # ambitious_azsdk_test_proxy is the hardcoded container name used | ||
| # by the test proxy startup script | ||
| docker logs ambitious_azsdk_test_proxy |
There was a problem hiding this comment.
@scbedd this makes me double take every time :D
benbp
approved these changes
Oct 20, 2021
5 tasks
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.