Azkeys Pull in latest main

.github/CODEOWNERS

@@ -33,6 +33,9 @@
 # PRLabel: %Tables
 /sdk/data/aztables/      @seankane-msft @jhendrixMSFT 
 
+# PRLabel: %Service Bus
+/sdk/messaging/azservicebus   @richardpark-msft @jhendrixMSFT 
+
 # PRLabel: %Mgmt
 /sdk/resourcemanager/    @ArcturusZhang @lirenhe
 

eng/common/scripts/Prepare-Release.ps1

@@ -109,11 +109,15 @@ else
 $releaseDateString = $ParsedReleaseDate.ToString("MM/dd/yyyy")
 $month = $ParsedReleaseDate.ToString("MMMM")
 
-Write-Host
 Write-Host "Assuming release is in $month with release date $releaseDateString" -ForegroundColor Green
+if (Test-Path "Function:GetExistingPackageVersions")
+{
+    $releasedVersions = GetExistingPackageVersions -PackageName $packageProperties.Name -GroupId $packageProperties.Group
+    $latestReleasedVersion = $releasedVersions[$releasedVersions.Count - 1]
+    Write-Host "Latest released version: ${latestReleasedVersion}" -ForegroundColor Green
+}
 
 $currentProjectVersion = $packageProperties.Version
-
 $newVersion = Read-Host -Prompt "Input the new version, or press Enter to use use current project version '$currentProjectVersion'"
 
 if (!$newVersion)

eng/common/scripts/stress-testing/deploy-stress-tests.ps1

@@ -76,9 +76,9 @@ function DeployStressTests(
     [string]$environment = 'test',
     [string]$repository = 'images',
     [boolean]$pushImages = $false,
-    [string]$clusterGroup = 'rg-stress-test-cluster-',
+    [string]$clusterGroup = 'rg-stress-cluster-test',
     [string]$deployId = 'local',
-    [string]$subscription = 'Azure SDK Test Resources'
+    [string]$subscription = 'Azure SDK Developer Playground'
 ) {
     if ($PSCmdlet.ParameterSetName -eq 'DoLogin') {
         Login $subscription $clusterGroup $pushImages

eng/config.json

@@ -1,40 +1,44 @@
 {
     "Packages": [
         {
-            "Name": "azidentity",
-            "CoverageGoal": 0.68
+            "Name": "azblob",
+            "CoverageGoal": 0.45
+        },
+        {
+            "Name": "azcore",
+            "CoverageGoal": 0.85
         },
         {
             "Name": "azcosmos",
             "CoverageGoal": 0.40
         },
         {
-            "Name": "azcore",
-            "CoverageGoal": 0.85
+            "Name": "azidentity",
+            "CoverageGoal": 0.68
         },
         {
-            "Name": "internal",
-            "CoverageGoal": 0.70
+            "Name": "azkeys",
+            "CoverageGoal": 0.72
         },
         {
-            "Name": "data",
-            "CoverageGoal": 0.62
+            "Name": "azsecrets",
+            "CoverageGoal": 0.76
         },
         {
-            "Name": "azblob",
-            "CoverageGoal": 0.45
+            "Name": "azservicebus",
+            "CoverageGoal": 0.24
         },
         {
-            "Name": "messaging",
-            "CoverageGoal": 0.10
+            "Name": "data",
+            "CoverageGoal": 0.62
         },
         {
-            "Name": "azsecrets",
-            "CoverageGoal": 0.76
+            "Name": "eng/tools",
+            "CoverageGoal": 0.0
         },
         {
-            "Name": "azkeys",
-            "CoverageGoal": 0.72
+            "Name": "internal",
+            "CoverageGoal": 0.70
         }
     ]
 }

eng/tools/generator/autorest/model/generateOptions.go

@@ -9,7 +9,7 @@ import (
 	"io/ioutil"
 )
 
-// GenerateOptions deserialize from generate_options.json file in root directory of azure-sdk-for-go
+// GenerateOptions deserialize from eng/generate_options.json file in root directory of azure-sdk-for-go
 type GenerateOptions struct {
 	AutorestArguments []string `json:"autorestArguments"`
 	AdditionalOptions []string `json:"additionalOptions,omitempty"`

eng/tools/generator/common/constants.go

@@ -5,7 +5,7 @@ package common
 
 const (
 	// DefaultOptionPath the default path of the option file
-	DefaultOptionPath = "generate_options.json"
+	DefaultOptionPath = "eng/generate_options.json"
 
 	Services          = "services"
 	ChangelogFilename = "CHANGELOG.md"

sdk/azcore/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Release History
 
+## 0.20.1 (Unreleased)
+
+### Features Added
+
+### Breaking Changes
+
+### Bugs Fixed
+
+### Other Changes
+
 ## 0.20.0 (2021-10-22)
 
 ### Breaking Changes
@@ -18,6 +28,7 @@
 * Added string typdef `arm.Endpoint` to provide a hint toward expected ARM client endpoints
 * `azcore.ClientOptions` contains common pipeline configuration settings
 * Added support for multi-tenant authorization in `arm/runtime`
+* Require one second minimum when calling `PollUntilDone()`
 
 ### Bug Fixes
 * Fixed a potential panic when creating the default Transporter.

sdk/azcore/arm/runtime/poller_test.go

@@ -111,7 +111,7 @@ func TestNewPollerAsync(t *testing.T) {
 		t.Fatal(err)
 	}
 	var result mockType
-	_, err = poller.PollUntilDone(context.Background(), 10*time.Millisecond, &result)
+	_, err = poller.PollUntilDone(context.Background(), time.Second, &result)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -147,7 +147,7 @@ func TestNewPollerBody(t *testing.T) {
 		t.Fatal(err)
 	}
 	var result mockType
-	_, err = poller.PollUntilDone(context.Background(), 10*time.Millisecond, &result)
+	_, err = poller.PollUntilDone(context.Background(), time.Second, &result)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -184,7 +184,7 @@ func TestNewPollerLoc(t *testing.T) {
 		t.Fatal(err)
 	}
 	var result mockType
-	_, err = poller.PollUntilDone(context.Background(), 10*time.Millisecond, &result)
+	_, err = poller.PollUntilDone(context.Background(), time.Second, &result)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -215,7 +215,7 @@ func TestNewPollerInitialRetryAfter(t *testing.T) {
 		t.Fatalf("unexpected poller type %s", pt.String())
 	}
 	var result mockType
-	_, err = poller.PollUntilDone(context.Background(), 10*time.Millisecond, &result)
+	_, err = poller.PollUntilDone(context.Background(), time.Second, &result)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -273,7 +273,7 @@ func TestNewPollerFailedWithError(t *testing.T) {
 		t.Fatalf("unexpected poller type %s", pt.String())
 	}
 	var result mockType
-	_, err = poller.PollUntilDone(context.Background(), 10*time.Millisecond, &result)
+	_, err = poller.PollUntilDone(context.Background(), time.Second, &result)
 	if err == nil {
 		t.Fatal(err)
 	}
@@ -309,7 +309,7 @@ func TestNewPollerSuccessNoContent(t *testing.T) {
 		t.Fatal(err)
 	}
 	var result mockType
-	_, err = poller.PollUntilDone(context.Background(), 10*time.Millisecond, &result)
+	_, err = poller.PollUntilDone(context.Background(), time.Second, &result)
 	if err != nil {
 		t.Fatal(err)
 	}

sdk/azcore/internal/pollers/poller.go

@@ -169,9 +169,11 @@ func (l *Poller) FinalResponse(ctx context.Context, respType interface{}) (*http
 // PollUntilDone will handle the entire span of the polling operation until a terminal state is reached,
 // then return the final HTTP response for the polling operation and unmarshal the content of the payload
 // into the respType interface that is provided.
-// freq - the time to wait between polling intervals if the endpoint doesn't send a Retry-After header.
-//        A good starting value is 30 seconds.  Note that some resources might benefit from a different value.
+// freq - the time to wait between intervals in absence of a Retry-After header.  Minimum is one second.
 func (l *Poller) PollUntilDone(ctx context.Context, freq time.Duration, respType interface{}) (*http.Response, error) {
+	if freq < time.Second {
+		return nil, errors.New("polling frequency minimum is one second")
+	}
 	start := time.Now()
 	logPollUntilDoneExit := func(v interface{}) {
 		log.Writef(log.EventLRO, "END PollUntilDone() for %T: %v, total time: %s", l.lro, v, time.Since(start))

sdk/azcore/internal/pollers/poller_test.go

@@ -132,6 +132,13 @@ func TestNewPoller(t *testing.T) {
 		t.Fatal("unexpected empty resume token")
 	}
 	resp, err = p.PollUntilDone(context.Background(), 1*time.Millisecond, nil)
+	if err == nil {
+		t.Fatal("unexpected nil error")
+	}
+	if resp != nil {
+		t.Fatal("expected nil response")
+	}
+	resp, err = p.PollUntilDone(context.Background(), time.Second, nil)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -167,7 +174,7 @@ func TestNewPollerWithFinalGET(t *testing.T) {
 		Shape string `json:"shape"`
 	}
 	var w widget
-	resp, err := p.PollUntilDone(context.Background(), 1*time.Millisecond, &w)
+	resp, err := p.PollUntilDone(context.Background(), time.Second, &w)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -198,7 +205,7 @@ func TestNewPollerFail1(t *testing.T) {
 	p := NewPoller(&fakePoller{Ep: srv.URL()}, firstResp, pl, func(*http.Response) error {
 		return errors.New("failed")
 	})
-	resp, err := p.PollUntilDone(context.Background(), 1*time.Millisecond, nil)
+	resp, err := p.PollUntilDone(context.Background(), time.Second, nil)
 	if err == nil {
 		t.Fatal("unexpected nil error")
 	} else if s := err.Error(); s != "failed" {
@@ -221,7 +228,7 @@ func TestNewPollerFail2(t *testing.T) {
 	p := NewPoller(&fakePoller{Ep: srv.URL()}, firstResp, pl, func(*http.Response) error {
 		return errors.New("failed")
 	})
-	resp, err := p.PollUntilDone(context.Background(), 1*time.Millisecond, nil)
+	resp, err := p.PollUntilDone(context.Background(), time.Second, nil)
 	if err == nil {
 		t.Fatal("unexpected nil error")
 	} else if s := err.Error(); s != "failed" {
@@ -244,7 +251,7 @@ func TestNewPollerError(t *testing.T) {
 	p := NewPoller(&fakePoller{Ep: srv.URL()}, firstResp, pl, func(*http.Response) error {
 		return errors.New("failed")
 	})
-	resp, err := p.PollUntilDone(context.Background(), 1*time.Millisecond, nil)
+	resp, err := p.PollUntilDone(context.Background(), time.Second, nil)
 	if err == nil {
 		t.Fatal("unexpected nil error")
 	} else if s := err.Error(); s != "fatal" {

sdk/azcore/internal/shared/constants.go

@@ -35,5 +35,5 @@ const (
 	Module = "azcore"
 
 	// Version is the semantic version (see http://semver.org) of this module.
-	Version = "v0.20.0"
+	Version = "v0.20.1"
 )

sdk/azcore/runtime/policy_retry.go

@@ -41,6 +41,7 @@ func setDefaults(o *policy.RetryOptions) {
 	if o.StatusCodes == nil {
 		o.StatusCodes = []int{
 			http.StatusRequestTimeout,      // 408
+			http.StatusTooManyRequests,     // 429
 			http.StatusInternalServerError, // 500
 			http.StatusBadGateway,          // 502
 			http.StatusServiceUnavailable,  // 503