[KeyVault] enable Managed HSM live tests #16162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seankane-msft
requested review from
benbp,
jhendrixMSFT and
a team
as code owners
ghost
added
the
|
/azp run go - azkeys |
|
Azure Pipelines successfully started running 1 pipeline(s). |
benbp
reviewed
Nov 15, 2021
| "Pool": "azsdk-pool-mms-ubuntu-2004-general" | ||
| } | ||
| }, | ||
| "ArmTemplateParameters": "@{ enableHsm = $true }" |
There was a problem hiding this comment.
Based on the current failure you need to also set GoVersion: https://github.com/Azure/azure-sdk-for-go/blob/main/eng/pipelines/templates/stages/platform-matrix.json#L13
benbp
approved these changes
Nov 16, 2021
jhendrixMSFT
pushed a commit
to jhendrixMSFT/azure-sdk-for-go
that referenced
this pull request
Jan 12, 2022
* enable hsm live tests * updating tests for HSM * testing live * removing import key * undoing changes to crypto * undoing more changes * pulling in bens changes * include go version in platform-matrix.json file * updating challenge auth for hsm issue * fixes to getChallengeRequest * adding debug info to live tests * updates that work locally, does not work in pipelines * print statements for pipeline debugging * updating debug * manually set contentlength to 0 * fixing issue with debug statement * getting a stream issue or Bad Request straight at service * moving commit to correct branch * dont read without resetting the body * new recordings and fixed challenge policy * using separate pipeline again * making crypto tests live only * updating coverage * linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #16153