Adopt msal for non-managed identity credentials #16243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seankane-msft
approved these changes
Nov 23, 2021
jhendrixMSFT
reviewed
Dec 9, 2021
jhendrixMSFT
reviewed
Dec 9, 2021
| } | ||
|
|
||
| func (p pipelineAdapter) Do(r *http.Request) (*http.Response, error) { | ||
| req, err := runtime.NewRequest(r.Context(), r.Method, r.URL.String()) |
There was a problem hiding this comment.
It's unfortunate that we have to do this (I feel like I had to do this elsewhere too). Maybe we need a runtime.WrapRequest that creates a runtime.Request from an existing http.Request.
jhendrixMSFT
reviewed
Dec 9, 2021
jhendrixMSFT
approved these changes
Dec 9, 2021
jhendrixMSFT
pushed a commit
to jhendrixMSFT/azure-sdk-for-go
that referenced
this pull request
Jan 12, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes aad_identity_client.go and reimplements the credentials that were using it with MSAL clients. Adds recorded tests for these credentials so we don't lose all our test coverage. Closes #14920, closes #15632, closes #15973, closes #16118