Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove redundant conditon for job in release pipeline #16355

Merged
merged 4 commits into from
Dec 7, 2021
Merged

fix: remove redundant conditon for job in release pipeline #16355

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
91c42f8
fix: remove redundant conditon for job in release pipeline
tadelesh Dec 1, 2021
75e9428
build: release aztemplate 0.1.0 to test release pipeline
tadelesh Dec 2, 2021
93a8272
fix: revert condition of 'Skip.TagRepository'
tadelesh Dec 4, 2021
005fdfe
fix: add pool to 'check release' job to avoid lagging default image
tadelesh Dec 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion eng/pipelines/templates/jobs/archetype-go-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ stages:
jobs:
- deployment: TagRepository
displayName: "Create release tag"
condition: and(succeeded(), eq(variables['NeedToRelease'], 'true'), ne(variables['Skip.TagRepository'], 'true'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only want to remove the "NeedToRelease" part of this condition.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skip.TagRepository has already been checked with previous stage CheckRelease which is the dependency of this Release stage. So I removed it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm missing it but I don't see where Skip.TagRepository is checked. Can you point me to the place we check it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I've mixed the two conditions (Skip.Release, Skip.TagRepository) up 😟. I've fixed it.

environment: github

pool:
Expand Down