Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KeyVault] Add Immutable Property #16857

Merged
merged 14 commits into from
Feb 9, 2022
Merged

Conversation

seankane-msft
Copy link
Member

@seankane-msft seankane-msft commented Jan 19, 2022

Regenerate to the latest 7.3-preview swagger and add KeyReleasePolicy to the Client.UpdateKeyProperties method.

This change hasn't been rolled out to services, this will stay in draft until that is done.

@seankane-msft seankane-msft self-assigned this Jan 19, 2022
@seankane-msft seankane-msft marked this pull request as draft January 19, 2022 18:11
@seankane-msft seankane-msft marked this pull request as ready for review January 28, 2022 14:49
@seankane-msft
Copy link
Member Author

apiview link

sdk/keyvault/azkeys/client.go Show resolved Hide resolved
sdk/keyvault/azkeys/client.go Outdated Show resolved Hide resolved
sdk/keyvault/azkeys/client.go Outdated Show resolved Hide resolved
sdk/keyvault/azkeys/client.go Outdated Show resolved Hide resolved
sdk/keyvault/azkeys/client.go Show resolved Hide resolved
sdk/keyvault/azkeys/models.go Outdated Show resolved Hide resolved
sdk/keyvault/azkeys/models.go Outdated Show resolved Hide resolved
sdk/keyvault/azkeys/models.go Outdated Show resolved Hide resolved
sdk/keyvault/azkeys/models.go Show resolved Hide resolved
@seankane-msft seankane-msft requested a review from heaths January 31, 2022 15:51
Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off to unblock, but please be sure to use KeyOperation instead of KeyOperations (should be singular).

sdk/keyvault/azkeys/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One slight (unfortunate) change, but otherwise LGTM.

sdk/keyvault/azkeys/client.go Outdated Show resolved Hide resolved
@seankane-msft seankane-msft merged commit 829db10 into Azure:main Feb 9, 2022
@seankane-msft seankane-msft deleted the azkeys-immut branch February 9, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants