Refactor exported, internal public surface area #17595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internal packages are used to break circular dependencies. Some of this internal content is actually publicly exported via type aliases. To make it clear which internal parts are public, they've been moved into the internal/exported package along with comments indicating from where they're exposed. Moved some shared stuff that was just for pollers into internal/pollers. Added shared.BytesSetter interface to decouple the payload caching from the underlying implementation. Moved some non-shared constants around. Removed unused x-ms-date constant.
jhendrixMSFT
requested review from
RickWinter,
chlowell,
richardpark-msft and
seankane-msft
as code owners
chlowell
reviewed
Apr 14, 2022
chlowell
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal packages are used to break circular dependencies. Some of this
internal content is actually publicly exported via type aliases. To
make it clear which internal parts are public, they've been moved into
the internal/exported package along with comments indicating from where
they're exposed.
Moved some shared stuff that was just for pollers into internal/pollers.
Added shared.BytesSetter interface to decouple the payload caching from
the underlying implementation.
Moved some non-shared constants around.
Removed unused x-ms-date constant.
No functional or public surface area changes.